Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Only send current mode via wl_output #1099

Closed
emersion opened this issue Jun 29, 2018 · 3 comments · Fixed by #1968
Closed

Only send current mode via wl_output #1099

emersion opened this issue Jun 29, 2018 · 3 comments · Fixed by #1968
Labels

Comments

@emersion
Copy link
Member

emersion commented Jun 29, 2018

Modes were a protocol design mistake. If a client uses this information, it's probably broken.

GNOME does this.

@ddevault
Copy link
Contributor

I don't see any reason not to send modes. It's easy and in the protocol, and it's not dangerous if the client knows what other modes are available. I find it useful to enumerate modes with weston-info at times, too.

@emersion
Copy link
Member Author

Will discuss this with the rest of the Wayland community. If possible, I'd like those to get deprecated.

@emersion
Copy link
Member Author

I'd like to bump this again for two reasons:

emersion added a commit to emersion/wlroots that referenced this issue Dec 25, 2019
- Regular clients shouldn't care about modes
- Modes exposed are missing metadata such as aspect-ratio, interleaved, etc
- Modes exposed cannot be pruned [1]
- wlr-output-management provides a better API for privileged clients

[1]: https://gitlab.freedesktop.org/wayland/wayland/issues/92

Closes: swaywm#1099
ddevault pushed a commit that referenced this issue Dec 30, 2019
- Regular clients shouldn't care about modes
- Modes exposed are missing metadata such as aspect-ratio, interleaved, etc
- Modes exposed cannot be pruned [1]
- wlr-output-management provides a better API for privileged clients

[1]: https://gitlab.freedesktop.org/wayland/wayland/issues/92

Closes: #1099
filips pushed a commit to filips/wlroots that referenced this issue Mar 15, 2020
- Regular clients shouldn't care about modes
- Modes exposed are missing metadata such as aspect-ratio, interleaved, etc
- Modes exposed cannot be pruned [1]
- wlr-output-management provides a better API for privileged clients

[1]: https://gitlab.freedesktop.org/wayland/wayland/issues/92

Closes: swaywm#1099
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

2 participants