Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Crash when xwayland_surface_create returns NULL #1721

Closed
FreeFull opened this issue Jun 12, 2019 · 2 comments · Fixed by #2343
Closed

Crash when xwayland_surface_create returns NULL #1721

FreeFull opened this issue Jun 12, 2019 · 2 comments · Fixed by #2343
Labels
bug xwayland

Comments

@FreeFull
Copy link

FreeFull commented Jun 12, 2019 •
edited
Loading

swaywm/sway#4203 (comment)

This can be reproduced in both sway and rootston, by launching three instances of pysolfc.
@FreeFull
Copy link
Author

I'm not sure if this bug is still reproducible. At least, I can't reproduce it using pysolfc any more (although that might be due to a change in pysolfc itself).

emersion added a commit to emersion/wlroots that referenced this issue Jul 21, 2020
@emersion
xwayland/xwm: don't insert surface in list on error
ca56574 
In case wl_event_loop_add_timer errors out, don't insert the free'd
wlr_xwayland_surface in the list.

Closes: swaywm#1721
@emersion emersion mentioned this issue Jul 21, 2020
Merged
@emersion
Copy link
Member

Here's a fix: #2343

I'm not sure if this bug is still reproducible. At least, I can't reproduce it using pysolfc any more (although that might be due to a change in pysolfc itself).

Probably because libwayland doesn't create one timerfd per event loop timer anymore.

@emersion emersion added the bug label Jul 21, 2020
ddevault pushed a commit that referenced this issue Jul 22, 2020
@emersion @ddevault
xwayland/xwm: don't insert surface in list on error
cd4827b 
In case wl_event_loop_add_timer errors out, don't insert the free'd
wlr_xwayland_surface in the list.

Closes: #1721
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug xwayland
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xwayland/xwm: don't insert surface in list on error emersion/wlroots
2 participants
@emersion @FreeFull