Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Use GL_TEXTURE_2D instead of GL_TEXTURE_EXTERNAL_OES when possible #2173

Closed
emersion opened this issue May 8, 2020 · 1 comment · Fixed by #2255
Closed

Use GL_TEXTURE_2D instead of GL_TEXTURE_EXTERNAL_OES when possible #2173

emersion opened this issue May 8, 2020 · 1 comment · Fixed by #2255
Labels
enhancement renderer

Comments

@emersion
Copy link
Member

emersion commented May 8, 2020

This has performance implications on some drivers, see https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/322#note_329341

Interacts with #2133
@emersion
Copy link
Member Author

https://gitlab.freedesktop.org/wayland/weston/commit/40c519a3e613

emersion added a commit to emersion/wlroots that referenced this issue Jun 5, 2020
@emersion
render: choose DMA-BUF texture target via eglQueryDmaBufModifiersEXT
28c7cb0 
EGL_EXT_image_dma_buf_import_modifiers tells us whether we should use
GL_TEXTURE_2D or GL_TEXTURE_EXTERNAL_OES. Using the right texture target
can fix some failures and/or improve performance on some drivers.

This does the same as a Weston commit [1].

[1]: https://gitlab.freedesktop.org/wayland/weston/commit/40c519a3e613

Closes: swaywm#2173
emersion added a commit to emersion/wlroots that referenced this issue Jun 5, 2020
@emersion
render: choose DMA-BUF texture target via eglQueryDmaBufModifiersEXT
eb37f46 
EGL_EXT_image_dma_buf_import_modifiers tells us whether we should use
GL_TEXTURE_2D or GL_TEXTURE_EXTERNAL_OES. Using the right texture target
can fix some failures and/or improve performance on some drivers.

This does the same as a Weston commit [1].

[1]: https://gitlab.freedesktop.org/wayland/weston/commit/40c519a3e613

Closes: swaywm#2173
@emersion emersion mentioned this issue Jun 5, 2020
Merged
emersion added a commit to emersion/wlroots that referenced this issue Jun 5, 2020
@emersion
render: choose DMA-BUF texture target via eglQueryDmaBufModifiersEXT
25b826e 
EGL_EXT_image_dma_buf_import_modifiers tells us whether we should use
GL_TEXTURE_2D or GL_TEXTURE_EXTERNAL_OES. Using the right texture target
can fix some failures and/or improve performance on some drivers.

This does the same as a Weston commit [1].

[1]: https://gitlab.freedesktop.org/wayland/weston/commit/40c519a3e613

Closes: swaywm#2173
emersion added a commit that referenced this issue Jun 6, 2020
@emersion
render: choose DMA-BUF texture target via eglQueryDmaBufModifiersEXT
a3ba828 
EGL_EXT_image_dma_buf_import_modifiers tells us whether we should use
GL_TEXTURE_2D or GL_TEXTURE_EXTERNAL_OES. Using the right texture target
can fix some failures and/or improve performance on some drivers.

This does the same as a Weston commit [1].

[1]: https://gitlab.freedesktop.org/wayland/weston/commit/40c519a3e613

Closes: #2173
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement renderer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

render: choose DMA-BUF texture target via eglQueryDmaBufModifiersEXT emersion/wlroots
1 participant
@emersion