Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Don't leave bound EGL contexts behind #2197

Closed
emersion opened this issue May 15, 2020 · 0 comments · Fixed by #2206
Closed

Don't leave bound EGL contexts behind #2197

emersion opened this issue May 15, 2020 · 0 comments · Fixed by #2206

Comments

@emersion
Copy link
Member

In wlroots we often bind to an EGL context, do EGL operations, and then leave the context bound. Apart from making it harder to debug cases where we forget to bind the context, this also causes issues for multi-threaded compositors (since eglMakeCurrent fails when another thread has the context bound, even if correct synchronization is implemented).

emersion added a commit to emersion/wlroots that referenced this issue May 19, 2020
This function can be called after wlr_egl_make_current to cleanup the
EGL context. This avoids having lingering EGL contexts that make things
work by chance.

Closes: swaywm#2197
ddevault pushed a commit that referenced this issue May 19, 2020
This function can be called after wlr_egl_make_current to cleanup the
EGL context. This avoids having lingering EGL contexts that make things
work by chance.

Closes: #2197
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

1 participant