Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

gamma-control fails when an output is disabled #2372

Closed
emersion opened this issue Aug 17, 2020 · 2 comments · Fixed by #2380
Closed

gamma-control fails when an output is disabled #2372

emersion opened this issue Aug 17, 2020 · 2 comments · Fixed by #2380
Labels

Comments

@emersion
Copy link
Member

  1. Run a wlr-gamma-control client, like redshift
  2. Turn an output off
  3. The client sets a gamma
  4. wlroots makes it fail because it's not possible to set gamma for a disabled output

The client doesn't know that the output is disabled, so it can't wait for the output to be re-enabled. Instead, gamma-control should probably stash the pending gamma LUT somewhere, and apply it next time the output is enabled.

@emersion
Copy link
Member Author

emersion commented Sep 4, 2020

Note, we can't make the set_gamma call succeed when the output is disabled, because the output won't have a CRTC associated.

emersion added a commit to emersion/wlroots that referenced this issue Oct 22, 2020
emersion added a commit to emersion/wlroots that referenced this issue Nov 3, 2020
@emersion
Copy link
Member Author

emersion commented Nov 3, 2020

Sway users: swaywm/sway#5791

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

1 participant