Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Drop support for gtk-primary-selection #2421

Closed
2 tasks done
emersion opened this issue Oct 9, 2020 · 6 comments · Fixed by #2460
Closed
2 tasks done

Drop support for gtk-primary-selection #2421

emersion opened this issue Oct 9, 2020 · 6 comments · Fixed by #2460
Labels

Comments

@emersion
Copy link
Member

emersion commented Oct 9, 2020

The last blocking consumer of gtk-primary-selection now supports the standard protocol: https://gitlab.gnome.org/GNOME/gtk/-/issues/2591#note_920637 (released in GTK 3.24.24).

  • Remove gtk-primary-selection from Sway
  • Remove gtk-primary-selection from wlroots
@emersion
Copy link
Member Author

emersion commented Nov 3, 2020

GTK 3.24.23 doesn't contain the patch, we'll need to wait for the next release.

@emersion
Copy link
Member Author

emersion commented Dec 8, 2020

GTK 3.24.24 released 2 days ago contains the patch.

@arksunix
Copy link

These commits break a PRIMARY buffer in some applications, e.g. Firefox ESR on Wayland (and consequently Tor Browser Alpha). And it was removing support from Sway that broke the buffer, even though I have gtk version 3.24.29 (Arch Linux). Can you keep gtk-primary-selection support for now?

@emersion
Copy link
Member Author

GTK 3.24.29 should support the new protocol. Not sure what's going on here.

Can you keep gtk-primary-selection support for now?

Sorry, no.

@arksunix
Copy link

GTK 3.24.29 should support the new protocol. Not sure what's going on here.

However, manually returning support for gtk-primary-selection to Sway fixed the problem. I conclude from this that support for the old protocol remains in gtk.

@emersion
Copy link
Member Author

Yes, support for the old protocol is still there. But it should also support the new protocol.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

2 participants