Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

render/gles2: gles2_preferred_read_format relies on EGL config #2527

Closed
emersion opened this issue Dec 8, 2020 · 0 comments · Fixed by #2528
Closed

render/gles2: gles2_preferred_read_format relies on EGL config #2527

emersion opened this issue Dec 8, 2020 · 0 comments · Fixed by #2528
Labels
bug renderer

Comments

@emersion
Copy link
Member

emersion commented Dec 8, 2020

The EGL config is not to be trusted when an FBO is used. Additionally, since #2510 we may not have any EGL config selected.

Instead, we should check whether the current buffer format has an alpha channel.

[EGL] command: eglGetConfigAttrib, error: EGL_BAD_CONFIG (0x3005), message: "eglGetConfigAttrib"
@emersion emersion mentioned this issue Dec 8, 2020
Closed
emersion added a commit to emersion/wlroots that referenced this issue Dec 8, 2020
@emersion
render/gles2: query alpha size from render buffer
9f6f860 
If we're using a render buffer, query the alpha size from it.

Closes: swaywm#2527
@emersion emersion mentioned this issue Dec 8, 2020
Merged
emersion added a commit that referenced this issue Dec 9, 2020
@emersion
render/gles2: query alpha size from render buffer
f91e89f 
If we're using a render buffer, query the alpha size from it.

Closes: #2527
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug renderer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

render/gles2: query alpha size from render buffer emersion/wlroots
1 participant
@emersion