Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Drop wlr_render_ellipse #2759

Closed
emersion opened this issue Feb 23, 2021 · 4 comments · Fixed by #2808
Closed

Drop wlr_render_ellipse #2759

emersion opened this issue Feb 23, 2021 · 4 comments · Fixed by #2808

Comments

@emersion
Copy link
Member

emersion commented Feb 23, 2021

Drop wlr_render_ellipse and wlr_render_ellipse_with_matrix.

This is not useful for most compositors. Compositors that want to draw ellipses can just do it manually with GL calls.

cc @bl4ckb0ne

@emersion
Copy link
Member Author

cc @dos1: it seems like phoc is using it.

@dos1
Copy link
Contributor

dos1 commented Feb 24, 2021

We use it for drawing touch points in a debug mode (and wlr_render_rect is used the same way in a damage tracking debug mode).

emersion added a commit to emersion/wlroots that referenced this issue Mar 26, 2021
For anything more complicated than quads, compositors can easily
ship their own shaders.

Closes: swaywm#2759
@emersion
Copy link
Member Author

@dos1 I've submitted a pull request to drop support for ellipses: #2808. Does it sound reasonable to use rectangles instead of ellipses for touch point debugging? If you really want ellipses, does it sound reasonable to copy over the shader to phoc? (Just like some other compositors do for more advanced rendering features.)

@dos1
Copy link
Contributor

dos1 commented Mar 28, 2021

Haven't looked yet into how using custom shaders with wlr_renderer looks like - and I'd be interested in supporting the future pixman renderer well since there are plenty of phones that could be running phoc (for instance with postmarketOS) that don't have open GLES2 drivers. However, when it comes to touch points in particular I guess we could live with rectangles there anyway.

emersion added a commit that referenced this issue Apr 8, 2021
For anything more complicated than quads, compositors can easily
ship their own shaders.

Closes: #2759
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants