Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

9601a2 breaks rotations #2774

Closed
LaserEyess opened this issue Mar 10, 2021 · 4 comments · Fixed by #2775
Closed

9601a2 breaks rotations #2774

LaserEyess opened this issue Mar 10, 2021 · 4 comments · Fixed by #2775

Comments

@LaserEyess
Copy link

LaserEyess commented Mar 10, 2021

After commit 9601a2a my rotated monitor no longer works, reverting the commit fixes this issue.

Relevant config section:

output DP-1 {
    pos 0 0
    res 2560x1440@144Hz
    adaptive_sync on
}
output DP-2 {
    pos 2560 -500
    transform 270
    res 2560x1440@144Hz
    adaptive_sync on
}
output DP-3 {
    pos 4000 -200
    res 3840x2160@60Hz
    adaptive_sync on
    scale 2
}

DP-2 is affected, DP-1 and DP-3 are not. Will try to reproduce with a clean config.

@emersion
Copy link
Member

Can repro as well. Some notes:

  • Only repros with 90 and 270. 180 is fine.
  • Everything looks fine when the resolution is a square (width == height), so probably width and height need to be swapped somewhere.

@LaserEyess
Copy link
Author

On a clean config with nothing except those transforms, I can still reproduce it and as emersion says only 90/270 are affected.

emersion added a commit to emersion/wlroots that referenced this issue Mar 11, 2021
We need to adjust the second translation depending on the transform
we applied.

Fixes: 9601a2a ("output: improve transform matrix calculation"
Closes: swaywm#2774
@emersion
Copy link
Member

#2775

@LaserEyess
Copy link
Author

#2775 fixes this for me

emersion added a commit that referenced this issue Mar 11, 2021
We need to adjust the second translation depending on the transform
we applied.

Fixes: 9601a2a ("output: improve transform matrix calculation"
Closes: #2774
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants