This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
xwayland: Add WM_STATE modal property #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanDwyer
added a commit
to RyanDwyer/sway
that referenced
this pull request
Sep 2, 2018
Depends on swaywm/wlroots#1222. I don't know of a program that sets the state to modal without setting the window type, but I know the modal property works because logging the property shows it's true for the Firefox Open File dialog.
RyanDwyer
force-pushed
the
xwayland-state-properties
branch
from
f18df1b
to
485419e
Compare
Adds a modal property to indicate whether the surface wants to be a modal.
RyanDwyer
force-pushed
the
xwayland-state-properties
branch
from
485419e
to
d88c61c
Compare
RyanDwyer
changed the title
emersion
approved these changes
Sep 2, 2018
|
Thanks! |
RyanDwyer
added a commit
to RyanDwyer/sway
that referenced
this pull request
Sep 2, 2018
Depends on swaywm/wlroots#1222. I don't know of a program that sets the state to modal without setting the window type, but I know the modal property works because logging the property shows it's true for the Firefox Open File dialog.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
modalproperty to indicate whether the surface wants to be a modal.Also adds anI've removed this because theattentionproperty to indicate whether the surface wants attention, and introduces arequest_attentionevent.DEMANDS_ATTENTIONatom doesn't seem to do what I thought it would.