This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
xwayland: Introduce set_role event #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanDwyer
added a commit
to RyanDwyer/sway
that referenced
this pull request
Sep 2, 2018
RyanDwyer
added a commit
to RyanDwyer/sway
that referenced
this pull request
Sep 2, 2018
RyanDwyer
added a commit
to RyanDwyer/sway
that referenced
this pull request
Sep 2, 2018
RyanDwyer
force-pushed
the
xwayland-set-role
branch
from
b64bb4f
to
e628045
Compare
emersion
reviewed
Sep 2, 2018
xwayland/xwm.c
Outdated
| @@ -365,6 +368,36 @@ static void read_surface_class(struct wlr_xwm *xwm, | |||
| wlr_signal_emit_safe(&surface->events.set_class, surface); | |||
| } | |||
|
|
|||
| #ifdef WLR_HAS_XCB_ICCCM | |||
There was a problem hiding this comment.
It probably doesn't. I was reading about WM_WINDOW_ROLE at https://tronche.com/gui/x/icccm/sec-5.html and due to the page title and the fact that it has icccm in the URL, I drew the conclusion that it required ICCCM.
Should I remove the #ifdef?.
There was a problem hiding this comment.
xcb-icccm is an optional library that makes it easier to parse and format ICCCM messages. If we can parse some simple ICCCM messages without using xcb-icccm, I think we should go for it.
There was a problem hiding this comment.
Thanks for the explanation. I've removed the #ifdef.
I'm fine with |
RyanDwyer
force-pushed
the
xwayland-set-role
branch
from
e628045
to
b8cc4a4
Compare
emersion
approved these changes
Sep 3, 2018
|
Thanks! |
RyanDwyer
added a commit
to RyanDwyer/sway
that referenced
this pull request
Sep 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we want to name the event
set_roleorset_window_role?