meson: fix wayland-server minimum required version #1675
Conversation
|
Sent a patch to Alpine for 1.17 |
|
Hmm. This one is nasty because it'll cause a runtime error if you compile with 1.16 - not a compile-time error. Maybe we should revert @ascent12's patch until we get updated packages. |
|
Can we detect at runtime which version is in use and adjust our wl_seat version accordingly? |
|
In this particular case we can. This should stay temporary though, we're just lucky that new ABI hasn't been introduced. |
emersion
force-pushed
the
fix-wayland-version-check
branch
from
355771e
to
d24d515
Compare
|
I've filed FreeBSD bug for 1.17. |
emersion
force-pushed
the
fix-wayland-version-check
branch
2 times, most recently
from
e036664
to
e05bf34
Compare
emersion
force-pushed
the
fix-wayland-version-check
branch
from
e05bf34
to
b7fc611
Compare
|
I'm starting to wonder whether we should hold off landing patches because one of our CI distributions have an outdated dependency. This isn't that of a big deal for this PR, but maybe we should consider building wayland or wayland-protocols from source for other PRs. |
|
-1, I think we should be dilligent about pushing distros to keep their things up to date. |
|
Then let's block the DRM lease PR until released in wayland-protocols in all distros? |
|
Not really opposed to (1) blocking until the next wayland-protocols release which includes it and (2) the landing of that release in each distro we CI against. We need to usher that protocol into stability anyway to land it in Vulkan. |
emersion
force-pushed
the
fix-wayland-version-check
branch
from
b7fc611
to
40cb546
Compare
Having 1.16 results in the following error when running the compositor:
2019-04-27 17:30:50 - [wayland] wl_global_create: implemented version for 'wl_seat' higher than interface version (7 > 6)
2019-04-27 17:30:50 - [sway/input/seat.c:428] seat_create:could not allocate seat
We require wayland-server >= 1.17 for wl_seat version 7.
Fixes: a671fc5 ("Advertise wl_seat version 7")
Fixes: a656e48 ("seat: fallback to v6 if libwayland 1.17 isn't available")
emersion
force-pushed
the
fix-wayland-version-check
branch
from
40cb546
to
d5637d8
Compare
|
FreeBSD now has Wayland 1.17, so this PR is ready for review. |
Having 1.16 results in the following error when running the compositor:
2019-04-27 17:30:50 - [wayland] wl_global_create: implemented version for 'wl_seat' higher than interface version (7 > 6)
2019-04-27 17:30:50 - [sway/input/seat.c:428] seat_create:could not allocate seat
We require wayland-server >= 1.17 for wl_seat version 7.
Fixes: a671fc5
cc @ascent12