This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
backend/x11: Give X11 a real rendering loop #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Nov 2, 2019
|
This sounds like a good idea. I get a black screen when running this on Sway with |
Weird. All of the wlroots examples I tried were working fine. |
|
FWIW, I get a black screen with both my updated rootston fork and sway. |
Makes use of the present extension to get notified of vsync, and not require any stupid timer hacks. Also make use of the present version of ConfigureNotify, because why not?
|
I figured it out. I was forgetting to call |
|
Thanks! |
3 tasks
1 task
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Dec 22, 2020
Instead of using a timer, rely on X11 Present events and send a new frame event when the parent compositor displays a new frame on screen. [1]: swaywm#1894
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Dec 22, 2020
Instead of using a timer, rely on X11 Present events and send a new frame event when the parent compositor displays a new frame on screen. The previous attempt at doing this [1] hit issues with EGLSurface, but we don't use that anymore. [1]: swaywm#1894
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Dec 22, 2020
Instead of using a timer, rely on X11 Present events and send a new frame event when the parent compositor displays a new frame on screen. The previous attempt at doing this [1] hit issues with EGLSurface, but we don't use that anymore. [1]: swaywm#1894
emersion
added a commit
that referenced
this pull request
Dec 27, 2020
Instead of using a timer, rely on X11 Present events and send a new frame event when the parent compositor displays a new frame on screen. The previous attempt at doing this [1] hit issues with EGLSurface, but we don't use that anymore. [1]: #1894
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some work split out of one of my renderer v6 PRs.
Makes use of the present extension to get notified of vsync, and not require any stupid timer hacks. Also make use of the present version of ConfigureNotify, because why not?