This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
render: fix EGL extensions not loaded #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like it's working fine. At least the beginning of the debug logs from sway are ~identical now. log after your patch. |
ddevault
approved these changes
Dec 20, 2019
|
That arch failure is weird. |
|
It's an arch packaging issue: |
|
Reported here: https://bugs.archlinux.org/task/64914 |
|
I can confirm that this branch fixes swaywm/sway#4828 |
|
This also fixes vulkan not working since commit 515679e. Various extensions were not detected, swapchain could not be created (steam, vkcube). |
|
Can you rebase this? |
Some extensions are only advertised by the EGL implementation with a non-zero EGLDisplay. That's the case when the extension can only be enabled when the hardware/driver supports it for instance. Instead of checking for all extensions without a display, check only for EGL_EXT_platform_base and EGL_KHR_debug which are used before eglGetDisplay. Check for all other extensions when we have a display. Closes: swaywm#1955
emersion
force-pushed
the
fix-egl-ext
branch
from
f051a4b
to
cfbeec9
Compare
|
Done |
ddevault
approved these changes
Dec 21, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extensions are only advertised by the EGL implementation with a
non-zero EGLDisplay. That's the case when the extension can only be
enabled when the hardware/driver supports it for instance.
Instead of checking for all extensions without a display, check only for
EGL_EXT_platform_base and EGL_KHR_debug which are used before
eglGetDisplay. Check for all other extensions when we have a display.
Closes: #1955
Closes: swaywm/sway#4828