This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
util/log: improve time prefix #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, maybe we should consider dropping the current date (the YYYY-MM-DD part) to get a smaller log prefix. |
emersion
added a commit
to emersion/sway
that referenced
this pull request
Mar 5, 2020
Same as [1]. [1]: swaywm/wlroots#2052
ddevault
approved these changes
Mar 6, 2020
Agreed. Maybe we should log a monotonic clock in terms of seconds since the compositor began? |
Log milliseconds. This is useful when debugging a rendering loop. Print the time relative to the compositor start-up.
emersion
force-pushed
the
log-with-ms
branch
2 times, most recently
from
6966369
to
7812224
Compare
|
Good idea, changed the commit to do that. |
emersion
changed the title
ddevault
approved these changes
Mar 6, 2020
|
Thanks! |
emersion
added a commit
to emersion/sway
that referenced
this pull request
Mar 6, 2020
Same as [1]. [1]: swaywm/wlroots#2052
emersion
added a commit
to emersion/sway
that referenced
this pull request
Mar 6, 2020
Same as [1]. [1]: swaywm/wlroots#2052
ddevault
pushed a commit
to swaywm/sway
that referenced
this pull request
Mar 6, 2020
Same as [1]. [1]: swaywm/wlroots#2052
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when debugging a rendering loop.