This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
output: make wlr_output_schedule_frame set output->needs_frame #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, wlr_output_schedule_frame will always be followed by a wlr_output_commit. This forces the compositor to render an extra frame before stopping the rendering loop. To test, run wleird's frame-callback [1], make sure it's the only visible client on the output and check the interval between frame events is the output's refresh period instead of zero. [1]: https://github.com/emersion/wleird/blob/master/frame-callback.c Closes: swaywm#2051
emersion
force-pushed
the
fix-output-schedule-frame
branch
from
be21ccf
to
8e3f648
Compare
emersion
added a commit
to emersion/sway
that referenced
this pull request
Mar 5, 2020
wlr_output_schedule_frame now sets output->needs_frame [1], so this isn't needed anymore. [1]: swaywm/wlroots#2053
ddevault
approved these changes
Mar 6, 2020
|
Thanks! |
ddevault
pushed a commit
to swaywm/sway
that referenced
this pull request
Mar 6, 2020
wlr_output_schedule_frame now sets output->needs_frame [1], so this isn't needed anymore. [1]: swaywm/wlroots#2053
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Mar 12, 2020
Add a comment to not forget why this call is necessary. References: swaywm#2053
ddevault
pushed a commit
that referenced
this pull request
Mar 12, 2020
Add a comment to not forget why this call is necessary. References: #2053
filips
pushed a commit
to filips/wlroots
that referenced
this pull request
Mar 15, 2020
Add a comment to not forget why this call is necessary. References: swaywm#2053
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, wlr_output_schedule_frame will always be followed by a
wlr_output_commit. This forces the compositor to render an extra
frame before stopping the rendering loop.
To test, run wleird's frame-callback 1, make sure it's the only
visible client on the output and check the interval between frame
events is the output's refresh period instead of zero.
Closes: #2051