Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

xwayland: split server #2175

Merged
merged 2 commits into from May 19, 2020
Merged

Conversation

emersion
Copy link
Member

@emersion emersion commented May 8, 2020

Split the server part of wlr_xwayland into wlr_xwayland_server. This
allows compositors to implement their own XWM when wlroots' isn't a good
fit.

Sway PR: swaywm/sway#5314 A Sway PR isn't necessary for this change.


Breaking change: wlr_xwayland.display_name is now a const char * field. Most compositors should still be able to use it like before. Server-specific fields have been moved from wlr_xwayland to wlr_xwayland_server.

@emersion emersion added the breaking Breaking change in public API label May 8, 2020
@emersion emersion requested a review from ddevault May 8, 2020 09:22
emersion added a commit to emersion/sway that referenced this pull request May 8, 2020
@emersion emersion marked this pull request as draft May 8, 2020 10:04
emersion added a commit to emersion/gamescope that referenced this pull request May 19, 2020
Use wlr_xwayland_server, which allows enough customization for us.

References: swaywm/wlroots#2175
Closes: ValveSoftware#15
@emersion emersion marked this pull request as ready for review May 19, 2020 15:29
@emersion
Copy link
Member Author

This is now ready for review.

Question: should we keep wlr_xwayland.display_name and copy the value from wlr_xwayland_server.display_name instead of adding wlr_xwayland_display_name?

Split the server part of wlr_xwayland into wlr_xwayland_server. This
allows compositors to implement their own XWM when wlroots' isn't a good
fit.
@emersion
Copy link
Member Author

Actually, changed my mind and made wlr_xwayland.display a const char *.

@ddevault
Copy link
Member

Thanks!

@ddevault ddevault merged commit 2176c63 into swaywm:master May 19, 2020
emersion added a commit to ValveSoftware/gamescope that referenced this pull request May 19, 2020
Use wlr_xwayland_server, which allows enough customization for us.

References: swaywm/wlroots#2175
Closes: #15
@emersion emersion added this to the 0.11.0 milestone Jul 15, 2020
dominikh added a commit to dominikh/go-wlroots that referenced this pull request Sep 21, 2020
The only relevant change is swaywm/wlroots#2175.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change in public API
Development

Successfully merging this pull request may close these issues.

None yet

2 participants