Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Replace wlr_key_state with wl_keyboard_key_state #2446

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

ifreund
Copy link
Member

@ifreund ifreund commented Oct 21, 2020

There's no reason to have duplicate enums.


Breaking change: enum wlr_key_state has been replaced with enum wl_keyboard_key_state.

There's no reason to have duplicate enums
@ddevault ddevault added the breaking Breaking change in public API label Oct 21, 2020
@ifreund
Copy link
Member Author

ifreund commented Oct 21, 2020

I've just realized that we have the same issue with wlr_button_state. If this is deemed to be the direction we want to take I would be happy to make the parallel change there.

@emersion
Copy link
Member

I think the original intention was to keep apart the protocol bits and the backend interface bits. But duplicating the enums doesn't really make sense to me, since wlroots is a Wayland compositor library, not a generic GUI library.

@ifreund
Copy link
Member Author

ifreund commented Oct 22, 2020

Found another: wlr_edges duplicates xdg_toplevel.resize_edge.

@Xyene
Copy link
Member

Xyene commented Oct 22, 2020

Note that Sway, at least, uses wlr_edges to represent resize edges of non-xdg_toplevel things, e.g. Xwayland containers. (It seems to be used to similar effect in xwayland/xwm.c etc.)

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The enum wl_keyboard_key_state values have the same values as enum wlr_key_state.

@emersion emersion merged commit 7693f61 into swaywm:master Nov 11, 2020
@emersion
Copy link
Member

Thanks!

emersion added a commit to swaywm/sway that referenced this pull request Nov 11, 2020
@ifreund ifreund deleted the keystate branch November 11, 2020 11:04
@emersion emersion mentioned this pull request Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change in public API
Development

Successfully merging this pull request may close these issues.

None yet

4 participants