This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
render: add wlr_renderer_get_dmabuf_render_formats #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
render-formats
branch
from
fb366b3
to
da8889b
Compare
This was referenced Nov 25, 2020
emersion
force-pushed
the
render-formats
branch
from
da8889b
to
2074c20
Compare
Make it clear formats returned are only suitable for import/sampling. These formats can't be used to be rendered to.
Instead, callers can just use wlr_renderer_get_formats and iterate over the list. This function was unused in wlroots.
It describes which DMA-BUF formats can be used to render.
When allocating buffers, use a format suitable for rendering. This avoids picking a format that won't work.
Rename wlr_renderer_get_dmabuf_formats to wlr_renderer_get_dmabuf_texture_formats. This makes it clear the formats are only suitable for creating wlr_textures.
Rename wlr_renderer_get_formats to wlr_renderer_get_shm_texture_formats. This makes it clear those formats are only suitable for shm import.
The Wayland protocol requires those to be supported.
emersion
force-pushed
the
render-formats
branch
from
2074c20
to
387843c
Compare
Replace it with wlr_egl.dmabuf_render_formats.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this PR is to ensure we select a format we can render to in the headless backend.
It contains also some breaking changes that clarify what formats advertised by
wlr_rendererare good for.Breaking changes:
wlr_egl_get_dmabuf_formatshas been renamed towlr_egl_get_dmabuf_texture_formatswlr_renderer_get_formatshas been renamed towlr_renderer_get_shm_texture_formatswlr_renderer_get_dmabuf_formatshas been renamed towlr_renderer_get_dmabuf_texture_formatswlr_renderer_format_supportedhas been removed (instead, usewlr_renderer_get_shm_texture_formats)