Remove wlr_egl from backends

[bl4ckb0ne]

Removes the wlr_egl member from various backend to keep it into the wlr_renderer. This also removes various includes of the render/egl.h header that were made useless by this patch.

References: #2563

---

Breaking change: wlr_renderer_autocreate no longer takes a struct wlr_egl * as parameter.

[emersion]

Thanks for working on this! Here are a few comments.

This needs to be rebased on top of #2593.

[emersion]

This memory is leaked when the renderer is destroyed.

I think long-term we'll want to either:

• Allocate the wlr_egl as part of the wlr_gles2_renderer. This means wlr_gles2_renderer_create would need to take all arguments necessary for the call to wlr_egl_init.
• Make wlr_gles2_renderer_create take over the wlr_egl (kind of like you're doing in this PR), and replace wlr_egl_init/wlr_egl_finish with wlr_egl_create/wlr_egl_destroy so that the GLES2 renderer can cleanly free the wlr_egl (this would ensuring it's not part of a larger structure).

For this PR we can probably just free(renderer->egl) when destroying the GLES2 renderer, and properly document that wlr_gles2_renderer_create takes ownership of the wlr_egl?

[bl4ckb0ne]

Huh, I was sure I added the free in the wlr_renderer_destroy function. Good catch.
I like the idea of wlr_gles2_renderer becoming the owner of wlr_egl, it makes more sense when we will add the pixman backend.

I'll slap a nice comment and a TODO.

[emersion]

OK. I slightly edited the PR to also add a note in the header defining wlr_gles2_renderer_create.

[emersion]

Also, is it possible to get rid of the unnecessary includes in a separate commit?

[bl4ckb0ne]

There you we go, I can reword the commit if you want, I put in something generic since it affects two both the backend and the render folder. I also rebased the patch to get the modifications from #2563

[emersion]

LGTM, thanks!