Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Pixman renderer #2661

Merged
merged 7 commits into from Apr 17, 2021
Merged

Pixman renderer #2661

merged 7 commits into from Apr 17, 2021

Conversation

bl4ckb0ne
Copy link
Contributor

@bl4ckb0ne bl4ckb0ne commented Jan 18, 2021 •
edited by emersion

Closes: #2399

emersion
emersion reviewed Jan 18, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
@emersion emersion marked this pull request as draft January 18, 2021 10:40
@bl4ckb0ne bl4ckb0ne force-pushed the pixman_render branch 4 times, most recently from ebc6551 to 5a6dfc8 Compare January 28, 2021 02:38
emersion
emersion reviewed Feb 16, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 16, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 16, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 16, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 16, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
@bl4ckb0ne bl4ckb0ne mentioned this pull request Feb 17, 2021
Closed
@bl4ckb0ne bl4ckb0ne force-pushed the pixman_render branch 2 times, most recently from b351a9c to e284407 Compare February 17, 2021 14:23
emersion
emersion reviewed Feb 18, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 18, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 18, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 18, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 18, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
@bl4ckb0ne bl4ckb0ne force-pushed the pixman_render branch 7 times, most recently from 09b2fc2 to 6ce65ad Compare April 1, 2021 16:35
emersion
emersion reviewed Apr 7, 2021
View reviewed changes
meson.build Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c
uint32_t drm_format;
struct wlr_dmabuf_attributes dmabuf = {0};
struct wlr_shm_attributes shm = {0};
if (wlr_buffer_get_dmabuf(wlr_buffer, &dmabuf)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: calling get_dmabuf/get_shm just to get the pixel format isn't too great. But it's fine for now, let's fix this later.

emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 15, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Apr 16, 2021
View reviewed changes
render/pixman/renderer.c Outdated Show resolved Hide resolved
@emersion
Copy link
Member

I'm no longer able to reproduce the render_quad glitches in Sway. I'm guessing memcpy'ing the matrices fixed it.

With that out of the way, I think we have a fairly complete renderer, even if there's some room for future improvements. :)

@bl4ckb0ne
Copy link
Contributor Author

I second the fix on the render_quad fix, wasn't able to reproduce.

emersion
emersion approved these changes Apr 17, 2021
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@emersion emersion merged commit 122d6c6 into swaywm:master Apr 17, 2021
This was referenced Apr 17, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pixman software renderer
2 participants
@bl4ckb0ne @emersion