This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
render/egl: fail to create wlr_egl on software renderer #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl4ckb0ne
force-pushed
the
detect_software_rendering
branch
from
5810fbb
to
b3fc5d0
Compare
emersion
suggested changes
Jan 27, 2021
render/egl.c
Outdated
| @@ -272,6 +272,14 @@ struct wlr_egl *wlr_egl_create(EGLenum platform, void *remote_display, | |||
| goto error; | |||
| } | |||
|
|
|||
| if (check_egl_ext(device_exts_str, "EGL_MESA_device_software") && | |||
| !getenv("WLR_RENDERER_ALLOW_SOFTWARE")) { | |||
There was a problem hiding this comment.
Can we only lift the check if the env var is exactly "1"? Other WLR_ env vars ignore other values (like "0").
The creation of `wlr_egl` will fail is the device extension EGL_MESA_device_software is defined. The creation process is allowed to continue only if the environment variable `WLR_RENDERER_ALLOW_SOFTWARE` is defined to the value 1.
bl4ckb0ne
force-pushed
the
detect_software_rendering
branch
from
b3fc5d0
to
a01012e
Compare
|
I added the doc, tell me if you see any spelling mistake. |
emersion
reviewed
Jan 27, 2021
| @@ -39,6 +39,11 @@ wlroots reads these environment variables | |||
|
|
|||
| * *WLR_X11_OUTPUTS*: when using the X11 backend specifies the number of outputs | |||
|
|
|||
| ## gles2 renderer | |||
|
|
|||
| * *WLR_RENDERER_ALLOW_SOFTWARE*: allows the gles2 renderer to use software | |||
There was a problem hiding this comment.
Note to self: this is a GLES2-specific variable, but it doesn't contain "GLES2" in the name. I'd like to implement a similar check in other non-GLES2 renderers such as Vulkan.
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Mar 15, 2021
Mesa may advertise EGL_MESA_device_software even when hardware drivers are in use. Demote the error to a warning until the Mesa bug is fixed. [1]: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4178 References: swaywm#2689
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Mar 15, 2021
Mesa may advertise EGL_MESA_device_software even when hardware drivers are in use [1]. Demote the error to a warning until the Mesa bug is fixed. [1]: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4178 References: swaywm#2689
emersion
added a commit
that referenced
this pull request
Mar 15, 2021
Mesa may advertise EGL_MESA_device_software even when hardware drivers are in use [1]. Demote the error to a warning until the Mesa bug is fixed. [1]: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4178 References: #2689
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of
wlr_eglwill fail is the device extensionEGL_MESA_device_software is defined. The creation process is allowed to
continue only if the environment variable
WLR_RENDERER_ALLOW_SOFTWAREis defiled.