This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Remove gl matrix from public rendering interface part1 #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl4ckb0ne
force-pushed
the
render_gl_matrix
branch
2 times, most recently
from
f334a04
to
b6e9363
Compare
bl4ckb0ne
force-pushed
the
render_gl_matrix
branch
from
333126e
to
6af5d32
Compare
bl4ckb0ne
changed the title
|
Closed for not being relevant anymore since we fixed the matrix issue in #2770 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is the first part of an ongoing progress to remove the GL-assumptions from the public interface of
wlr_renderer.Here any mention of "transform matrix" is removed from the public API, and all of the matrix calculations for rendering a texture is done inside the gles2 renderer. This is done because the future pixman renderer can't use matrices to calculate position and requires an explicit x/y position.
@emersion I was thinking about leaving the
wlr_render_*_with_matrixfunctions for the next release to ease the transition and label them with a deprecation warning, and then remove them later on.