Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

xwayland: ICCCM improvements #2813

Merged
merged 3 commits into from
Mar 29, 2021
Merged

xwayland: ICCCM improvements #2813

merged 3 commits into from
Mar 29, 2021

Commits on Mar 29, 2021

  1. xwayland: assume no WM_HINTS means window wants input 

    Some X11 clients (e.g. Chromium, sxiv) don't set WM_HINTS. The spec
says:

> Window managers are free to assume convenient values for all fields of the
> WM_HINTS property if a window is mapped without one.

Our wlr_xwayland_icccm_input_model function assumes missing WM_HINTS
means the window doesn't want input, but this is incorrect. Assume the
window wants input unless it explicitly opts-out by setting WM_HINTS.

Closes: swaywm/sway#6107
    @emersion
    emersion committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    4f9a449 View commit details
    Browse the repository at this point in the history

  2. xwayland: require xcb-icccm 

    This dependency is already required by many other widely used X11
programs, such as i3, Qt, and other XWMs. So it should be available
on most systems.

X11 support can be pretty broken without xcb-icccm, with focus issues
for instance. Let's just remove this --please-break-my-desktop footgun
option.
    @emersion
    emersion committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    42040e4 View commit details
    Browse the repository at this point in the history

  3. xwayland: use ICCCM state defines from xcb-icccm

    @emersion
    emersion committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    c7c75d9 View commit details
    Browse the repository at this point in the history