Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

backend/drm: don't clear pending cursor FB on failed commit #3021

Merged
merged 2 commits into from
Jul 5, 2021
Merged

backend/drm: don't clear pending cursor FB on failed commit #3021

merged 2 commits into from
Jul 5, 2021

Commits on Jul 5, 2021

  1. Revert "backend/drm: populate cursor plane's current_fb" 

    This reverts commit 6c3d080.

Populating wlr_drm_plane.current_fb messes up the buffer's locking.
The previous buffer is released while it's still being displayed
on-screen.
    @emersion
    emersion committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    28f738e View commit details
    Browse the repository at this point in the history

  2. backend/drm: don't clear pending cursor FB on failed commit 

    The previous fix tried to side-step cursor->pending_fb completely.
However that messes up our buffer locking mechanism.

Instead, stop clearing the pending cursor FB on a failed commit. The
pending cursor FB will remain for the next commit.

Fixes: 6c3d080 ("backend/drm: populate cursor plane's current_fb")
    @emersion
    emersion committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    fd21b0d View commit details
    Browse the repository at this point in the history