This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Changed broken example rootston keybinding #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclement
changed the title
I guess, but I don't really care. Fix it if it pleases you. Rootston isn't designed to be a particularly useful compositor, beyond demonstrating wlroots features I don't care how well it works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Shiftis part of theLogo+Shift+ekeybinding, theekeysym is never received, onlyE.Should rootston be detecting the presence of
Shiftand automatically working out that it should switch the expected keysyms to uppercase (I guess by querying the xkb layout)? I looked into it briefly, but couldn't tell if there is any simple way to do this.