Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: script workspaces from package.json on publishing #153

Merged
merged 1 commit into from
Jul 20, 2023
Merged

chore: script workspaces from package.json on publishing #153

merged 1 commit into from
Jul 20, 2023

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Jul 19, 2023

Closes #101

PR modifies the publish workflow such that a new helper script will be called before publishing to strip out the workspaces value in the package.json file, and a post publish step that restores the original package.json file. This avoids publishing the package with this additional key that causes a warning in yarn, but should otherwise not affect any other part of the dev flow.

To test, can run:

$ npm run prepublishOnly
# should have modified package.json & package.json.bak
$ npm run postpublish
# should only have original package.json

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Matthew Peveler <matt@popsql.com>
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 merged commit 887fb53 into swc-project:master Jul 20, 2023
3 checks passed
@MasterOdin MasterOdin deleted the package-workspaces branch August 2, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants