fix: respect useDefineForClassFields tsconfig value

swc-project · Nov 12, 2023 · d183146 · d183146
1 parent bc910be
commit d183146
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/packages/core/index.ts b/packages/core/index.ts
@@ -17,6 +17,7 @@ export interface Options {
   jsx?: boolean
   experimentalDecorators?: boolean
   emitDecoratorMetadata?: boolean
+  useDefineForClassFields?: boolean
   dynamicImport?: boolean
   esModuleInterop?: boolean
   keepClassNames?: boolean
@@ -49,6 +50,7 @@ function transformOption(path: string, options?: Options, jest = false): SwcOpti
           transform: {
             legacyDecorator: Boolean(opts.experimentalDecorators),
             decoratorMetadata: Boolean(opts.emitDecoratorMetadata),
+            useDefineForClassFields: Boolean(opts.useDefineForClassFields),
             react: options?.react,
             // @ts-expect-error
             hidden: {

diff --git a/packages/register/__test__/ts-compiler-options-to-swc-config.spec.ts b/packages/register/__test__/ts-compiler-options-to-swc-config.spec.ts
@@ -15,6 +15,7 @@ test('default values', (t) => {
     sourcemap: false,
     experimentalDecorators: false,
     emitDecoratorMetadata: false,
+    useDefineForClassFields: false,
     esModuleInterop: false,
     dynamicImport: true,
     externalHelpers: false,
@@ -99,6 +100,7 @@ test('should set all values', (t) => {
     target: 'es5',
     experimentalDecorators: options.experimentalDecorators,
     emitDecoratorMetadata: options.emitDecoratorMetadata,
+    useDefineForClassFields: false,
     esModuleInterop: options.esModuleInterop,
     externalHelpers: true,
     dynamicImport: true,

diff --git a/packages/register/read-default-tsconfig.ts b/packages/register/read-default-tsconfig.ts
@@ -97,6 +97,24 @@ function toModule(moduleKind: ts.ModuleKind) {
   }
 }
 
+// https://github.com/microsoft/TypeScript/blob/fc418a2e611c88cf9afa0115ff73490b2397d311/src/compiler/utilities.ts#L8556
+function getEmitScriptTarget(compilerOptions: {
+  module?: ts.CompilerOptions['module']
+  target?: ts.CompilerOptions['target']
+}): ts.ScriptTarget {
+  return (
+    compilerOptions.target ??
+    ((compilerOptions.module === ts.ModuleKind.Node16 && ts.ScriptTarget.ES2022) ||
+      (compilerOptions.module === ts.ModuleKind.NodeNext && ts.ScriptTarget.ESNext) ||
+      ts.ScriptTarget.ES5)
+  )
+}
+
+// https://github.com/microsoft/TypeScript/blob/fc418a2e611c88cf9afa0115ff73490b2397d311/src/compiler/utilities.ts#L8761
+function getUseDefineForClassFields(compilerOptions: ts.CompilerOptions): boolean {
+  return compilerOptions.useDefineForClassFields ?? getEmitScriptTarget(compilerOptions) >= ts.ScriptTarget.ES2022
+}
+
 export function tsCompilerOptionsToSwcConfig(options: ts.CompilerOptions, filename: string): Options {
   const isJsx = filename.endsWith('.tsx') || filename.endsWith('.jsx') || Boolean(options.jsx)
   return {
@@ -106,12 +124,13 @@ export function tsCompilerOptionsToSwcConfig(options: ts.CompilerOptions, filena
     sourcemap: options.sourceMap && options.inlineSourceMap ? 'inline' : Boolean(options.sourceMap),
     experimentalDecorators: options.experimentalDecorators ?? false,
     emitDecoratorMetadata: options.emitDecoratorMetadata ?? false,
+    useDefineForClassFields: getUseDefineForClassFields(options),
     esModuleInterop: options.esModuleInterop ?? false,
     dynamicImport: true,
     keepClassNames: true,
     externalHelpers: Boolean(options.importHelpers),
     react:
-      options.jsxFactory || options.jsxFragmentFactory || options.jsx || options.jsxImportSource
+      options.jsxFactory ?? options.jsxFragmentFactory ?? options.jsx ?? options.jsxImportSource
         ? {
             pragma: options.jsxFactory,
             pragmaFrag: options.jsxFragmentFactory,