fix(es/minifier): Don't inline a callable expression if it's used as …

…a reference (#5118)

crates/swc/tests/fixture/issues-2xxx/2011/reduced/output/index.js

@@ -1,8 +1,8 @@
-var a;
+var a, b = function() {};
 module.exports = ((a = function() {
     "use strict";
     function a() {}
     return a.prototype.it = function() {
         this.bb = new a.MyA();
     }, a;
-}()).MyA = function() {}, a);
+}()).MyA = b, a);

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithModulesExportedGenericFunctionAndGenericClassStaticFunctionOfTheSameName_es5.2.minified.js

@@ -6,6 +6,9 @@ var clodule = function() {
     }
     return clodule.fn = function(id) {}, clodule;
 }();
-(clodule || (clodule = {})).fn = function(x, y) {
-    return x;
-};
+!function(clodule) {
+    var fn = function(x, y) {
+        return x;
+    };
+    clodule.fn = fn;
+}(clodule || (clodule = {}));

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithModulesExportedGenericFunctionAndNonGenericClassStaticFunctionOfTheSameName_es5.2.minified.js

@@ -6,6 +6,9 @@ var clodule = function() {
     }
     return clodule.fn = function(id) {}, clodule;
 }();
-(clodule || (clodule = {})).fn = function(x, y) {
-    return x;
-};
+!function(clodule) {
+    var fn = function(x, y) {
+        return x;
+    };
+    clodule.fn = fn;
+}(clodule || (clodule = {}));

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithStaticFunctionAndExportedFunctionThatShareAName_es5.2.minified.js

@@ -11,9 +11,12 @@ var A, Point = function() {
         };
     }, Point;
 }();
-(Point || (Point = {})).Origin = function() {
-    return null;
-}, function(A) {
+!function(Point) {
+    var Origin = function() {
+        return null;
+    };
+    Point.Origin = Origin;
+}(Point || (Point = {})), function(A) {
     var Point = function() {
         "use strict";
         function Point(x, y) {

crates/swc/tests/tsc-references/ExportFunctionWithAccessibleTypesInParameterAndReturnTypeAnnotation_es5.2.minified.js

@@ -1,19 +1,19 @@
 var A;
 import _class_call_check from "@swc/helpers/src/_class_call_check.mjs";
 !function(A) {
-    var Point = function() {
+    var fromOrigin = function(p) {
+        return new Line({
+            x: 0,
+            y: 0
+        }, p);
+    }, Point = function() {
         "use strict";
         _class_call_check(this, Point);
     };
     A.Point = Point;
-    var Line = function(start, end) {
+    var Line = function Line(start, end) {
         "use strict";
         _class_call_check(this, Line), this.start = start, this.end = end;
     };
-    A.Line = Line, A.fromOrigin = function(p) {
-        return new Line({
-            x: 0,
-            y: 0
-        }, p);
-    };
+    A.Line = Line, A.fromOrigin = fromOrigin;
 }(A || (A = {}));

crates/swc/tests/tsc-references/ExportFunctionWithInaccessibleTypesInParameterTypeAnnotation_es5.2.minified.js

@@ -1,17 +1,17 @@
 var A;
 import _class_call_check from "@swc/helpers/src/_class_call_check.mjs";
 !function(A) {
-    var Point = function() {
-        "use strict";
-        _class_call_check(this, Point);
-    }, Line = function(start, end) {
-        "use strict";
-        _class_call_check(this, Line), this.start = start, this.end = end;
-    };
-    A.Line = Line, A.fromOrigin = function(p) {
+    var fromOrigin = function(p) {
         return new Line({
             x: 0,
             y: 0
         }, p);
+    }, Point = function() {
+        "use strict";
+        _class_call_check(this, Point);
+    }, Line = function Line(start, end) {
+        "use strict";
+        _class_call_check(this, Line), this.start = start, this.end = end;
     };
+    A.Line = Line, A.fromOrigin = fromOrigin;
 }(A || (A = {}));

crates/swc/tests/tsc-references/ExportFunctionWithInaccessibleTypesInReturnTypeAnnotation_es5.2.minified.js

@@ -1,19 +1,19 @@
 var A;
 import _class_call_check from "@swc/helpers/src/_class_call_check.mjs";
 !function(A) {
-    var Point = function() {
+    var fromOrigin = function(p) {
+        return new Line({
+            x: 0,
+            y: 0
+        }, p);
+    }, Point = function() {
         "use strict";
         _class_call_check(this, Point);
     };
     A.Point = Point;
-    var Line = function(start, end) {
+    var Line = function Line(start, end) {
         "use strict";
         _class_call_check(this, Line), this.start = start, this.end = end;
     };
-    A.fromOrigin = function(p) {
-        return new Line({
-            x: 0,
-            y: 0
-        }, p);
-    };
+    A.fromOrigin = fromOrigin;
 }(A || (A = {}));

crates/swc/tests/tsc-references/FunctionAndModuleWithSameNameAndCommonRoot_es5.2.minified.js

@@ -1,10 +1,13 @@
 var A, B;
-(A || (A = {})).Point = function() {
-    return {
-        x: 0,
-        y: 0
+!function(A) {
+    var Point = function() {
+        return {
+            x: 0,
+            y: 0
+        };
     };
-}, function(A) {
+    A.Point = Point;
+}(A || (A = {})), function(A) {
     (A.Point || (A.Point = {})).Origin = {
         x: 0,
         y: 0

crates/swc/tests/tsc-references/FunctionAndModuleWithSameNameAndDifferentCommonRoot_es5.2.minified.js

@@ -1,10 +1,13 @@
 var A, B;
-(A || (A = {})).Point = function() {
-    return {
-        x: 0,
-        y: 0
+!function(A) {
+    var Point = function() {
+        return {
+            x: 0,
+            y: 0
+        };
     };
-}, function(B) {
+    A.Point = Point;
+}(A || (A = {})), function(B) {
     (B.Point || (B.Point = {})).Origin = {
         x: 0,
         y: 0

crates/swc/tests/tsc-references/ModuleAndFunctionWithSameNameAndCommonRoot_es5.2.minified.js

@@ -4,12 +4,15 @@ var A, B;
         x: 0,
         y: 0
     };
-}(A || (A = {})), (A || (A = {})).Point = function() {
-    return {
-        x: 0,
-        y: 0
+}(A || (A = {})), function(A) {
+    var Point = function() {
+        return {
+            x: 0,
+            y: 0
+        };
     };
-}, function(B) {
+    A.Point = Point;
+}(A || (A = {})), function(B) {
     var Point = function() {
         return {
             x: 0,

crates/swc/tests/tsc-references/ModuleWithExportedAndNonExportedFunctions_es5.2.minified.js

@@ -1,8 +1,9 @@
 var A;
 !function(A) {
-    A.fn = function(s) {
+    var fn = function(s) {
         return !0;
-    }, A.fng = function(s) {
+    }, fng = function(s) {
         return null;
     };
+    A.fn = fn, A.fng = fng;
 }(A || (A = {})), A.fn, A.fng, A.fn2, A.fng2;

crates/swc/tests/tsc-references/commonJSAliasedExport_es5.2.minified.js

@@ -1,8 +1,9 @@
+var donkey = function(ast) {
+    return ast;
+};
 function funky(declaration) {
     return !1;
 }
-module.exports = function(ast) {
-    return ast;
-}, module.exports.funky = funky;
+module.exports = donkey, module.exports.funky = funky;
 var funky = require("./commonJSAliasedExport").funky;
 funky(1);

crates/swc/tests/tsc-references/everyTypeWithAnnotationAndInitializer_es5.2.minified.js

@@ -7,11 +7,11 @@ var M, C = function() {
     _class_call_check(this, D);
 };
 !function(M) {
-    var A = function() {
+    var F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    M.A = A, M.F2 = function(x) {
-        return x.toString();
-    };
+    M.A = A, M.F2 = F2;
 }(M || (M = {})), new C(), new C(), new D(), new C(), new M.A();

crates/swc/tests/tsc-references/everyTypeWithAnnotationAndInvalidInitializer_es5.2.minified.js

@@ -7,19 +7,19 @@ var M, N, C = function() {
     _class_call_check(this, D);
 };
 !function(M) {
-    var A = function() {
+    var _$F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    M.A = A, M.F2 = function(x) {
-        return x.toString();
-    };
+    M.A = A, M.F2 = _$F2;
 }(M || (M = {})), function(N) {
-    var A = function() {
+    var _$F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    N.A = A, N.F2 = function(x) {
-        return x.toString();
-    };
+    N.A = A, N.F2 = _$F2;
 }(N || (N = {})), new D(), new D(), new C(), new C(), new N.A();

crates/swc/tests/tsc-references/everyTypeWithInitializer_es5.2.minified.js

@@ -7,11 +7,11 @@ var M, C = function() {
     _class_call_check(this, D);
 };
 !function(M) {
-    var A = function() {
+    var F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    M.A = A, M.F2 = function(x) {
-        return x.toString();
-    };
+    M.A = A, M.F2 = F2;
 }(M || (M = {})), new C(), new C(), new D(), new M.A(), M.F2;

crates/swc/tests/tsc-references/exportAssignmentMergedModule_es5.2.minified.js

@@ -1,11 +1,13 @@
 !function(Foo) {
-    Foo.a = function() {
+    var a = function() {
         return 5;
-    }, Foo.b = !0;
+    };
+    Foo.a = a, Foo.b = !0;
 }(Foo || (Foo = {})), function(Foo) {
-    Foo.c = function(a) {
+    var c = function(a) {
         return a;
-    }, (Foo.Test || (Foo.Test = {})).answer = 42;
+    };
+    Foo.c = c, (Foo.Test || (Foo.Test = {})).answer = 42;
 }(Foo || (Foo = {}));
 var Foo, foo = require("./foo_0");
 foo.a(), foo.b && (foo.Test.answer = foo.c(42)), module.exports = Foo;

crates/swc/tests/tsc-references/exportCodeGen_es5.2.minified.js

@@ -1,10 +1,14 @@
 var A, B, C, D, E, F;
 import _class_call_check from "@swc/helpers/src/_class_call_check.mjs";
-(A || (A = {})).x = 12, B || (B = {}), C || (C = {}), (D || (D = {})).yes = function() {
-    return !0;
-}, function(E) {
-    (Color = E.Color || (E.Color = {}))[Color.Red = 0] = "Red", E.fn = function() {};
-    var Color, C = function() {
+(A || (A = {})).x = 12, B || (B = {}), C || (C = {}), function(D) {
+    var yes = function() {
+        return !0;
+    };
+    D.yes = yes;
+}(D || (D = {})), function(E) {
+    var Color, fn = function() {};
+    (Color = E.Color || (E.Color = {}))[Color.Red = 0] = "Red", E.fn = fn;
+    var C = function() {
         "use strict";
         _class_call_check(this, C);
     };

crates/swc/tests/tsc-references/forStatementsMultipleInvalidDecl_es5.2.minified.js

@@ -17,13 +17,13 @@ var M, C = function() {
     _class_call_check(this, D);
 };
 for(!function(M) {
-    var A = function() {
+    var F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    M.A = A, M.F2 = function(x) {
-        return x.toString();
-    };
+    M.A = A, M.F2 = F2;
 }(M || (M = {}));;);
 for(;;);
 for(;;);

crates/swc/tests/tsc-references/forStatements_es5.2.minified.js

@@ -7,13 +7,13 @@ var M, C = function() {
     _class_call_check(this, D);
 };
 for(!function(M) {
-    var A = function() {
+    var F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    M.A = A, M.F2 = function(x) {
-        return x.toString();
-    };
+    M.A = A, M.F2 = F2;
 }(M || (M = {}));;);
 for(;;);
 for(;;);

crates/swc/tests/tsc-references/ifDoWhileStatements_es5.2.minified.js

@@ -17,21 +17,21 @@ var M, N, C = function() {
     _class_call_check(this, D);
 };
 for(!function(M) {
-    var A = function() {
+    var F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    M.A = A, M.F2 = function(x) {
-        return x.toString();
-    };
+    M.A = A, M.F2 = F2;
 }(M || (M = {})), function(N) {
-    var A = function() {
+    var F2 = function(x) {
+        return x.toString();
+    }, A = function() {
         "use strict";
         _class_call_check(this, A);
     };
-    N.A = A, N.F2 = function(x) {
-        return x.toString();
-    };
+    N.A = A, N.F2 = F2;
 }(N || (N = {}));;);
 for(;;);
 for(;;);

crates/swc/tests/tsc-references/importStatementsInterfaces_es5.2.minified.js

@@ -1,4 +1,7 @@
 var C, D, E;
-C || (C = {}), D || (D = {}), (E || (E = {})).xDist = function(x) {
-    return 0 - x.x;
-};
+C || (C = {}), D || (D = {}), function(E) {
+    var xDist = function(x) {
+        return 0 - x.x;
+    };
+    E.xDist = xDist;
+}(E || (E = {}));