test(es/helpers): Unify code path for testing external helpers (#5010)

.github/workflows/cargo.yml

@@ -376,12 +376,6 @@ jobs:
         run: |
           jest -v && mocha --version
 
-      - name: Configure helpers
-        shell: bash
-        run: |
-          (cd packages/swc-helpers && yarn && yarn build)
-          yarn add --dev ./packages/swc-helpers
-
       - name: Configure execution cache
         shell: bash
         run: |

crates/swc/tests/exec.rs

@@ -2,6 +2,7 @@ use std::{
     env,
     fs::{create_dir_all, rename},
     path::{Component, Path, PathBuf},
+    process::Command,
     sync::Arc,
 };
 
@@ -15,7 +16,7 @@ use swc_common::{errors::ColorConfig, SourceMap};
 use swc_ecma_ast::EsVersion;
 use swc_ecma_parser::{EsConfig, Syntax, TsConfig};
 use swc_ecma_testing::{exec_node_js, JsExecOptions};
-use testing::assert_eq;
+use testing::{assert_eq, find_executable};
 use tracing::{span, Level};
 
 trait IterExt<T>: Sized + IntoIterator<Item = T>
@@ -55,26 +56,42 @@ fn init_helpers() -> Arc<PathBuf> {
 
         let helper_dir = project_root.join("packages").join("swc-helpers");
 
-        if env::var("CI").as_deref() == Ok("1") {
-            return Arc::new(helper_dir);
-        }
-
+        let yarn = find_executable("yarn").expect("failed to find yarn");
+        let npm = find_executable("npm").expect("failed to find yarn");
         {
-            let mut cmd = std::process::Command::new("yarn");
-            cmd.current_dir(&helper_dir).arg("upgrade").arg("@swc/core");
+            let mut cmd = if cfg!(target_os = "windows") {
+                let mut c = Command::new("cmd");
+                c.arg("/C").arg(&yarn);
+                c
+            } else {
+                Command::new(&yarn)
+            };
+            cmd.current_dir(&helper_dir);
             let status = cmd.status().expect("failed to update swc core");
             assert!(status.success());
         }
 
         {
-            let mut cmd = std::process::Command::new("yarn");
+            let mut cmd = if cfg!(target_os = "windows") {
+                let mut c = Command::new("cmd");
+                c.arg("/C").arg(&yarn);
+                c
+            } else {
+                Command::new(&yarn)
+            };
             cmd.current_dir(&helper_dir).arg("build");
             let status = cmd.status().expect("failed to compile helper package");
             assert!(status.success());
         }
 
         {
-            let mut cmd = std::process::Command::new("npm");
+            let mut cmd = if cfg!(target_os = "windows") {
+                let mut c = Command::new("cmd");
+                c.arg("/C").arg(&npm);
+                c
+            } else {
+                Command::new(&npm)
+            };
             cmd.current_dir(&project_root)
                 .arg("install")
                 .arg("--no-save")

crates/swc/tests/fixture/deno/paths/issue-2724/output/src/index.ts

@@ -1,5 +1,5 @@
 "use strict";
-var _interop_require_wildcard = require("@swc/helpers/lib/_interop_require_wildcard.js").default;
+var _interop_require_wildcard = require("../../../../../../../../../packages/swc-helpers/src/_interop_require_wildcard.mjs").default;
 (async function() {
     const { displayA  } = await Promise.resolve().then(function() {
         return _interop_require_wildcard(require("../packages/a/src/index"));

crates/swc/tests/fixture/issues-2xxx/2050/output/index.ts

@@ -1,4 +1,4 @@
 "use strict";
-var _interop_require_default = require("@swc/helpers/lib/_interop_require_default.js").default;
+var _interop_require_default = require("../../../../../../../packages/swc-helpers/src/_interop_require_default.mjs").default;
 var _a = _interop_require_default(require("./subfolder/A"));
 console.log(_a.default);

crates/swc/tests/fixture/issues-3xxx/3272/1/output/index.js

@@ -1,4 +1,4 @@
 "use strict";
-var _interop_require_default = require("@swc/helpers/lib/_interop_require_default.js").default;
+var _interop_require_default = require("../../../../../../../../packages/swc-helpers/src/_interop_require_default.mjs").default;
 var _handlebars = _interop_require_default(require("handlebars"));
 console.log(_handlebars.default);

crates/swc_html_minifier/tests/fixture.rs

@@ -124,7 +124,7 @@ fn test_minify_document_fragment(input: PathBuf) {
                 context_element_tag_name = tag_name;
             }
         } else {
-            context_element_tag_name = &context_element;
+            context_element_tag_name = context_element;
         }
 
         let context_element = Element {