Skip to content

Commit

Permalink
fix(es): Fix typo in a warning (#7740)
Browse files Browse the repository at this point in the history
  • Loading branch information
BiscuiTech committed Aug 2, 2023
1 parent 6d7e13a commit 22e06cc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/swc/src/config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ impl Options {
let top_level_mark = self.top_level_mark.unwrap_or_else(Mark::new);

if target.is_some() && cfg.env.is_some() {
bail!("`jsc.env` and `jsc.target` cannot be used together");
bail!("`env` and `jsc.target` cannot be used together");
}

let es_version = target.unwrap_or_default();
Expand Down

1 comment on commit 22e06cc

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 22e06cc Previous: 216c4f1 Ratio
es/full/bugs-1 287222 ns/iter (± 3567) 285323 ns/iter (± 8926) 1.01
es/full/minify/libraries/antd 1314129630 ns/iter (± 22508613) 1345345502 ns/iter (± 13073537) 0.98
es/full/minify/libraries/d3 272770173 ns/iter (± 3559126) 279836770 ns/iter (± 3306143) 0.97
es/full/minify/libraries/echarts 1042109653 ns/iter (± 6215462) 1082253802 ns/iter (± 13250686) 0.96
es/full/minify/libraries/jquery 84477012 ns/iter (± 342822) 85119746 ns/iter (± 214967) 0.99
es/full/minify/libraries/lodash 97767160 ns/iter (± 466866) 98357187 ns/iter (± 268157) 0.99
es/full/minify/libraries/moment 49821667 ns/iter (± 320496) 49887581 ns/iter (± 285730) 1.00
es/full/minify/libraries/react 17881325 ns/iter (± 67695) 17985235 ns/iter (± 65861) 0.99
es/full/minify/libraries/terser 216120748 ns/iter (± 1087362) 223490105 ns/iter (± 2949257) 0.97
es/full/minify/libraries/three 378999655 ns/iter (± 1338530) 389768812 ns/iter (± 2456089) 0.97
es/full/minify/libraries/typescript 2630141350 ns/iter (± 11368745) 2710436680 ns/iter (± 8819123) 0.97
es/full/minify/libraries/victory 551922028 ns/iter (± 1817594) 573587476 ns/iter (± 7543377) 0.96
es/full/minify/libraries/vue 119347760 ns/iter (± 685702) 120710772 ns/iter (± 495068) 0.99
es/full/codegen/es3 34982 ns/iter (± 105) 34946 ns/iter (± 79) 1.00
es/full/codegen/es5 35021 ns/iter (± 69) 35011 ns/iter (± 65) 1.00
es/full/codegen/es2015 35008 ns/iter (± 62) 34961 ns/iter (± 52) 1.00
es/full/codegen/es2016 35005 ns/iter (± 90) 34987 ns/iter (± 36) 1.00
es/full/codegen/es2017 34973 ns/iter (± 28) 35012 ns/iter (± 320) 1.00
es/full/codegen/es2018 34985 ns/iter (± 66) 35005 ns/iter (± 83) 1.00
es/full/codegen/es2019 35109 ns/iter (± 79) 34860 ns/iter (± 45) 1.01
es/full/codegen/es2020 35014 ns/iter (± 61) 34930 ns/iter (± 93) 1.00
es/full/all/es3 173173467 ns/iter (± 866458) 172170666 ns/iter (± 1105700) 1.01
es/full/all/es5 165205241 ns/iter (± 455733) 165440958 ns/iter (± 1223992) 1.00
es/full/all/es2015 124508877 ns/iter (± 684613) 124056439 ns/iter (± 529293) 1.00
es/full/all/es2016 123871536 ns/iter (± 2141733) 123345649 ns/iter (± 425090) 1.00
es/full/all/es2017 123036191 ns/iter (± 698180) 121861209 ns/iter (± 912471) 1.01
es/full/all/es2018 121126703 ns/iter (± 820428) 120064167 ns/iter (± 501306) 1.01
es/full/all/es2019 120628504 ns/iter (± 514047) 119399438 ns/iter (± 539254) 1.01
es/full/all/es2020 116484565 ns/iter (± 973292) 115320778 ns/iter (± 488562) 1.01
es/full/parser 536436 ns/iter (± 5827) 523669 ns/iter (± 6045) 1.02
es/full/base/fixer 20048 ns/iter (± 686) 22015 ns/iter (± 78) 0.91
es/full/base/resolver_and_hygiene 84623 ns/iter (± 170) 82227 ns/iter (± 135) 1.03
serialization of serde 300 ns/iter (± 0) 296 ns/iter (± 2) 1.01
css/minify/libraries/bootstrap 28144046 ns/iter (± 55844) 28546106 ns/iter (± 83667) 0.99
css/visitor/compare/clone 1632364 ns/iter (± 5457) 1649889 ns/iter (± 16549) 0.99
css/visitor/compare/visit_mut_span 1778798 ns/iter (± 3224) 1787844 ns/iter (± 3018) 0.99
css/visitor/compare/visit_mut_span_panic 1831422 ns/iter (± 3647) 1847351 ns/iter (± 2340) 0.99
css/visitor/compare/fold_span 2574067 ns/iter (± 275480) 2586339 ns/iter (± 6907) 1.00
css/visitor/compare/fold_span_panic 2771019 ns/iter (± 94013) 2782250 ns/iter (± 12010) 1.00
css/lexer/bootstrap_5_1_3 4367030 ns/iter (± 48159) 4488363 ns/iter (± 4765) 0.97
css/lexer/foundation_6_7_4 3635499 ns/iter (± 44375) 3793281 ns/iter (± 3873) 0.96
css/lexer/tailwind_3_1_1 702180 ns/iter (± 7913) 723053 ns/iter (± 768) 0.97
css/parser/bootstrap_5_1_3 18934685 ns/iter (± 63767) 18926846 ns/iter (± 58611) 1.00
css/parser/foundation_6_7_4 15343601 ns/iter (± 55286) 15116412 ns/iter (± 102458) 1.02
css/parser/tailwind_3_1_1 3018476 ns/iter (± 6469) 2974015 ns/iter (± 7489) 1.01
es/codegen/colors 732018 ns/iter (± 399084) 731847 ns/iter (± 400554) 1.00
es/codegen/large 3129665 ns/iter (± 1652349) 3122301 ns/iter (± 1675582) 1.00
es/codegen/with-parser/colors 44088 ns/iter (± 550) 44631 ns/iter (± 507) 0.99
es/codegen/with-parser/large 484766 ns/iter (± 1282) 485462 ns/iter (± 831) 1.00
es/minify/libraries/antd 1130948936 ns/iter (± 13167993) 1191116151 ns/iter (± 18056157) 0.95
es/minify/libraries/d3 239754700 ns/iter (± 380410) 245343631 ns/iter (± 2353045) 0.98
es/minify/libraries/echarts 892233927 ns/iter (± 1796902) 937374010 ns/iter (± 8420602) 0.95
es/minify/libraries/jquery 73927147 ns/iter (± 176520) 74371802 ns/iter (± 305525) 0.99
es/minify/libraries/lodash 88055692 ns/iter (± 184871) 88631755 ns/iter (± 416656) 0.99
es/minify/libraries/moment 43645353 ns/iter (± 29925) 43999702 ns/iter (± 135705) 0.99
es/minify/libraries/react 16005017 ns/iter (± 38703) 16093015 ns/iter (± 23826) 0.99
es/minify/libraries/terser 186855394 ns/iter (± 460245) 190056409 ns/iter (± 1041782) 0.98
es/minify/libraries/three 318300459 ns/iter (± 1146907) 327130473 ns/iter (± 1540783) 0.97
es/minify/libraries/typescript 2242341547 ns/iter (± 9984106) 2344918033 ns/iter (± 23460639) 0.96
es/minify/libraries/victory 459672987 ns/iter (± 1045520) 485394744 ns/iter (± 6026914) 0.95
es/minify/libraries/vue 107143950 ns/iter (± 177928) 108395950 ns/iter (± 258386) 0.99
es/visitor/compare/clone 1944936 ns/iter (± 5254) 1976321 ns/iter (± 6120) 0.98
es/visitor/compare/visit_mut_span 2283471 ns/iter (± 4195) 2310914 ns/iter (± 4195) 0.99
es/visitor/compare/visit_mut_span_panic 2311970 ns/iter (± 2309) 2348947 ns/iter (± 4900) 0.98
es/visitor/compare/fold_span 3341623 ns/iter (± 5385) 3391894 ns/iter (± 6156) 0.99
es/visitor/compare/fold_span_panic 3464448 ns/iter (± 5567) 3498607 ns/iter (± 5840) 0.99
es/lexer/colors 12664 ns/iter (± 32) 12760 ns/iter (± 14) 0.99
es/lexer/angular 6046190 ns/iter (± 1384) 6211700 ns/iter (± 3376) 0.97
es/lexer/backbone 792807 ns/iter (± 482) 816856 ns/iter (± 1517) 0.97
es/lexer/jquery 4430271 ns/iter (± 4406) 4555145 ns/iter (± 9057) 0.97
es/lexer/jquery mobile 6827128 ns/iter (± 11683) 6998656 ns/iter (± 5273) 0.98
es/lexer/mootools 3513026 ns/iter (± 872) 3615685 ns/iter (± 3547) 0.97
es/lexer/underscore 656996 ns/iter (± 215) 682179 ns/iter (± 1695) 0.96
es/lexer/three 20739772 ns/iter (± 46219) 21486662 ns/iter (± 21752) 0.97
es/lexer/yui 3817766 ns/iter (± 17047) 3912463 ns/iter (± 3581) 0.98
es/parser/colors 26215 ns/iter (± 121) 26542 ns/iter (± 48) 0.99
es/parser/angular 13238953 ns/iter (± 82748) 13487725 ns/iter (± 111919) 0.98
es/parser/backbone 1963984 ns/iter (± 9174) 1988846 ns/iter (± 10374) 0.99
es/parser/jquery 10683451 ns/iter (± 28679) 10823667 ns/iter (± 40739) 0.99
es/parser/jquery mobile 16347159 ns/iter (± 32933) 16612905 ns/iter (± 144448) 0.98
es/parser/mootools 8227419 ns/iter (± 14284) 8345538 ns/iter (± 16482) 0.99
es/parser/underscore 1693012 ns/iter (± 8892) 1719607 ns/iter (± 10549) 0.98
es/parser/three 45661698 ns/iter (± 128963) 47219188 ns/iter (± 400137) 0.97
es/parser/yui 8120194 ns/iter (± 20143) 8219030 ns/iter (± 36216) 0.99
es/preset-env/usage/builtin_type 137025 ns/iter (± 32692) 137484 ns/iter (± 32277) 1.00
es/preset-env/usage/property 16619 ns/iter (± 35) 16705 ns/iter (± 57) 0.99
es/resolver/typescript 86606222 ns/iter (± 1139783) 89668794 ns/iter (± 1242354) 0.97
es/fixer/typescript 61465698 ns/iter (± 478143) 63980387 ns/iter (± 505023) 0.96
es/hygiene/typescript 128561625 ns/iter (± 484089) 131714700 ns/iter (± 522349) 0.98
es/resolver_with_hygiene/typescript 238083320 ns/iter (± 834032) 242682230 ns/iter (± 1308283) 0.98
es/visitor/base-perf/module_clone 60446 ns/iter (± 199) 60237 ns/iter (± 290) 1.00
es/visitor/base-perf/fold_empty 63242 ns/iter (± 452) 64424 ns/iter (± 270) 0.98
es/visitor/base-perf/fold_noop_impl_all 63508 ns/iter (± 601) 64080 ns/iter (± 382) 0.99
es/visitor/base-perf/fold_noop_impl_vec 63999 ns/iter (± 459) 64204 ns/iter (± 431) 1.00
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 41 ns/iter (± 0) 39 ns/iter (± 0) 1.05
es/visitor/base-perf/boxing_boxed 109 ns/iter (± 0) 108 ns/iter (± 0) 1.01
es/visitor/base-perf/boxing_unboxed 79 ns/iter (± 0) 77 ns/iter (± 0) 1.03
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2528 ns/iter (± 12) 2532 ns/iter (± 13) 1.00
es/base/parallel/resolver/typescript 4543623096 ns/iter (± 315857983) 4339315722 ns/iter (± 286219435) 1.05
es/base/parallel/hygiene/typescript 1446424321 ns/iter (± 17813096) 1442736553 ns/iter (± 9731496) 1.00
misc/visitors/time-complexity/time 5 140 ns/iter (± 3) 135 ns/iter (± 1) 1.04
misc/visitors/time-complexity/time 10 388 ns/iter (± 1) 399 ns/iter (± 4) 0.97
misc/visitors/time-complexity/time 15 728 ns/iter (± 2) 606 ns/iter (± 42) 1.20
misc/visitors/time-complexity/time 20 906 ns/iter (± 2) 1045 ns/iter (± 5) 0.87
misc/visitors/time-complexity/time 40 4132 ns/iter (± 29) 3564 ns/iter (± 6) 1.16
misc/visitors/time-complexity/time 60 7225 ns/iter (± 19) 7242 ns/iter (± 16) 1.00
es/full-target/es2016 237732 ns/iter (± 847) 241241 ns/iter (± 579) 0.99
es/full-target/es2017 227894 ns/iter (± 534) 226087 ns/iter (± 809) 1.01
es/full-target/es2018 219279 ns/iter (± 1255) 214142 ns/iter (± 1363) 1.02
es2020_nullish_coalescing 72191 ns/iter (± 334) 71969 ns/iter (± 321) 1.00
es2020_optional_chaining 83037 ns/iter (± 381) 82097 ns/iter (± 243) 1.01
es2022_class_properties 122770 ns/iter (± 991) 123153 ns/iter (± 440) 1.00
es2018_object_rest_spread 77465 ns/iter (± 204) 76959 ns/iter (± 211) 1.01
es2019_optional_catch_binding 67014 ns/iter (± 370) 66919 ns/iter (± 206) 1.00
es2017_async_to_generator 66416 ns/iter (± 167) 65519 ns/iter (± 256) 1.01
es2016_exponentiation 70460 ns/iter (± 207) 70390 ns/iter (± 146) 1.00
es2015_arrow 73950 ns/iter (± 400) 73947 ns/iter (± 405) 1.00
es2015_block_scoped_fn 71191 ns/iter (± 212) 71767 ns/iter (± 437) 0.99
es2015_block_scoping 126746 ns/iter (± 567) 123162 ns/iter (± 545) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.