Skip to content

Commit

Permalink
feat(es/minifier): Support __NO_SIDE_EFFECTS__ (#7532)
Browse files Browse the repository at this point in the history 
**Related issue:**

 - Closes #7525.
  • Loading branch information
@kdy1
kdy1 committed Jun 21, 2023
1 parent 5b01fa9 commit 3ad07a7
Show file tree
Hide file tree
Showing 5 changed files with 202 additions and 254 deletions.

1 comment on commit 3ad07a7

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 3ad07a7 Previous: c8d9338 Ratio
es/full/bugs-1 363307 ns/iter (± 15828) 388420 ns/iter (± 11570) 0.94
es/full/minify/libraries/antd 2033737474 ns/iter (± 21817910) 1862437508 ns/iter (± 58873160) 1.09
es/full/minify/libraries/d3 407017338 ns/iter (± 6590492) 383375152 ns/iter (± 12391146) 1.06
es/full/minify/libraries/echarts 1553144153 ns/iter (± 24705329) 1443994832 ns/iter (± 20448662) 1.08
es/full/minify/libraries/jquery 116163498 ns/iter (± 1647370) 110334632 ns/iter (± 1834330) 1.05
es/full/minify/libraries/lodash 137201258 ns/iter (± 1145390) 136029707 ns/iter (± 1870378) 1.01
es/full/minify/libraries/moment 66217452 ns/iter (± 996318) 65747610 ns/iter (± 758541) 1.01
es/full/minify/libraries/react 23421372 ns/iter (± 306155) 23267802 ns/iter (± 301096) 1.01
es/full/minify/libraries/terser 315324427 ns/iter (± 7008851) 296544916 ns/iter (± 6630874) 1.06
es/full/minify/libraries/three 589274519 ns/iter (± 16400044) 533830942 ns/iter (± 9106342) 1.10
es/full/minify/libraries/typescript 3851443041 ns/iter (± 31550278) 3483195274 ns/iter (± 89942348) 1.11
es/full/minify/libraries/victory 858814007 ns/iter (± 10088420) 773720369 ns/iter (± 19091411) 1.11
es/full/minify/libraries/vue 169117146 ns/iter (± 2949193) 162166164 ns/iter (± 3156217) 1.04
es/full/codegen/es3 42227 ns/iter (± 123) 42380 ns/iter (± 198) 1.00
es/full/codegen/es5 42309 ns/iter (± 77) 42425 ns/iter (± 46) 1.00
es/full/codegen/es2015 42301 ns/iter (± 69) 42455 ns/iter (± 83) 1.00
es/full/codegen/es2016 42303 ns/iter (± 117) 42476 ns/iter (± 67) 1.00
es/full/codegen/es2017 42268 ns/iter (± 68) 42447 ns/iter (± 91) 1.00
es/full/codegen/es2018 42335 ns/iter (± 69) 42434 ns/iter (± 59) 1.00
es/full/codegen/es2019 42309 ns/iter (± 98) 42497 ns/iter (± 67) 1.00
es/full/codegen/es2020 42279 ns/iter (± 96) 42446 ns/iter (± 54) 1.00
es/full/all/es3 209826793 ns/iter (± 3449976) 216018122 ns/iter (± 3087288) 0.97
es/full/all/es5 197223117 ns/iter (± 2487848) 204772152 ns/iter (± 3724941) 0.96
es/full/all/es2015 155832985 ns/iter (± 3125869) 159865228 ns/iter (± 1193188) 0.97
es/full/all/es2016 153985924 ns/iter (± 3193490) 160330306 ns/iter (± 4452781) 0.96
es/full/all/es2017 154508240 ns/iter (± 1816511) 157176418 ns/iter (± 3886333) 0.98
es/full/all/es2018 151450040 ns/iter (± 1677135) 153577890 ns/iter (± 2924394) 0.99
es/full/all/es2019 149902684 ns/iter (± 2616616) 153593538 ns/iter (± 2286510) 0.98
es/full/all/es2020 146416855 ns/iter (± 1603561) 149684372 ns/iter (± 2806409) 0.98
es/full/parser 606714 ns/iter (± 13948) 602991 ns/iter (± 9727) 1.01
es/full/base/fixer 24606 ns/iter (± 66) 24931 ns/iter (± 74) 0.99
es/full/base/resolver_and_hygiene 105616 ns/iter (± 76) 107364 ns/iter (± 119) 0.98
serialization of serde 257 ns/iter (± 0) 257 ns/iter (± 0) 1
css/minify/libraries/bootstrap 36681073 ns/iter (± 116155) 36388502 ns/iter (± 263726) 1.01
css/visitor/compare/clone 2353156 ns/iter (± 10249) 2371993 ns/iter (± 26425) 0.99
css/visitor/compare/visit_mut_span 2526159 ns/iter (± 31759) 2570640 ns/iter (± 4557) 0.98
css/visitor/compare/visit_mut_span_panic 2631497 ns/iter (± 14991) 2609519 ns/iter (± 4777) 1.01
css/visitor/compare/fold_span 3337664 ns/iter (± 9496) 3335888 ns/iter (± 8644) 1.00
css/visitor/compare/fold_span_panic 3466503 ns/iter (± 14188) 3528632 ns/iter (± 15998) 0.98
css/lexer/bootstrap_5_1_3 5572779 ns/iter (± 6786) 5540713 ns/iter (± 2831) 1.01
css/lexer/foundation_6_7_4 4708392 ns/iter (± 4602) 4671717 ns/iter (± 1089) 1.01
css/lexer/tailwind_3_1_1 895924 ns/iter (± 964) 892782 ns/iter (± 308) 1.00
css/parser/bootstrap_5_1_3 24131686 ns/iter (± 205964) 23799921 ns/iter (± 101001) 1.01
css/parser/foundation_6_7_4 19215740 ns/iter (± 203674) 19023930 ns/iter (± 27716) 1.01
css/parser/tailwind_3_1_1 3676258 ns/iter (± 4654) 3671547 ns/iter (± 3040) 1.00
es/codegen/colors 728789 ns/iter (± 398885) 729380 ns/iter (± 398624) 1.00
es/codegen/large 2867013 ns/iter (± 1499071) 3199582 ns/iter (± 1686581) 0.90
es/codegen/with-parser/colors 58288 ns/iter (± 443) 57077 ns/iter (± 463) 1.02
es/codegen/with-parser/large 587991 ns/iter (± 1625) 581825 ns/iter (± 1470) 1.01
es/minify/libraries/antd 1755191469 ns/iter (± 36879485) 1593582391 ns/iter (± 27201885) 1.10
es/minify/libraries/d3 350915334 ns/iter (± 7892986) 334367904 ns/iter (± 5505526) 1.05
es/minify/libraries/echarts 1369992560 ns/iter (± 27942588) 1238559778 ns/iter (± 13420588) 1.11
es/minify/libraries/jquery 100278873 ns/iter (± 2435398) 97089534 ns/iter (± 938137) 1.03
es/minify/libraries/lodash 124127814 ns/iter (± 1987786) 121337147 ns/iter (± 2212557) 1.02
es/minify/libraries/moment 57969751 ns/iter (± 589259) 56719481 ns/iter (± 586905) 1.02
es/minify/libraries/react 20782470 ns/iter (± 231021) 20827286 ns/iter (± 321446) 1.00
es/minify/libraries/terser 270113621 ns/iter (± 8366905) 249226886 ns/iter (± 4468771) 1.08
es/minify/libraries/three 491308637 ns/iter (± 12987565) 440194200 ns/iter (± 6912194) 1.12
es/minify/libraries/typescript 3249052835 ns/iter (± 22304878) 3008132336 ns/iter (± 27989946) 1.08
es/minify/libraries/victory 722338640 ns/iter (± 22266992) 680219631 ns/iter (± 8685722) 1.06
es/minify/libraries/vue 149248286 ns/iter (± 3980258) 145653157 ns/iter (± 10075445) 1.02
es/visitor/compare/clone 2434437 ns/iter (± 12697) 2426937 ns/iter (± 12972) 1.00
es/visitor/compare/visit_mut_span 2792758 ns/iter (± 6345) 2785037 ns/iter (± 3541) 1.00
es/visitor/compare/visit_mut_span_panic 2847026 ns/iter (± 11266) 2848614 ns/iter (± 5923) 1.00
es/visitor/compare/fold_span 3928243 ns/iter (± 24553) 3958975 ns/iter (± 11519) 0.99
es/visitor/compare/fold_span_panic 4096554 ns/iter (± 18368) 4086838 ns/iter (± 30383) 1.00
es/lexer/colors 15126 ns/iter (± 99) 15228 ns/iter (± 13) 0.99
es/lexer/angular 7243090 ns/iter (± 3120) 7255819 ns/iter (± 2553) 1.00
es/lexer/backbone 872440 ns/iter (± 1640) 873571 ns/iter (± 1628) 1.00
es/lexer/jquery 4890990 ns/iter (± 6659) 4888360 ns/iter (± 3489) 1.00
es/lexer/jquery mobile 7553022 ns/iter (± 45207) 7550329 ns/iter (± 2747) 1.00
es/lexer/mootools 3799050 ns/iter (± 4274) 3809017 ns/iter (± 1839) 1.00
es/lexer/underscore 720093 ns/iter (± 1040) 720834 ns/iter (± 335) 1.00
es/lexer/three 22662936 ns/iter (± 42941) 22704904 ns/iter (± 21101) 1.00
es/lexer/yui 4386111 ns/iter (± 8805) 4394073 ns/iter (± 1930) 1.00
es/parser/colors 33057 ns/iter (± 372) 33748 ns/iter (± 64) 0.98
es/parser/angular 17219407 ns/iter (± 132119) 17102031 ns/iter (± 775032) 1.01
es/parser/backbone 2411153 ns/iter (± 10143) 2455732 ns/iter (± 12186) 0.98
es/parser/jquery 13439549 ns/iter (± 145677) 13308538 ns/iter (± 91176) 1.01
es/parser/jquery mobile 21042265 ns/iter (± 439232) 20704445 ns/iter (± 203618) 1.02
es/parser/mootools 10124920 ns/iter (± 52985) 10194054 ns/iter (± 197079) 0.99
es/parser/underscore 2060940 ns/iter (± 13666) 2085257 ns/iter (± 7540) 0.99
es/parser/three 62548312 ns/iter (± 530489) 61158976 ns/iter (± 1817655) 1.02
es/parser/yui 10197052 ns/iter (± 139037) 10416984 ns/iter (± 424059) 0.98
es/preset-env/usage/builtin_type 152330 ns/iter (± 33307) 150763 ns/iter (± 32879) 1.01
es/preset-env/usage/property 29572 ns/iter (± 119) 29308 ns/iter (± 110) 1.01
es/resolver/typescript 129287392 ns/iter (± 3068472) 120977669 ns/iter (± 4887854) 1.07
es/fixer/typescript 91947765 ns/iter (± 979929) 82802864 ns/iter (± 1882065) 1.11
es/hygiene/typescript 207036873 ns/iter (± 3598059) 188964091 ns/iter (± 2892750) 1.10
es/resolver_with_hygiene/typescript 421814189 ns/iter (± 6468972) 395548865 ns/iter (± 2894196) 1.07
es/visitor/base-perf/module_clone 85660 ns/iter (± 429) 85586 ns/iter (± 404) 1.00
es/visitor/base-perf/fold_empty 94884 ns/iter (± 330) 94862 ns/iter (± 405) 1.00
es/visitor/base-perf/fold_noop_impl_all 94366 ns/iter (± 588) 95710 ns/iter (± 688) 0.99
es/visitor/base-perf/fold_noop_impl_vec 95381 ns/iter (± 508) 95092 ns/iter (± 362) 1.00
es/visitor/base-perf/boxing_boxed_clone 62 ns/iter (± 0) 62 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 45 ns/iter (± 0) 46 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_boxed 109 ns/iter (± 0) 112 ns/iter (± 0) 0.97
es/visitor/base-perf/boxing_unboxed 84 ns/iter (± 0) 83 ns/iter (± 0) 1.01
es/visitor/base-perf/visit_contains_this 3416 ns/iter (± 67) 3502 ns/iter (± 65) 0.98
es/base/parallel/resolver/typescript 7060599059 ns/iter (± 493254565) 6931106586 ns/iter (± 381718995) 1.02
es/base/parallel/hygiene/typescript 2376916466 ns/iter (± 21341982) 2179691840 ns/iter (± 20760991) 1.09
misc/visitors/time-complexity/time 5 104 ns/iter (± 0) 103 ns/iter (± 0) 1.01
misc/visitors/time-complexity/time 10 351 ns/iter (± 1) 354 ns/iter (± 3) 0.99
misc/visitors/time-complexity/time 15 681 ns/iter (± 0) 686 ns/iter (± 3) 0.99
misc/visitors/time-complexity/time 20 1244 ns/iter (± 1) 1247 ns/iter (± 3) 1.00
misc/visitors/time-complexity/time 40 6281 ns/iter (± 4) 6323 ns/iter (± 31) 0.99
misc/visitors/time-complexity/time 60 15778 ns/iter (± 12) 15635 ns/iter (± 123) 1.01
es/full-target/es2016 270344 ns/iter (± 556) 270241 ns/iter (± 1170) 1.00
es/full-target/es2017 260163 ns/iter (± 588) 258870 ns/iter (± 1737) 1.00
es/full-target/es2018 248917 ns/iter (± 555) 248170 ns/iter (± 1438) 1.00
es2020_nullish_coalescing 98412 ns/iter (± 525) 97236 ns/iter (± 593) 1.01
es2020_optional_chaining 115443 ns/iter (± 382) 114364 ns/iter (± 448) 1.01
es2022_class_properties 157520 ns/iter (± 217) 155016 ns/iter (± 550) 1.02
es2018_object_rest_spread 100137 ns/iter (± 366) 99173 ns/iter (± 378) 1.01
es2019_optional_catch_binding 88555 ns/iter (± 322) 87931 ns/iter (± 424) 1.01
es2017_async_to_generator 89077 ns/iter (± 217) 88848 ns/iter (± 556) 1.00
es2016_exponentiation 95768 ns/iter (± 275) 95194 ns/iter (± 552) 1.01
es2015_arrow 99195 ns/iter (± 244) 98026 ns/iter (± 675) 1.01
es2015_block_scoped_fn 96734 ns/iter (± 238) 95994 ns/iter (± 266) 1.01
es2015_block_scoping 185056 ns/iter (± 208) 183641 ns/iter (± 827) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.