Skip to content

Commit

Permalink
perf(es/compat): Improve time complexity of class_properties (#7786)
Browse files Browse the repository at this point in the history 
**Related issue:**

 - Closes #7780
  • Loading branch information
@kdy1
kdy1 committed Aug 9, 2023
1 parent fd2d674 commit 76c6258
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion crates/swc_ecma_transforms_compat/src/es2022/class_properties/private_field.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ impl<'a> VisitMut for PrivateAccessVisitor<'a> {
right: right.take(),
});

e.visit_mut_children_with(self);
return;
}
};
Expand Down

1 comment on commit 76c6258

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 76c6258 Previous: ab39f1c Ratio
es/full/bugs-1 302433 ns/iter (± 9145) 286794 ns/iter (± 3633) 1.05
es/full/minify/libraries/antd 1399873141 ns/iter (± 26662433) 1298189324 ns/iter (± 13011638) 1.08
es/full/minify/libraries/d3 291312214 ns/iter (± 6362275) 275720328 ns/iter (± 2867271) 1.06
es/full/minify/libraries/echarts 1121744008 ns/iter (± 16769582) 1041604870 ns/iter (± 7919599) 1.08
es/full/minify/libraries/jquery 87516659 ns/iter (± 1008232) 84910444 ns/iter (± 92577) 1.03
es/full/minify/libraries/lodash 101006557 ns/iter (± 924613) 98278004 ns/iter (± 270681) 1.03
es/full/minify/libraries/moment 51160206 ns/iter (± 329732) 49851508 ns/iter (± 370297) 1.03
es/full/minify/libraries/react 18333372 ns/iter (± 157213) 18067054 ns/iter (± 33560) 1.01
es/full/minify/libraries/terser 227732829 ns/iter (± 2162244) 217363535 ns/iter (± 415949) 1.05
es/full/minify/libraries/three 404394957 ns/iter (± 5900297) 382321799 ns/iter (± 1693638) 1.06
es/full/minify/libraries/typescript 2775790289 ns/iter (± 18303733) 2654891649 ns/iter (± 12866069) 1.05
es/full/minify/libraries/victory 605374987 ns/iter (± 9628579) 555142479 ns/iter (± 1962492) 1.09
es/full/minify/libraries/vue 124300327 ns/iter (± 823100) 120331600 ns/iter (± 290509) 1.03
es/full/codegen/es3 36047 ns/iter (± 105) 35429 ns/iter (± 525) 1.02
es/full/codegen/es5 36025 ns/iter (± 87) 35163 ns/iter (± 76) 1.02
es/full/codegen/es2015 36046 ns/iter (± 61) 35069 ns/iter (± 112) 1.03
es/full/codegen/es2016 36097 ns/iter (± 64) 35002 ns/iter (± 165) 1.03
es/full/codegen/es2017 36010 ns/iter (± 53) 35067 ns/iter (± 46) 1.03
es/full/codegen/es2018 36055 ns/iter (± 97) 35107 ns/iter (± 70) 1.03
es/full/codegen/es2019 36076 ns/iter (± 119) 35117 ns/iter (± 93) 1.03
es/full/codegen/es2020 36057 ns/iter (± 47) 35079 ns/iter (± 60) 1.03
es/full/all/es3 174093278 ns/iter (± 2233691) 171061426 ns/iter (± 652835) 1.02
es/full/all/es5 164980742 ns/iter (± 945991) 163586312 ns/iter (± 1002746) 1.01
es/full/all/es2015 125059279 ns/iter (± 657863) 123771266 ns/iter (± 538832) 1.01
es/full/all/es2016 124827361 ns/iter (± 1266109) 122401576 ns/iter (± 516863) 1.02
es/full/all/es2017 123924999 ns/iter (± 647447) 122077248 ns/iter (± 1158475) 1.02
es/full/all/es2018 121269638 ns/iter (± 783413) 120143042 ns/iter (± 708535) 1.01
es/full/all/es2019 121101010 ns/iter (± 745090) 119202567 ns/iter (± 360171) 1.02
es/full/all/es2020 116165562 ns/iter (± 663064) 114944648 ns/iter (± 568754) 1.01
es/full/parser 538747 ns/iter (± 4466) 528269 ns/iter (± 5526) 1.02
es/full/base/fixer 17702 ns/iter (± 180) 18486 ns/iter (± 51) 0.96
es/full/base/resolver_and_hygiene 82471 ns/iter (± 234) 80328 ns/iter (± 170) 1.03
serialization of serde 297 ns/iter (± 1) 298 ns/iter (± 0) 1.00
css/minify/libraries/bootstrap 29117016 ns/iter (± 308612) 28185302 ns/iter (± 59442) 1.03
css/visitor/compare/clone 1650069 ns/iter (± 9312) 1626839 ns/iter (± 5372) 1.01
css/visitor/compare/visit_mut_span 1776326 ns/iter (± 13315) 1761517 ns/iter (± 4942) 1.01
css/visitor/compare/visit_mut_span_panic 1860611 ns/iter (± 16797) 1832947 ns/iter (± 2749) 1.02
css/visitor/compare/fold_span 2588210 ns/iter (± 15179) 2582034 ns/iter (± 14400) 1.00
css/visitor/compare/fold_span_panic 2794161 ns/iter (± 20725) 2758340 ns/iter (± 11455) 1.01
css/lexer/bootstrap_5_1_3 4690502 ns/iter (± 2847) 4454485 ns/iter (± 3689) 1.05
css/lexer/foundation_6_7_4 3952392 ns/iter (± 3716) 3746386 ns/iter (± 1607) 1.05
css/lexer/tailwind_3_1_1 747301 ns/iter (± 3480) 711237 ns/iter (± 1900) 1.05
css/parser/bootstrap_5_1_3 19152111 ns/iter (± 162428) 19410330 ns/iter (± 44810) 0.99
css/parser/foundation_6_7_4 15358295 ns/iter (± 85763) 15575381 ns/iter (± 42073) 0.99
css/parser/tailwind_3_1_1 2943144 ns/iter (± 3661) 3003729 ns/iter (± 3227) 0.98
es/codegen/colors 738049 ns/iter (± 404528) 735934 ns/iter (± 402262) 1.00
es/codegen/large 2900987 ns/iter (± 1547003) 2883592 ns/iter (± 1524055) 1.01
es/codegen/with-parser/colors 45372 ns/iter (± 520) 44376 ns/iter (± 478) 1.02
es/codegen/with-parser/large 486708 ns/iter (± 2029) 480434 ns/iter (± 1507) 1.01
es/minify/libraries/antd 1241382474 ns/iter (± 18047835) 1126393489 ns/iter (± 10617312) 1.10
es/minify/libraries/d3 254413302 ns/iter (± 5978669) 241758717 ns/iter (± 482888) 1.05
es/minify/libraries/echarts 986100649 ns/iter (± 16946437) 898595253 ns/iter (± 3824781) 1.10
es/minify/libraries/jquery 76071910 ns/iter (± 549340) 74854508 ns/iter (± 215982) 1.02
es/minify/libraries/lodash 91121971 ns/iter (± 963681) 89077938 ns/iter (± 129105) 1.02
es/minify/libraries/moment 44653739 ns/iter (± 297601) 43964552 ns/iter (± 81184) 1.02
es/minify/libraries/react 16383704 ns/iter (± 136079) 16202302 ns/iter (± 29801) 1.01
es/minify/libraries/terser 198162204 ns/iter (± 3780905) 188794652 ns/iter (± 597944) 1.05
es/minify/libraries/three 347940277 ns/iter (± 7834524) 323468521 ns/iter (± 463685) 1.08
es/minify/libraries/typescript 2426803576 ns/iter (± 19302326) 2286819737 ns/iter (± 5747569) 1.06
es/minify/libraries/victory 515399876 ns/iter (± 19246828) 475845467 ns/iter (± 1098550) 1.08
es/minify/libraries/vue 111230463 ns/iter (± 1349909) 108132918 ns/iter (± 400849) 1.03
es/visitor/compare/clone 1953709 ns/iter (± 5632) 1933969 ns/iter (± 6449) 1.01
es/visitor/compare/visit_mut_span 2316003 ns/iter (± 8172) 2278787 ns/iter (± 6851) 1.02
es/visitor/compare/visit_mut_span_panic 2342280 ns/iter (± 6730) 2317488 ns/iter (± 3396) 1.01
es/visitor/compare/fold_span 3378086 ns/iter (± 27117) 3341104 ns/iter (± 6742) 1.01
es/visitor/compare/fold_span_panic 3531839 ns/iter (± 85109) 3477466 ns/iter (± 10494) 1.02
es/lexer/colors 12876 ns/iter (± 49) 13271 ns/iter (± 39) 0.97
es/lexer/angular 5999244 ns/iter (± 10299) 6112025 ns/iter (± 4903) 0.98
es/lexer/backbone 787497 ns/iter (± 1164) 801095 ns/iter (± 973) 0.98
es/lexer/jquery 4445509 ns/iter (± 5595) 4530198 ns/iter (± 4276) 0.98
es/lexer/jquery mobile 6726624 ns/iter (± 4858) 6916329 ns/iter (± 6621) 0.97
es/lexer/mootools 3502611 ns/iter (± 2250) 3589921 ns/iter (± 3773) 0.98
es/lexer/underscore 655692 ns/iter (± 297) 675523 ns/iter (± 839) 0.97
es/lexer/three 20982538 ns/iter (± 21406) 21486697 ns/iter (± 17953) 0.98
es/lexer/yui 3820452 ns/iter (± 1047) 3841754 ns/iter (± 3345) 0.99
es/parser/colors 27411 ns/iter (± 97) 27254 ns/iter (± 33) 1.01
es/parser/angular 13988857 ns/iter (± 190785) 13459263 ns/iter (± 59499) 1.04
es/parser/backbone 2020847 ns/iter (± 12071) 1984418 ns/iter (± 12507) 1.02
es/parser/jquery 11328541 ns/iter (± 168646) 10873496 ns/iter (± 44783) 1.04
es/parser/jquery mobile 17481954 ns/iter (± 308913) 16621099 ns/iter (± 43798) 1.05
es/parser/mootools 8545984 ns/iter (± 36529) 8376271 ns/iter (± 12871) 1.02
es/parser/underscore 1763528 ns/iter (± 9932) 1717202 ns/iter (± 8584) 1.03
es/parser/three 50346530 ns/iter (± 641954) 46682373 ns/iter (± 107811) 1.08
es/parser/yui 8476583 ns/iter (± 68927) 8295505 ns/iter (± 17681) 1.02
es/preset-env/usage/builtin_type 134281 ns/iter (± 31092) 137297 ns/iter (± 32512) 0.98
es/preset-env/usage/property 17406 ns/iter (± 50) 17102 ns/iter (± 57) 1.02
es/resolver/typescript 92813227 ns/iter (± 1636992) 87199347 ns/iter (± 857765) 1.06
es/fixer/typescript 66887425 ns/iter (± 1248527) 62647428 ns/iter (± 519252) 1.07
es/hygiene/typescript 135795133 ns/iter (± 1851047) 129551350 ns/iter (± 1190716) 1.05
es/resolver_with_hygiene/typescript 255711547 ns/iter (± 4948268) 239060431 ns/iter (± 841759) 1.07
es/visitor/base-perf/module_clone 58504 ns/iter (± 367) 58515 ns/iter (± 384) 1.00
es/visitor/base-perf/fold_empty 62826 ns/iter (± 497) 62608 ns/iter (± 485) 1.00
es/visitor/base-perf/fold_noop_impl_all 63758 ns/iter (± 248) 62706 ns/iter (± 178) 1.02
es/visitor/base-perf/fold_noop_impl_vec 63377 ns/iter (± 413) 63374 ns/iter (± 288) 1.00
es/visitor/base-perf/boxing_boxed_clone 57 ns/iter (± 0) 57 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 39 ns/iter (± 0) 40 ns/iter (± 0) 0.97
es/visitor/base-perf/boxing_boxed 108 ns/iter (± 0) 107 ns/iter (± 0) 1.01
es/visitor/base-perf/boxing_unboxed 78 ns/iter (± 0) 75 ns/iter (± 0) 1.04
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2528 ns/iter (± 14) 2551 ns/iter (± 22) 0.99
es/base/parallel/resolver/typescript 3941748667 ns/iter (± 317076874) 4277675482 ns/iter (± 207114186) 0.92
es/base/parallel/hygiene/typescript 1471490128 ns/iter (± 15547190) 1453684124 ns/iter (± 28918351) 1.01
misc/visitors/time-complexity/time 5 132 ns/iter (± 7) 134 ns/iter (± 0) 0.99
misc/visitors/time-complexity/time 10 291 ns/iter (± 0) 378 ns/iter (± 3) 0.77
misc/visitors/time-complexity/time 15 690 ns/iter (± 1) 673 ns/iter (± 7) 1.03
misc/visitors/time-complexity/time 20 1063 ns/iter (± 21) 1055 ns/iter (± 3) 1.01
misc/visitors/time-complexity/time 40 3563 ns/iter (± 8) 3570 ns/iter (± 8) 1.00
misc/visitors/time-complexity/time 60 7313 ns/iter (± 36) 7323 ns/iter (± 22) 1.00
es/full-target/es2016 229350 ns/iter (± 469) 232904 ns/iter (± 954) 0.98
es/full-target/es2017 217123 ns/iter (± 622) 219149 ns/iter (± 446) 0.99
es/full-target/es2018 206458 ns/iter (± 800) 208146 ns/iter (± 609) 0.99
es2020_nullish_coalescing 70588 ns/iter (± 509) 68280 ns/iter (± 474) 1.03
es2020_optional_chaining 83406 ns/iter (± 474) 79019 ns/iter (± 345) 1.06
es2022_class_properties 115355 ns/iter (± 328) 116978 ns/iter (± 323) 0.99
es2018_object_rest_spread 74989 ns/iter (± 537) 72668 ns/iter (± 215) 1.03
es2019_optional_catch_binding 65378 ns/iter (± 234) 62642 ns/iter (± 303) 1.04
es2017_async_to_generator 63908 ns/iter (± 211) 61527 ns/iter (± 455) 1.04
es2016_exponentiation 69324 ns/iter (± 276) 66576 ns/iter (± 228) 1.04
es2015_arrow 72891 ns/iter (± 343) 70180 ns/iter (± 203) 1.04
es2015_block_scoped_fn 69544 ns/iter (± 320) 66678 ns/iter (± 105) 1.04
es2015_block_scoping 123400 ns/iter (± 390) 120913 ns/iter (± 531) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.