Skip to content

Commit

Permalink
fix(plugin/runner): Disable wasi env cleanup (#7607)
Browse files Browse the repository at this point in the history
**Description:**

Even after setting shared runtime for the wasi env, `cleanup` still panics. I suspect something internal to cleanup doesn't honor those handles correctly; for now, disable it and try to see if this works.

As commented, this is not a huge issue as the plugin usually doesn't have resources to be cleaned up anyway.
  • Loading branch information
kwonoj committed Jun 30, 2023
1 parent efcad6a commit 8209594
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion crates/swc_plugin_runner/src/transform_executor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,13 @@ impl PluginTransformState {
guest_program_ptr.1,
)?;

// [TODO]: disabled for now as it always panic if it is being called
// inside of tokio runtime
// https://github.com/wasmerio/wasmer/discussions/3966
// [NOTE]: this is not a critical as plugin does not have things to clean up
// in most cases
if let Some(wasi_env) = &self.wasi_env {
wasi_env.cleanup(&mut self.store, None);
//wasi_env.cleanup(&mut self.store, None);
}

ret
Expand Down

1 comment on commit 8209594

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8209594 Previous: f0ab5b3 Ratio
es/full/bugs-1 315750 ns/iter (± 13958) 313546 ns/iter (± 8173) 1.01
es/full/minify/libraries/antd 1471254982 ns/iter (± 19865158) 1507702712 ns/iter (± 20353836) 0.98
es/full/minify/libraries/d3 320576698 ns/iter (± 5464125) 325601071 ns/iter (± 6344435) 0.98
es/full/minify/libraries/echarts 1204190652 ns/iter (± 5703973) 1222050220 ns/iter (± 9557951) 0.99
es/full/minify/libraries/jquery 95628019 ns/iter (± 455310) 96271341 ns/iter (± 376307) 0.99
es/full/minify/libraries/lodash 113855168 ns/iter (± 497710) 115472280 ns/iter (± 288292) 0.99
es/full/minify/libraries/moment 55933420 ns/iter (± 119350) 56417716 ns/iter (± 292297) 0.99
es/full/minify/libraries/react 20062804 ns/iter (± 83589) 20313365 ns/iter (± 76257) 0.99
es/full/minify/libraries/terser 248761265 ns/iter (± 1738033) 250292041 ns/iter (± 1779173) 0.99
es/full/minify/libraries/three 436744123 ns/iter (± 3354347) 447196214 ns/iter (± 3444679) 0.98
es/full/minify/libraries/typescript 2998120157 ns/iter (± 26755708) 3036686984 ns/iter (± 27407657) 0.99
es/full/minify/libraries/victory 656448350 ns/iter (± 6698209) 661652668 ns/iter (± 8398461) 0.99
es/full/minify/libraries/vue 138417556 ns/iter (± 752295) 139656263 ns/iter (± 363133) 0.99
es/full/codegen/es3 36502 ns/iter (± 81) 37261 ns/iter (± 101) 0.98
es/full/codegen/es5 36713 ns/iter (± 395) 37210 ns/iter (± 101) 0.99
es/full/codegen/es2015 36520 ns/iter (± 102) 37227 ns/iter (± 77) 0.98
es/full/codegen/es2016 36498 ns/iter (± 79) 37193 ns/iter (± 63) 0.98
es/full/codegen/es2017 36514 ns/iter (± 71) 37216 ns/iter (± 71) 0.98
es/full/codegen/es2018 36460 ns/iter (± 124) 37146 ns/iter (± 177) 0.98
es/full/codegen/es2019 36480 ns/iter (± 71) 37201 ns/iter (± 118) 0.98
es/full/codegen/es2020 36511 ns/iter (± 201) 37175 ns/iter (± 74) 0.98
es/full/all/es3 181052054 ns/iter (± 775410) 178752798 ns/iter (± 623178) 1.01
es/full/all/es5 172523479 ns/iter (± 457823) 170495486 ns/iter (± 486023) 1.01
es/full/all/es2015 127777520 ns/iter (± 745884) 126797054 ns/iter (± 511922) 1.01
es/full/all/es2016 126583454 ns/iter (± 424793) 126396005 ns/iter (± 364144) 1.00
es/full/all/es2017 125786775 ns/iter (± 468371) 125035905 ns/iter (± 391363) 1.01
es/full/all/es2018 124187922 ns/iter (± 708529) 123555520 ns/iter (± 457525) 1.01
es/full/all/es2019 123655468 ns/iter (± 363510) 122905194 ns/iter (± 423746) 1.01
es/full/all/es2020 118404443 ns/iter (± 834184) 118271618 ns/iter (± 631836) 1.00
es/full/parser 517161 ns/iter (± 6225) 513625 ns/iter (± 6377) 1.01
es/full/base/fixer 20817 ns/iter (± 153) 19117 ns/iter (± 158) 1.09
es/full/base/resolver_and_hygiene 96414 ns/iter (± 234) 95500 ns/iter (± 213) 1.01
serialization of serde 299 ns/iter (± 3) 303 ns/iter (± 0) 0.99
css/minify/libraries/bootstrap 30949212 ns/iter (± 86644) 30936579 ns/iter (± 85033) 1.00
css/visitor/compare/clone 2128459 ns/iter (± 36371) 2146033 ns/iter (± 21123) 0.99
css/visitor/compare/visit_mut_span 2257352 ns/iter (± 35410) 2275169 ns/iter (± 20338) 0.99
css/visitor/compare/visit_mut_span_panic 2325287 ns/iter (± 14425) 2348252 ns/iter (± 19081) 0.99
css/visitor/compare/fold_span 2992943 ns/iter (± 22471) 3069520 ns/iter (± 9749) 0.98
css/visitor/compare/fold_span_panic 3174715 ns/iter (± 28237) 3256806 ns/iter (± 11193) 0.97
css/lexer/bootstrap_5_1_3 4688099 ns/iter (± 7648) 4742460 ns/iter (± 2934) 0.99
css/lexer/foundation_6_7_4 3969923 ns/iter (± 1771) 3994633 ns/iter (± 1598) 0.99
css/lexer/tailwind_3_1_1 753689 ns/iter (± 388) 760591 ns/iter (± 433) 0.99
css/parser/bootstrap_5_1_3 20717709 ns/iter (± 34749) 20673816 ns/iter (± 34075) 1.00
css/parser/foundation_6_7_4 16679197 ns/iter (± 30692) 16748539 ns/iter (± 68498) 1.00
css/parser/tailwind_3_1_1 3227127 ns/iter (± 7772) 3207690 ns/iter (± 13405) 1.01
es/codegen/colors 734698 ns/iter (± 399125) 734810 ns/iter (± 398706) 1.00
es/codegen/large 2975791 ns/iter (± 1562809) 2975045 ns/iter (± 1557695) 1.00
es/codegen/with-parser/colors 48869 ns/iter (± 233) 49553 ns/iter (± 153) 0.99
es/codegen/with-parser/large 515253 ns/iter (± 1537) 518326 ns/iter (± 749) 0.99
es/minify/libraries/antd 1303743388 ns/iter (± 9036592) 1322954164 ns/iter (± 14237754) 0.99
es/minify/libraries/d3 279583215 ns/iter (± 1447669) 279861232 ns/iter (± 2286395) 1.00
es/minify/libraries/echarts 1043823063 ns/iter (± 6477272) 1063393696 ns/iter (± 8673744) 0.98
es/minify/libraries/jquery 83833670 ns/iter (± 146316) 84370334 ns/iter (± 206029) 0.99
es/minify/libraries/lodash 102924679 ns/iter (± 289054) 103193705 ns/iter (± 428318) 1.00
es/minify/libraries/moment 49244517 ns/iter (± 68491) 49556584 ns/iter (± 97418) 0.99
es/minify/libraries/react 17948476 ns/iter (± 169321) 18184069 ns/iter (± 46053) 0.99
es/minify/libraries/terser 211516900 ns/iter (± 628385) 213800618 ns/iter (± 621988) 0.99
es/minify/libraries/three 365643881 ns/iter (± 2409813) 376434042 ns/iter (± 7915185) 0.97
es/minify/libraries/typescript 2525780943 ns/iter (± 10975100) 2639036302 ns/iter (± 11021417) 0.96
es/minify/libraries/victory 542164571 ns/iter (± 3432721) 553618264 ns/iter (± 4901079) 0.98
es/minify/libraries/vue 123852495 ns/iter (± 638928) 124540879 ns/iter (± 415410) 0.99
es/visitor/compare/clone 2092946 ns/iter (± 10121) 2086718 ns/iter (± 3550) 1.00
es/visitor/compare/visit_mut_span 2435221 ns/iter (± 8914) 2415798 ns/iter (± 21556) 1.01
es/visitor/compare/visit_mut_span_panic 2476574 ns/iter (± 5940) 2472278 ns/iter (± 8196) 1.00
es/visitor/compare/fold_span 3513187 ns/iter (± 6613) 3500358 ns/iter (± 4105) 1.00
es/visitor/compare/fold_span_panic 3649153 ns/iter (± 5038) 3639353 ns/iter (± 8868) 1.00
es/lexer/colors 13269 ns/iter (± 34) 13428 ns/iter (± 121) 0.99
es/lexer/angular 6271584 ns/iter (± 15951) 6247010 ns/iter (± 6677) 1.00
es/lexer/backbone 832507 ns/iter (± 2447) 818109 ns/iter (± 2008) 1.02
es/lexer/jquery 4688253 ns/iter (± 9753) 4658003 ns/iter (± 5296) 1.01
es/lexer/jquery mobile 7227164 ns/iter (± 26032) 7138189 ns/iter (± 18902) 1.01
es/lexer/mootools 3672175 ns/iter (± 18461) 3654426 ns/iter (± 4099) 1.00
es/lexer/underscore 689633 ns/iter (± 6160) 685655 ns/iter (± 2777) 1.01
es/lexer/three 22034968 ns/iter (± 32524) 21652015 ns/iter (± 22566) 1.02
es/lexer/yui 4142836 ns/iter (± 13285) 4101020 ns/iter (± 2904) 1.01
es/parser/colors 28950 ns/iter (± 35) 29337 ns/iter (± 119) 0.99
es/parser/angular 14063881 ns/iter (± 87181) 14338933 ns/iter (± 48960) 0.98
es/parser/backbone 2101719 ns/iter (± 8688) 2133095 ns/iter (± 12254) 0.99
es/parser/jquery 11419224 ns/iter (± 51833) 11645779 ns/iter (± 52331) 0.98
es/parser/jquery mobile 17531751 ns/iter (± 88034) 17817052 ns/iter (± 23947) 0.98
es/parser/mootools 8748132 ns/iter (± 21880) 8888926 ns/iter (± 22762) 0.98
es/parser/underscore 1802672 ns/iter (± 9480) 1841379 ns/iter (± 8946) 0.98
es/parser/three 48986259 ns/iter (± 278331) 49907741 ns/iter (± 596476) 0.98
es/parser/yui 8862091 ns/iter (± 92597) 8887073 ns/iter (± 54006) 1.00
es/preset-env/usage/builtin_type 144037 ns/iter (± 33693) 143763 ns/iter (± 33743) 1.00
es/preset-env/usage/property 18266 ns/iter (± 110) 19154 ns/iter (± 42) 0.95
es/resolver/typescript 96069272 ns/iter (± 1369610) 96017266 ns/iter (± 709860) 1.00
es/fixer/typescript 65867221 ns/iter (± 706758) 67963022 ns/iter (± 705650) 0.97
es/hygiene/typescript 142924500 ns/iter (± 642356) 145259141 ns/iter (± 862940) 0.98
es/resolver_with_hygiene/typescript 301350845 ns/iter (± 1142443) 304590316 ns/iter (± 2939345) 0.99
es/visitor/base-perf/module_clone 62269 ns/iter (± 297) 61392 ns/iter (± 195) 1.01
es/visitor/base-perf/fold_empty 65658 ns/iter (± 276) 65016 ns/iter (± 261) 1.01
es/visitor/base-perf/fold_noop_impl_all 65946 ns/iter (± 264) 65315 ns/iter (± 325) 1.01
es/visitor/base-perf/fold_noop_impl_vec 66189 ns/iter (± 294) 65295 ns/iter (± 402) 1.01
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 60 ns/iter (± 0) 0.93
es/visitor/base-perf/boxing_unboxed_clone 40 ns/iter (± 0) 39 ns/iter (± 0) 1.03
es/visitor/base-perf/boxing_boxed 108 ns/iter (± 0) 116 ns/iter (± 0) 0.93
es/visitor/base-perf/boxing_unboxed 79 ns/iter (± 0) 83 ns/iter (± 0) 0.95
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2637 ns/iter (± 7) 2635 ns/iter (± 13) 1.00
es/base/parallel/resolver/typescript 4513833990 ns/iter (± 266368220) 4768058000 ns/iter (± 267537701) 0.95
es/base/parallel/hygiene/typescript 1567435918 ns/iter (± 12446102) 1596438976 ns/iter (± 13045405) 0.98
misc/visitors/time-complexity/time 5 108 ns/iter (± 0) 104 ns/iter (± 2) 1.04
misc/visitors/time-complexity/time 10 300 ns/iter (± 0) 282 ns/iter (± 6) 1.06
misc/visitors/time-complexity/time 15 519 ns/iter (± 1) 503 ns/iter (± 0) 1.03
misc/visitors/time-complexity/time 20 1050 ns/iter (± 2) 900 ns/iter (± 2) 1.17
misc/visitors/time-complexity/time 40 3571 ns/iter (± 8) 3571 ns/iter (± 13) 1
misc/visitors/time-complexity/time 60 7460 ns/iter (± 93) 7334 ns/iter (± 23) 1.02
es/full-target/es2016 238914 ns/iter (± 1306) 236321 ns/iter (± 515) 1.01
es/full-target/es2017 224168 ns/iter (± 1199) 223568 ns/iter (± 353) 1.00
es/full-target/es2018 212240 ns/iter (± 947) 211054 ns/iter (± 536) 1.01
es2020_nullish_coalescing 71988 ns/iter (± 520) 72231 ns/iter (± 294) 1.00
es2020_optional_chaining 82301 ns/iter (± 391) 83261 ns/iter (± 255) 0.99
es2022_class_properties 120532 ns/iter (± 269) 121332 ns/iter (± 502) 0.99
es2018_object_rest_spread 70829 ns/iter (± 350) 71242 ns/iter (± 580) 0.99
es2019_optional_catch_binding 64279 ns/iter (± 207) 63118 ns/iter (± 150) 1.02
es2017_async_to_generator 64917 ns/iter (± 176) 63672 ns/iter (± 176) 1.02
es2016_exponentiation 69506 ns/iter (± 266) 68259 ns/iter (± 258) 1.02
es2015_arrow 72766 ns/iter (± 137) 71718 ns/iter (± 334) 1.01
es2015_block_scoped_fn 69081 ns/iter (± 264) 68246 ns/iter (± 150) 1.01
es2015_block_scoping 130661 ns/iter (± 613) 129265 ns/iter (± 548) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.