Skip to content

Commit

Permalink
refactor(common): Remove add_bitflags and update bitflags (#7571)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kosayoda
kosayoda committed Jun 23, 2023
1 parent 068c172 commit 95ac74e
Show file tree
Hide file tree
Showing 17 changed files with 217 additions and 584 deletions.
20 changes: 9 additions & 11 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/swc_common/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ swc_visit = { version = "0.5.7", path = "../swc_visit" }


[dev-dependencies]
bitflags = "2.1.0"
criterion = "0.5"
rayon = "1"
serde_json = "1"
Expand Down
169 changes: 0 additions & 169 deletions crates/swc_common/examples/add_bitflags.rs
View file

This file was deleted.

1 change: 0 additions & 1 deletion crates/swc_common/src/lib.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ mod eq;
pub mod errors;
pub mod input;
pub mod iter;
pub mod macros;
pub mod pass;
pub mod plugin;
mod pos;
Expand Down

1 comment on commit 95ac74e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 95ac74e Previous: d86f8f6 Ratio
es/full/bugs-1 306156 ns/iter (± 6877) 301294 ns/iter (± 6264) 1.02
es/full/minify/libraries/antd 1438711106 ns/iter (± 18414660) 1485653170 ns/iter (± 19414753) 0.97
es/full/minify/libraries/d3 316370910 ns/iter (± 2943859) 328290632 ns/iter (± 10975517) 0.96
es/full/minify/libraries/echarts 1166797532 ns/iter (± 3080325) 1209673516 ns/iter (± 14546819) 0.96
es/full/minify/libraries/jquery 95218406 ns/iter (± 174917) 95916042 ns/iter (± 257158) 0.99
es/full/minify/libraries/lodash 112990137 ns/iter (± 293806) 114119965 ns/iter (± 528325) 0.99
es/full/minify/libraries/moment 55799160 ns/iter (± 51599) 56090702 ns/iter (± 178904) 0.99
es/full/minify/libraries/react 20065794 ns/iter (± 43757) 20112096 ns/iter (± 105488) 1.00
es/full/minify/libraries/terser 244116687 ns/iter (± 502761) 248711768 ns/iter (± 1643717) 0.98
es/full/minify/libraries/three 426204733 ns/iter (± 1061373) 442240095 ns/iter (± 3648939) 0.96
es/full/minify/libraries/typescript 2915844973 ns/iter (± 12081114) 3016586468 ns/iter (± 35673678) 0.97
es/full/minify/libraries/victory 629603643 ns/iter (± 6797986) 650606263 ns/iter (± 5513823) 0.97
es/full/minify/libraries/vue 137176992 ns/iter (± 161321) 138436344 ns/iter (± 685131) 0.99
es/full/codegen/es3 38205 ns/iter (± 119) 38033 ns/iter (± 92) 1.00
es/full/codegen/es5 38294 ns/iter (± 59) 38097 ns/iter (± 89) 1.01
es/full/codegen/es2015 38268 ns/iter (± 49) 38098 ns/iter (± 80) 1.00
es/full/codegen/es2016 38282 ns/iter (± 63) 38181 ns/iter (± 102) 1.00
es/full/codegen/es2017 38275 ns/iter (± 86) 38190 ns/iter (± 132) 1.00
es/full/codegen/es2018 38253 ns/iter (± 109) 38103 ns/iter (± 73) 1.00
es/full/codegen/es2019 38204 ns/iter (± 163) 38152 ns/iter (± 122) 1.00
es/full/codegen/es2020 38399 ns/iter (± 102) 38159 ns/iter (± 83) 1.01
es/full/all/es3 177524163 ns/iter (± 485414) 178235399 ns/iter (± 1013213) 1.00
es/full/all/es5 169342013 ns/iter (± 731376) 170733603 ns/iter (± 481092) 0.99
es/full/all/es2015 125979476 ns/iter (± 731682) 126826614 ns/iter (± 375093) 0.99
es/full/all/es2016 125253777 ns/iter (± 646359) 126365176 ns/iter (± 464006) 0.99
es/full/all/es2017 124476824 ns/iter (± 553228) 126283511 ns/iter (± 633773) 0.99
es/full/all/es2018 122604713 ns/iter (± 578848) 123334056 ns/iter (± 446160) 0.99
es/full/all/es2019 121633967 ns/iter (± 514412) 123653306 ns/iter (± 670161) 0.98
es/full/all/es2020 117239435 ns/iter (± 650235) 118821341 ns/iter (± 662972) 0.99
es/full/parser 504959 ns/iter (± 6116) 514655 ns/iter (± 5750) 0.98
es/full/base/fixer 19108 ns/iter (± 105) 18943 ns/iter (± 117) 1.01
es/full/base/resolver_and_hygiene 94899 ns/iter (± 320) 95856 ns/iter (± 803) 0.99
serialization of serde 315 ns/iter (± 0) 309 ns/iter (± 1) 1.02
css/minify/libraries/bootstrap 30510700 ns/iter (± 46727) 31019763 ns/iter (± 90756) 0.98
css/visitor/compare/clone 1957272 ns/iter (± 39313) 2017156 ns/iter (± 14743) 0.97
css/visitor/compare/visit_mut_span 2114187 ns/iter (± 18141) 2120120 ns/iter (± 9846) 1.00
css/visitor/compare/visit_mut_span_panic 2166347 ns/iter (± 26243) 2202470 ns/iter (± 12292) 0.98
css/visitor/compare/fold_span 2999290 ns/iter (± 21250) 2835515 ns/iter (± 12336) 1.06
css/visitor/compare/fold_span_panic 3207003 ns/iter (± 26128) 3014920 ns/iter (± 10700) 1.06
css/lexer/bootstrap_5_1_3 4820820 ns/iter (± 3533) 4764454 ns/iter (± 5349) 1.01
css/lexer/foundation_6_7_4 4058121 ns/iter (± 2623) 4001886 ns/iter (± 1105) 1.01
css/lexer/tailwind_3_1_1 768997 ns/iter (± 403) 756489 ns/iter (± 2369) 1.02
css/parser/bootstrap_5_1_3 20394508 ns/iter (± 26125) 20741972 ns/iter (± 39755) 0.98
css/parser/foundation_6_7_4 16446631 ns/iter (± 8262) 16675748 ns/iter (± 24512) 0.99
css/parser/tailwind_3_1_1 3185568 ns/iter (± 3416) 3239200 ns/iter (± 4103) 0.98
es/codegen/colors 739681 ns/iter (± 401215) 737526 ns/iter (± 400510) 1.00
es/codegen/large 3224876 ns/iter (± 1697177) 2981143 ns/iter (± 1562297) 1.08
es/codegen/with-parser/colors 49195 ns/iter (± 268) 49228 ns/iter (± 185) 1.00
es/codegen/with-parser/large 525025 ns/iter (± 1027) 518057 ns/iter (± 1610) 1.01
es/minify/libraries/antd 1276546595 ns/iter (± 14397082) 1316454798 ns/iter (± 13115714) 0.97
es/minify/libraries/d3 276978538 ns/iter (± 347251) 279387956 ns/iter (± 1643540) 0.99
es/minify/libraries/echarts 1016343365 ns/iter (± 2746476) 1053581685 ns/iter (± 10189167) 0.96
es/minify/libraries/jquery 83667648 ns/iter (± 147450) 83788507 ns/iter (± 612981) 1.00
es/minify/libraries/lodash 103138552 ns/iter (± 131404) 102812781 ns/iter (± 349114) 1.00
es/minify/libraries/moment 49484425 ns/iter (± 46189) 49135565 ns/iter (± 75856) 1.01
es/minify/libraries/react 18072125 ns/iter (± 39398) 17971984 ns/iter (± 45463) 1.01
es/minify/libraries/terser 212076674 ns/iter (± 395769) 214163955 ns/iter (± 937203) 0.99
es/minify/libraries/three 364135755 ns/iter (± 511600) 368860912 ns/iter (± 3219180) 0.99
es/minify/libraries/typescript 2559395646 ns/iter (± 8330991) 2587366771 ns/iter (± 9918194) 0.99
es/minify/libraries/victory 533014280 ns/iter (± 3455724) 552900739 ns/iter (± 20826442) 0.96
es/minify/libraries/vue 123810491 ns/iter (± 169965) 125100884 ns/iter (± 706466) 0.99
es/visitor/compare/clone 2058373 ns/iter (± 12072) 2071882 ns/iter (± 5724) 0.99
es/visitor/compare/visit_mut_span 2401875 ns/iter (± 6057) 2408184 ns/iter (± 3434) 1.00
es/visitor/compare/visit_mut_span_panic 2420773 ns/iter (± 3148) 2450961 ns/iter (± 4791) 0.99
es/visitor/compare/fold_span 3451387 ns/iter (± 3700) 3481232 ns/iter (± 4901) 0.99
es/visitor/compare/fold_span_panic 3584854 ns/iter (± 7908) 3620643 ns/iter (± 2559) 0.99
es/lexer/colors 13260 ns/iter (± 20) 13193 ns/iter (± 69) 1.01
es/lexer/angular 6326528 ns/iter (± 23520) 6353260 ns/iter (± 3488) 1.00
es/lexer/backbone 821117 ns/iter (± 474) 812181 ns/iter (± 1522) 1.01
es/lexer/jquery 4650906 ns/iter (± 2621) 4638921 ns/iter (± 6746) 1.00
es/lexer/jquery mobile 7102622 ns/iter (± 12530) 7078528 ns/iter (± 5823) 1.00
es/lexer/mootools 3650336 ns/iter (± 4107) 3655476 ns/iter (± 3519) 1.00
es/lexer/underscore 686593 ns/iter (± 2523) 683089 ns/iter (± 905) 1.01
es/lexer/three 21569611 ns/iter (± 37606) 21574415 ns/iter (± 28963) 1.00
es/lexer/yui 4121083 ns/iter (± 31969) 4065151 ns/iter (± 24041) 1.01
es/parser/colors 28914 ns/iter (± 142) 29017 ns/iter (± 166) 1.00
es/parser/angular 14165136 ns/iter (± 54687) 14201912 ns/iter (± 41433) 1.00
es/parser/backbone 2116281 ns/iter (± 8697) 2110806 ns/iter (± 7950) 1.00
es/parser/jquery 11520755 ns/iter (± 48683) 11512153 ns/iter (± 60269) 1.00
es/parser/jquery mobile 17598890 ns/iter (± 51304) 17749963 ns/iter (± 153871) 0.99
es/parser/mootools 8824468 ns/iter (± 26953) 8825230 ns/iter (± 27637) 1.00
es/parser/underscore 1825600 ns/iter (± 9477) 1818554 ns/iter (± 10901) 1.00
es/parser/three 48289278 ns/iter (± 123786) 49202333 ns/iter (± 389327) 0.98
es/parser/yui 8882326 ns/iter (± 30601) 8898208 ns/iter (± 25624) 1.00
es/preset-env/usage/builtin_type 141384 ns/iter (± 32243) 143989 ns/iter (± 34051) 0.98
es/preset-env/usage/property 18982 ns/iter (± 100) 18659 ns/iter (± 55) 1.02
es/resolver/typescript 94990323 ns/iter (± 1961615) 98755894 ns/iter (± 1576737) 0.96
es/fixer/typescript 64597093 ns/iter (± 1211207) 67127336 ns/iter (± 651894) 0.96
es/hygiene/typescript 142926982 ns/iter (± 1753077) 145974514 ns/iter (± 2218707) 0.98
es/resolver_with_hygiene/typescript 302759678 ns/iter (± 2713021) 303994611 ns/iter (± 2797648) 1.00
es/visitor/base-perf/module_clone 61707 ns/iter (± 389) 62531 ns/iter (± 209) 0.99
es/visitor/base-perf/fold_empty 65004 ns/iter (± 534) 66202 ns/iter (± 175) 0.98
es/visitor/base-perf/fold_noop_impl_all 65313 ns/iter (± 250) 66655 ns/iter (± 286) 0.98
es/visitor/base-perf/fold_noop_impl_vec 65258 ns/iter (± 287) 66902 ns/iter (± 179) 0.98
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 43 ns/iter (± 0) 43 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 108 ns/iter (± 0) 111 ns/iter (± 0) 0.97
es/visitor/base-perf/boxing_unboxed 79 ns/iter (± 0) 81 ns/iter (± 0) 0.98
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2609 ns/iter (± 8) 2614 ns/iter (± 9) 1.00
es/base/parallel/resolver/typescript 4726906065 ns/iter (± 322476825) 4633309368 ns/iter (± 293742905) 1.02
es/base/parallel/hygiene/typescript 1651454865 ns/iter (± 25005528) 1599777289 ns/iter (± 10437930) 1.03
misc/visitors/time-complexity/time 5 98 ns/iter (± 0) 100 ns/iter (± 0) 0.98
misc/visitors/time-complexity/time 10 290 ns/iter (± 0) 293 ns/iter (± 0) 0.99
misc/visitors/time-complexity/time 15 492 ns/iter (± 1) 508 ns/iter (± 2) 0.97
misc/visitors/time-complexity/time 20 922 ns/iter (± 5) 889 ns/iter (± 6) 1.04
misc/visitors/time-complexity/time 40 4127 ns/iter (± 6) 3524 ns/iter (± 15) 1.17
misc/visitors/time-complexity/time 60 7748 ns/iter (± 20) 7279 ns/iter (± 14) 1.06
es/full-target/es2016 240276 ns/iter (± 780) 240667 ns/iter (± 754) 1.00
es/full-target/es2017 226551 ns/iter (± 1073) 226324 ns/iter (± 591) 1.00
es/full-target/es2018 214209 ns/iter (± 685) 215231 ns/iter (± 750) 1.00
es2020_nullish_coalescing 71401 ns/iter (± 430) 73925 ns/iter (± 445) 0.97
es2020_optional_chaining 83788 ns/iter (± 458) 85347 ns/iter (± 405) 0.98
es2022_class_properties 120755 ns/iter (± 502) 122023 ns/iter (± 348) 0.99
es2018_object_rest_spread 75311 ns/iter (± 165) 76334 ns/iter (± 195) 0.99
es2019_optional_catch_binding 64464 ns/iter (± 299) 66134 ns/iter (± 330) 0.97
es2017_async_to_generator 64334 ns/iter (± 384) 66316 ns/iter (± 232) 0.97
es2016_exponentiation 69358 ns/iter (± 239) 71337 ns/iter (± 550) 0.97
es2015_arrow 72444 ns/iter (± 202) 74447 ns/iter (± 300) 0.97
es2015_block_scoped_fn 68591 ns/iter (± 171) 71526 ns/iter (± 173) 0.96
es2015_block_scoping 132676 ns/iter (± 568) 133946 ns/iter (± 595) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.