Skip to content

Commit

Permalink
fix(es/modules): Improve compatibility with cjs lexer (#5080)
Browse files Browse the repository at this point in the history
  • Loading branch information
@magic-akari
magic-akari committed Jul 1, 2022
1 parent 8aaf25f commit 9e162dc
Show file tree
Hide file tree
Showing 477 changed files with 952 additions and 952 deletions.
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/codegen/escape/case-1/output/index.js
View file
Expand Up @@ -3,9 +3,9 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "default", {
enumerable: true,
get: function() {
return _default;
},
enumerable: true
}
});
var _default = "\nvoid main() {\n gl_Position = projectionMatrix * modelViewMatrix * vec4( position, 1.0 );\n}\n";
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/codegen/escape/case-2/output/index.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/deno/paths/issue-2126/output/packages/a/src/index.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "displayA", {
get: ()=>displayA,
enumerable: true
enumerable: true,
get: ()=>displayA
});
function displayA() {
return "Display A";
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/deno/paths/issue-2724/output/packages/a/src/index.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "displayA", {
get: ()=>displayA,
enumerable: true
enumerable: true,
get: ()=>displayA
});
function displayA() {
return "Display A";
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/deno/paths/issue-2844/output/src/core/utils/utilFile.ts
View file
Expand Up @@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "test", {
get: ()=>test,
enumerable: true
enumerable: true,
get: ()=>test
});
function test() {}
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/deno/paths/issue-2844/output/src/utils/index.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "utilFn", {
get: ()=>utilFn,
enumerable: true
enumerable: true,
get: ()=>utilFn
});
const _utilFile = require("../core/utils/utilFile");
(0, _utilFile.test)();
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/interop/babel/output/index.js
View file
Expand Up @@ -4,8 +4,8 @@ Object.defineProperty(exports, "__esModule", {
});
function _export(target, all) {
for(var name in all)Object.defineProperty(target, name, {
get: all[name],
enumerable: true
enumerable: true,
get: all[name]
});
}
_export(exports, {
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/interop/node/output/index.js
View file
Expand Up @@ -5,8 +5,8 @@ Object.defineProperty(exports, "__esModule", {
exports.y = exports.x = exports.default = void 0;
function _export(target, all) {
for(var name in all)Object.defineProperty(target, name, {
get: all[name],
enumerable: true
enumerable: true,
get: all[name]
});
}
_export(exports, {
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/interop/none/output/index.js
View file
@@ -1,8 +1,8 @@
"use strict";
function _export(target, all) {
for(var name in all)Object.defineProperty(target, name, {
get: all[name],
enumerable: true
enumerable: true,
get: all[name]
});
}
_export(exports, {
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/interop/swc/output/index.js
View file
Expand Up @@ -4,8 +4,8 @@ Object.defineProperty(exports, "__esModule", {
});
function _export(target, all) {
for(var name in all)Object.defineProperty(target, name, {
get: all[name],
enumerable: true
enumerable: true,
get: all[name]
});
}
_export(exports, {
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1213/output/index.js
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "default", {
get: ()=>NotOK,
enumerable: true
enumerable: true,
get: ()=>NotOK
});
const _interopRequireDefault = require("@swc/helpers/lib/_interop_require_default.js").default;
const _foo = _interopRequireDefault(require("foo"));
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1307/output/index.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "foo", {
get: ()=>_foo,
enumerable: true
enumerable: true,
get: ()=>_foo
});
const _interopRequireWildcard = require("@swc/helpers/lib/_interop_require_wildcard.js").default;
const _foo = _interopRequireWildcard(require("./foo"));
2 changes: 1 addition & 1 deletion crates/swc/tests/fixture/issues-1xxx/1309/case1/output/index.map
View file
@@ -1,5 +1,5 @@
{
"mappings": "AAAA;;;;+BAAaA,KAAG;aAAHA,GAAG;;;AAAT,MAAMA,GAAG,GAAG,CAAC,AAAC",
"mappings": "AAAA;;;;+BAAaA,KAAG;;aAAHA,GAAG;;AAAT,MAAMA,GAAG,GAAG,CAAC,AAAC",
"names": [
"foo"
],
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1309/case1/output/index.ts
View file
Expand Up @@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "foo", {
get: ()=>foo,
enumerable: true
enumerable: true,
get: ()=>foo
});
const foo = 1;
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1333/case2/output/index.js
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "Shard", {
get: ()=>Shard,
enumerable: true
enumerable: true,
get: ()=>Shard
});
const _classPrivateFieldGet = require("@swc/helpers/lib/_class_private_field_get.js").default;
const _classPrivateFieldInit = require("@swc/helpers/lib/_class_private_field_init.js").default;
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1333/case3/output/index.js
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "RequestHandler", {
get: ()=>RequestHandler,
enumerable: true
enumerable: true,
get: ()=>RequestHandler
});
const _classPrivateFieldGet = require("@swc/helpers/lib/_class_private_field_get.js").default;
const _classPrivateFieldInit = require("@swc/helpers/lib/_class_private_field_init.js").default;
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1362/case1/output/index.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "AppController", {
get: ()=>AppController,
enumerable: true
enumerable: true,
get: ()=>AppController
});
const _tsDecorate = require("@swc/helpers/lib/_ts_decorate.js").default;
const _tsMetadata = require("@swc/helpers/lib/_ts_metadata.js").default;
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1454/case1/output/index.ts
View file
Expand Up @@ -2,8 +2,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "AbstractProviderDeliveryService", {
get: ()=>AbstractProviderDeliveryService,
enumerable: true
enumerable: true,
get: ()=>AbstractProviderDeliveryService
});
class AbstractProviderDeliveryService {
}
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1454/case2/output/index.ts
View file
Expand Up @@ -2,8 +2,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "AbstractProviderDeliveryService", {
get: ()=>AbstractProviderDeliveryService,
enumerable: true
enumerable: true,
get: ()=>AbstractProviderDeliveryService
});
class AbstractProviderDeliveryService {
}
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1515/case1/output/input.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "ServiceError", {
get: ()=>ServiceError,
enumerable: true
enumerable: true,
get: ()=>ServiceError
});
class ServiceError extends Error {
constructor(...args){
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1554/case1/output/index.js
View file
Expand Up @@ -4,8 +4,8 @@ Object.defineProperty(exports, "__esModule", {
});
function _export(target, all) {
for(var name in all)Object.defineProperty(target, name, {
get: all[name],
enumerable: true
enumerable: true,
get: all[name]
});
}
_export(exports, {
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1554/case2/output/index.js
View file
Expand Up @@ -4,8 +4,8 @@ Object.defineProperty(exports, "__esModule", {
});
function _export(target, all) {
for(var name in all)Object.defineProperty(target, name, {
get: all[name],
enumerable: true
enumerable: true,
get: all[name]
});
}
_export(exports, {
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1568/case1/output/index.ts
View file
Expand Up @@ -3,10 +3,10 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "default", {
enumerable: true,
get: function() {
return get;
},
enumerable: true
}
});
function get(key) {
console.log(key);
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1682/case1/output/index.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "getPackage", {
get: ()=>getPackage,
enumerable: true
enumerable: true,
get: ()=>getPackage
});
const _interopRequireWildcard = require("@swc/helpers/lib/_interop_require_wildcard.js").default;
const _path = require("path");
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1682/case2/output/index.ts
View file
Expand Up @@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "getPackage", {
get: ()=>getPackage,
enumerable: true
enumerable: true,
get: ()=>getPackage
});
const _interopRequireWildcard = require("@swc/helpers/lib/_interop_require_wildcard.js").default;
const _path = require("path");
Expand Down
4 changes: 2 additions & 2 deletions crates/swc/tests/fixture/issues-1xxx/1714/case1/output/index.js
View file
Expand Up @@ -3,10 +3,10 @@ Object.defineProperty(exports, "__esModule", {
value: true
});
Object.defineProperty(exports, "render", {
enumerable: true,
get: function() {
return _customRender.customRender;
},
enumerable: true
}
});
var _exportStar = require("@swc/helpers/lib/_export_star.js").default;
var _customRender = require("./customRender");
Expand Down

1 comment on commit 9e162dc

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 9e162dc Previous: 144314d Ratio
es/full/minify/libraries/antd 1652092369 ns/iter (± 14337181) 1708790069 ns/iter (± 27418162) 0.97
es/full/minify/libraries/d3 415379336 ns/iter (± 10467904) 435219756 ns/iter (± 13233451) 0.95
es/full/minify/libraries/echarts 1647984761 ns/iter (± 26605259) 1674322346 ns/iter (± 45570743) 0.98
es/full/minify/libraries/jquery 93846127 ns/iter (± 11031820) 101892765 ns/iter (± 4386798) 0.92
es/full/minify/libraries/lodash 120933113 ns/iter (± 2684159) 121425625 ns/iter (± 3702519) 1.00
es/full/minify/libraries/moment 54366238 ns/iter (± 1993855) 53281567 ns/iter (± 950262) 1.02
es/full/minify/libraries/react 17848486 ns/iter (± 425960) 18009632 ns/iter (± 1489144) 0.99
es/full/minify/libraries/terser 606792372 ns/iter (± 8678062) 609486881 ns/iter (± 21719225) 1.00
es/full/minify/libraries/three 540594051 ns/iter (± 11695241) 540734827 ns/iter (± 10822122) 1.00
es/full/minify/libraries/typescript 3464173689 ns/iter (± 88243979) 3466710781 ns/iter (± 73446741) 1.00
es/full/minify/libraries/victory 746265943 ns/iter (± 8091425) 726400293 ns/iter (± 11084581) 1.03
es/full/minify/libraries/vue 156146181 ns/iter (± 8414149) 137136099 ns/iter (± 4073556) 1.14
es/full/codegen/es3 33205 ns/iter (± 611) 32884 ns/iter (± 581) 1.01
es/full/codegen/es5 33215 ns/iter (± 909) 33061 ns/iter (± 532) 1.00
es/full/codegen/es2015 33259 ns/iter (± 1100) 32708 ns/iter (± 677) 1.02
es/full/codegen/es2016 33242 ns/iter (± 738) 33139 ns/iter (± 1031) 1.00
es/full/codegen/es2017 33170 ns/iter (± 1045) 32842 ns/iter (± 878) 1.01
es/full/codegen/es2018 33155 ns/iter (± 378) 32726 ns/iter (± 1345) 1.01
es/full/codegen/es2019 33011 ns/iter (± 2146) 32685 ns/iter (± 378) 1.01
es/full/codegen/es2020 33320 ns/iter (± 1354) 31977 ns/iter (± 534) 1.04
es/full/all/es3 188580106 ns/iter (± 7161106) 180770726 ns/iter (± 5489659) 1.04
es/full/all/es5 173096220 ns/iter (± 7219992) 167851942 ns/iter (± 4810659) 1.03
es/full/all/es2015 141188859 ns/iter (± 4320421) 136622568 ns/iter (± 3422141) 1.03
es/full/all/es2016 139916350 ns/iter (± 6120522) 135107879 ns/iter (± 3699922) 1.04
es/full/all/es2017 139306422 ns/iter (± 4590568) 134780456 ns/iter (± 4311193) 1.03
es/full/all/es2018 139027924 ns/iter (± 7416859) 133132947 ns/iter (± 3498957) 1.04
es/full/all/es2019 139663822 ns/iter (± 4105802) 135971252 ns/iter (± 3868829) 1.03
es/full/all/es2020 131759207 ns/iter (± 9048146) 130871500 ns/iter (± 3172889) 1.01
es/full/parser 714920 ns/iter (± 45123) 700229 ns/iter (± 14545) 1.02
es/full/base/fixer 30469 ns/iter (± 920) 29433 ns/iter (± 444) 1.04
es/full/base/resolver_and_hygiene 89757 ns/iter (± 2228) 87814 ns/iter (± 2575) 1.02
serialization of ast node 217 ns/iter (± 5) 216 ns/iter (± 5) 1.00
serialization of serde 238 ns/iter (± 9) 242 ns/iter (± 2) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.