Skip to content

Commit

Permalink
chore(es/parser): Scope use of lexical to certain features (#7644)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Manishearth
Manishearth committed Jul 13, 2023
1 parent e4f9f73 commit a961090
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ members = [
"crates/swc_timer",
"crates/swc_xml",
]

resolver = "2"
[profile.release]
# lto = true

Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_parser/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ verify = ["swc_ecma_visit"]

[dependencies]
either = { version = "1.4" }
lexical = { version = "6.1.0", features = ["power-of-two"] }
lexical = { version = "6.1.0", features = ["power-of-two", "parse-integers", "parse-floats"], default-features = false }
num-bigint = "0.4"
serde = { version = "1", features = ["derive"] }
smallvec = "1.8.0"
Expand Down

1 comment on commit a961090

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: a961090 Previous: 19ba714 Ratio
es/full/bugs-1 290787 ns/iter (± 16380) 284103 ns/iter (± 5039) 1.02
es/full/minify/libraries/antd 1345257057 ns/iter (± 13080887) 1325882332 ns/iter (± 13003837) 1.01
es/full/minify/libraries/d3 283318667 ns/iter (± 2822957) 277715193 ns/iter (± 2573565) 1.02
es/full/minify/libraries/echarts 1075479151 ns/iter (± 4266400) 1082790323 ns/iter (± 6208103) 0.99
es/full/minify/libraries/jquery 85395014 ns/iter (± 391687) 84518119 ns/iter (± 193690) 1.01
es/full/minify/libraries/lodash 99282374 ns/iter (± 373952) 98652344 ns/iter (± 227995) 1.01
es/full/minify/libraries/moment 50233580 ns/iter (± 120921) 49906307 ns/iter (± 112389) 1.01
es/full/minify/libraries/react 18081057 ns/iter (± 47982) 17981300 ns/iter (± 45637) 1.01
es/full/minify/libraries/terser 222054691 ns/iter (± 1082551) 219644344 ns/iter (± 1035503) 1.01
es/full/minify/libraries/three 390079460 ns/iter (± 1068066) 383442273 ns/iter (± 2250969) 1.02
es/full/minify/libraries/typescript 2704571036 ns/iter (± 11233073) 2690046373 ns/iter (± 17613834) 1.01
es/full/minify/libraries/victory 570051814 ns/iter (± 4172431) 561821789 ns/iter (± 3214176) 1.01
es/full/minify/libraries/vue 121694380 ns/iter (± 488264) 121142601 ns/iter (± 596342) 1.00
es/full/codegen/es3 34621 ns/iter (± 101) 34611 ns/iter (± 155) 1.00
es/full/codegen/es5 34512 ns/iter (± 106) 34490 ns/iter (± 94) 1.00
es/full/codegen/es2015 34688 ns/iter (± 96) 34558 ns/iter (± 99) 1.00
es/full/codegen/es2016 34578 ns/iter (± 53) 34530 ns/iter (± 68) 1.00
es/full/codegen/es2017 34639 ns/iter (± 73) 34528 ns/iter (± 119) 1.00
es/full/codegen/es2018 34738 ns/iter (± 118) 34480 ns/iter (± 99) 1.01
es/full/codegen/es2019 34671 ns/iter (± 102) 34588 ns/iter (± 77) 1.00
es/full/codegen/es2020 34608 ns/iter (± 65) 34480 ns/iter (± 90) 1.00
es/full/all/es3 174005852 ns/iter (± 634801) 171860123 ns/iter (± 1198567) 1.01
es/full/all/es5 166339961 ns/iter (± 1331541) 163642772 ns/iter (± 578245) 1.02
es/full/all/es2015 124981157 ns/iter (± 813424) 122833654 ns/iter (± 801031) 1.02
es/full/all/es2016 123843462 ns/iter (± 522785) 122418285 ns/iter (± 412334) 1.01
es/full/all/es2017 122859707 ns/iter (± 440563) 120741763 ns/iter (± 875739) 1.02
es/full/all/es2018 120357280 ns/iter (± 801129) 119972651 ns/iter (± 716064) 1.00
es/full/all/es2019 120187984 ns/iter (± 465182) 118495474 ns/iter (± 651588) 1.01
es/full/all/es2020 115198296 ns/iter (± 593291) 114215061 ns/iter (± 440875) 1.01
es/full/parser 531357 ns/iter (± 2042) 534809 ns/iter (± 5766) 0.99
es/full/base/fixer 19144 ns/iter (± 201) 18903 ns/iter (± 147) 1.01
es/full/base/resolver_and_hygiene 80875 ns/iter (± 168) 79520 ns/iter (± 175) 1.02
serialization of serde 546 ns/iter (± 0) 308 ns/iter (± 0) 1.77
css/minify/libraries/bootstrap 29156888 ns/iter (± 143186) 28409960 ns/iter (± 65541) 1.03
css/visitor/compare/clone 1699687 ns/iter (± 11058) 1633984 ns/iter (± 9916) 1.04
css/visitor/compare/visit_mut_span 1761165 ns/iter (± 7000) 1754083 ns/iter (± 4099) 1.00
css/visitor/compare/visit_mut_span_panic 1909015 ns/iter (± 3822) 1836746 ns/iter (± 6415) 1.04
css/visitor/compare/fold_span 2564797 ns/iter (± 14133) 2570214 ns/iter (± 6436) 1.00
css/visitor/compare/fold_span_panic 2752679 ns/iter (± 9322) 2759716 ns/iter (± 16575) 1.00
css/lexer/bootstrap_5_1_3 4499446 ns/iter (± 1994) 4416649 ns/iter (± 32661) 1.02
css/lexer/foundation_6_7_4 3780724 ns/iter (± 2781) 3740727 ns/iter (± 5217) 1.01
css/lexer/tailwind_3_1_1 723179 ns/iter (± 362) 710022 ns/iter (± 390) 1.02
css/parser/bootstrap_5_1_3 20314611 ns/iter (± 51067) 19751414 ns/iter (± 69651) 1.03
css/parser/foundation_6_7_4 16208541 ns/iter (± 19740) 15752410 ns/iter (± 37963) 1.03
css/parser/tailwind_3_1_1 3060335 ns/iter (± 4772) 3002214 ns/iter (± 6174) 1.02
es/codegen/colors 720183 ns/iter (± 393495) 735808 ns/iter (± 402252) 0.98
es/codegen/large 3137329 ns/iter (± 1690894) 3152898 ns/iter (± 1677144) 1.00
es/codegen/with-parser/colors 44503 ns/iter (± 517) 44299 ns/iter (± 638) 1.00
es/codegen/with-parser/large 486697 ns/iter (± 953) 482700 ns/iter (± 1910) 1.01
es/minify/libraries/antd 1146953133 ns/iter (± 8697952) 1152644614 ns/iter (± 6883997) 1.00
es/minify/libraries/d3 241203137 ns/iter (± 725993) 242789199 ns/iter (± 972114) 0.99
es/minify/libraries/echarts 920553585 ns/iter (± 10305950) 921334564 ns/iter (± 9191529) 1.00
es/minify/libraries/jquery 73797940 ns/iter (± 71959) 74065279 ns/iter (± 78319) 1.00
es/minify/libraries/lodash 88213086 ns/iter (± 252327) 88667624 ns/iter (± 154870) 0.99
es/minify/libraries/moment 43623884 ns/iter (± 128562) 43723898 ns/iter (± 52190) 1.00
es/minify/libraries/react 16067441 ns/iter (± 43466) 16062229 ns/iter (± 18421) 1.00
es/minify/libraries/terser 188357248 ns/iter (± 1070882) 187821423 ns/iter (± 904733) 1.00
es/minify/libraries/three 322057055 ns/iter (± 1214206) 324771504 ns/iter (± 2280139) 0.99
es/minify/libraries/typescript 2287682881 ns/iter (± 13819199) 2296574098 ns/iter (± 10580124) 1.00
es/minify/libraries/victory 478202371 ns/iter (± 5107537) 482510206 ns/iter (± 3598566) 0.99
es/minify/libraries/vue 107526189 ns/iter (± 296868) 107612159 ns/iter (± 238056) 1.00
es/visitor/compare/clone 1982050 ns/iter (± 5230) 1949766 ns/iter (± 4741) 1.02
es/visitor/compare/visit_mut_span 2352052 ns/iter (± 3852) 2292251 ns/iter (± 6869) 1.03
es/visitor/compare/visit_mut_span_panic 2333149 ns/iter (± 3739) 2323437 ns/iter (± 4150) 1.00
es/visitor/compare/fold_span 3409091 ns/iter (± 4792) 3375716 ns/iter (± 6735) 1.01
es/visitor/compare/fold_span_panic 3541000 ns/iter (± 8119) 3513790 ns/iter (± 6668) 1.01
es/lexer/colors 12790 ns/iter (± 55) 12946 ns/iter (± 14) 0.99
es/lexer/angular 6084162 ns/iter (± 4235) 6166301 ns/iter (± 4182) 0.99
es/lexer/backbone 799201 ns/iter (± 2652) 797861 ns/iter (± 1567) 1.00
es/lexer/jquery 4480696 ns/iter (± 17177) 4497938 ns/iter (± 4557) 1.00
es/lexer/jquery mobile 6890157 ns/iter (± 5645) 6927677 ns/iter (± 8505) 0.99
es/lexer/mootools 3544429 ns/iter (± 6762) 3578582 ns/iter (± 4273) 0.99
es/lexer/underscore 663933 ns/iter (± 1147) 666141 ns/iter (± 770) 1.00
es/lexer/three 20970390 ns/iter (± 39672) 21330761 ns/iter (± 11363) 0.98
es/lexer/yui 3844607 ns/iter (± 3095) 3866756 ns/iter (± 2836) 0.99
es/parser/colors 26573 ns/iter (± 63) 26327 ns/iter (± 65) 1.01
es/parser/angular 13437558 ns/iter (± 133275) 13281198 ns/iter (± 67641) 1.01
es/parser/backbone 1983767 ns/iter (± 9564) 1973381 ns/iter (± 9214) 1.01
es/parser/jquery 10814861 ns/iter (± 49798) 10724325 ns/iter (± 53056) 1.01
es/parser/jquery mobile 16535364 ns/iter (± 56741) 16483583 ns/iter (± 96880) 1.00
es/parser/mootools 8340687 ns/iter (± 35216) 8252200 ns/iter (± 15382) 1.01
es/parser/underscore 1706266 ns/iter (± 9318) 1690374 ns/iter (± 8657) 1.01
es/parser/three 47210047 ns/iter (± 331620) 46260399 ns/iter (± 835294) 1.02
es/parser/yui 8208113 ns/iter (± 32654) 8152159 ns/iter (± 24428) 1.01
es/preset-env/usage/builtin_type 136481 ns/iter (± 31706) 137790 ns/iter (± 31848) 0.99
es/preset-env/usage/property 16864 ns/iter (± 77) 17048 ns/iter (± 58) 0.99
es/resolver/typescript 88785633 ns/iter (± 544567) 88342388 ns/iter (± 1317938) 1.01
es/fixer/typescript 64271160 ns/iter (± 453043) 64462290 ns/iter (± 1231440) 1.00
es/hygiene/typescript 133016475 ns/iter (± 769568) 130774877 ns/iter (± 1001081) 1.02
es/resolver_with_hygiene/typescript 243258799 ns/iter (± 1346885) 241057594 ns/iter (± 1001106) 1.01
es/visitor/base-perf/module_clone 59955 ns/iter (± 360) 59554 ns/iter (± 204) 1.01
es/visitor/base-perf/fold_empty 63634 ns/iter (± 229) 63854 ns/iter (± 234) 1.00
es/visitor/base-perf/fold_noop_impl_all 64745 ns/iter (± 392) 63964 ns/iter (± 269) 1.01
es/visitor/base-perf/fold_noop_impl_vec 64953 ns/iter (± 623) 63584 ns/iter (± 203) 1.02
es/visitor/base-perf/boxing_boxed_clone 57 ns/iter (± 0) 57 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 40 ns/iter (± 0) 40 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 109 ns/iter (± 0) 108 ns/iter (± 0) 1.01
es/visitor/base-perf/boxing_unboxed 77 ns/iter (± 0) 78 ns/iter (± 0) 0.99
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2554 ns/iter (± 22) 2582 ns/iter (± 17) 0.99
es/base/parallel/resolver/typescript 4537477085 ns/iter (± 257713081) 3957009740 ns/iter (± 319775054) 1.15
es/base/parallel/hygiene/typescript 1459407061 ns/iter (± 14154142) 1452117457 ns/iter (± 7628308) 1.01
misc/visitors/time-complexity/time 5 134 ns/iter (± 0) 145 ns/iter (± 1) 0.92
misc/visitors/time-complexity/time 10 382 ns/iter (± 6) 412 ns/iter (± 7) 0.93
misc/visitors/time-complexity/time 15 671 ns/iter (± 14) 885 ns/iter (± 9) 0.76
misc/visitors/time-complexity/time 20 1109 ns/iter (± 11) 1325 ns/iter (± 58) 0.84
misc/visitors/time-complexity/time 40 3890 ns/iter (± 13) 4367 ns/iter (± 10) 0.89
misc/visitors/time-complexity/time 60 7597 ns/iter (± 167) 10647 ns/iter (± 6) 0.71
es/full-target/es2016 231486 ns/iter (± 435) 239722 ns/iter (± 638) 0.97
es/full-target/es2017 219344 ns/iter (± 356) 222174 ns/iter (± 1468) 0.99
es/full-target/es2018 207022 ns/iter (± 549) 208647 ns/iter (± 503) 0.99
es2020_nullish_coalescing 69836 ns/iter (± 501) 68334 ns/iter (± 477) 1.02
es2020_optional_chaining 78084 ns/iter (± 313) 76576 ns/iter (± 287) 1.02
es2022_class_properties 116699 ns/iter (± 382) 115790 ns/iter (± 173) 1.01
es2018_object_rest_spread 75223 ns/iter (± 217) 73153 ns/iter (± 362) 1.03
es2019_optional_catch_binding 63782 ns/iter (± 135) 62831 ns/iter (± 133) 1.02
es2017_async_to_generator 63957 ns/iter (± 144) 64597 ns/iter (± 201) 0.99
es2016_exponentiation 68115 ns/iter (± 232) 68111 ns/iter (± 211) 1.00
es2015_arrow 71417 ns/iter (± 290) 70203 ns/iter (± 281) 1.02
es2015_block_scoped_fn 68961 ns/iter (± 273) 67079 ns/iter (± 1139) 1.03
es2015_block_scoping 123893 ns/iter (± 573) 120431 ns/iter (± 652) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.