Skip to content

Commit

Permalink
fix(es/compat): Make stage 3 decorator pass use correct state for inn…
Browse files Browse the repository at this point in the history 
…er classes (#7508)

**Related issue:**

 - Closes #7499.
  • Loading branch information
@kdy1
kdy1 committed Jun 8, 2023
1 parent 37634a7 commit cc4146c
Show file tree
Hide file tree
Showing 6 changed files with 226 additions and 135 deletions.

1 comment on commit cc4146c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: cc4146c Previous: 7f9f0b8 Ratio
es/full/bugs-1 303955 ns/iter (± 2324) 307783 ns/iter (± 7577) 0.99
es/full/minify/libraries/antd 1467484525 ns/iter (± 12067225) 1490980646 ns/iter (± 17109322) 0.98
es/full/minify/libraries/d3 311934217 ns/iter (± 2279178) 315376713 ns/iter (± 5958092) 0.99
es/full/minify/libraries/echarts 1201620404 ns/iter (± 14714019) 1206994815 ns/iter (± 5037923) 1.00
es/full/minify/libraries/jquery 95044278 ns/iter (± 445442) 95047604 ns/iter (± 239309) 1.00
es/full/minify/libraries/lodash 112583075 ns/iter (± 282096) 113142735 ns/iter (± 1357721) 1.00
es/full/minify/libraries/moment 55796479 ns/iter (± 184538) 55839073 ns/iter (± 170007) 1.00
es/full/minify/libraries/react 19913663 ns/iter (± 186646) 19999043 ns/iter (± 37357) 1.00
es/full/minify/libraries/terser 250205455 ns/iter (± 2198087) 246446972 ns/iter (± 710794) 1.02
es/full/minify/libraries/three 452430818 ns/iter (± 3223615) 435833072 ns/iter (± 2456695) 1.04
es/full/minify/libraries/typescript 3009212200 ns/iter (± 35810181) 3003623373 ns/iter (± 9652755) 1.00
es/full/minify/libraries/victory 643910043 ns/iter (± 6962487) 647142461 ns/iter (± 5333664) 1.00
es/full/minify/libraries/vue 135634063 ns/iter (± 332995) 138230877 ns/iter (± 644517) 0.98
es/full/codegen/es3 35988 ns/iter (± 246) 36321 ns/iter (± 120) 0.99
es/full/codegen/es5 36126 ns/iter (± 133) 36282 ns/iter (± 36) 1.00
es/full/codegen/es2015 36088 ns/iter (± 81) 36283 ns/iter (± 65) 0.99
es/full/codegen/es2016 35999 ns/iter (± 74) 36245 ns/iter (± 64) 0.99
es/full/codegen/es2017 36109 ns/iter (± 52) 36309 ns/iter (± 43) 0.99
es/full/codegen/es2018 35933 ns/iter (± 152) 36232 ns/iter (± 84) 0.99
es/full/codegen/es2019 36182 ns/iter (± 113) 36323 ns/iter (± 85) 1.00
es/full/codegen/es2020 36112 ns/iter (± 81) 36286 ns/iter (± 53) 1.00
es/full/all/es3 180025541 ns/iter (± 926230) 179791533 ns/iter (± 719633) 1.00
es/full/all/es5 169749805 ns/iter (± 594731) 171539536 ns/iter (± 886500) 0.99
es/full/all/es2015 126510925 ns/iter (± 586634) 127066027 ns/iter (± 498451) 1.00
es/full/all/es2016 125599591 ns/iter (± 462772) 126586740 ns/iter (± 521394) 0.99
es/full/all/es2017 124701997 ns/iter (± 873902) 125489097 ns/iter (± 708529) 0.99
es/full/all/es2018 122601797 ns/iter (± 454033) 123958117 ns/iter (± 501698) 0.99
es/full/all/es2019 122285845 ns/iter (± 618755) 123461546 ns/iter (± 574127) 0.99
es/full/all/es2020 116097408 ns/iter (± 635344) 118184621 ns/iter (± 317167) 0.98
es/full/parser 514292 ns/iter (± 7108) 517191 ns/iter (± 3961) 0.99
es/full/base/fixer 19248 ns/iter (± 84) 18236 ns/iter (± 128) 1.06
es/full/base/resolver_and_hygiene 95327 ns/iter (± 193) 90877 ns/iter (± 276) 1.05
serialization of serde 313 ns/iter (± 2) 316 ns/iter (± 0) 0.99
css/minify/libraries/bootstrap 30858437 ns/iter (± 121565) 30915808 ns/iter (± 144697) 1.00
css/visitor/compare/clone 2149619 ns/iter (± 10468) 1906383 ns/iter (± 12333) 1.13
css/visitor/compare/visit_mut_span 2276221 ns/iter (± 16431) 2050453 ns/iter (± 6002) 1.11
css/visitor/compare/visit_mut_span_panic 2350754 ns/iter (± 24420) 2128272 ns/iter (± 7926) 1.10
css/visitor/compare/fold_span 2997188 ns/iter (± 18103) 2807297 ns/iter (± 12453) 1.07
css/visitor/compare/fold_span_panic 3181430 ns/iter (± 37217) 3016782 ns/iter (± 11302) 1.05
css/lexer/bootstrap_5_1_3 4808768 ns/iter (± 11285) 4814585 ns/iter (± 2310) 1.00
css/lexer/foundation_6_7_4 4042674 ns/iter (± 4628) 4051902 ns/iter (± 1979) 1.00
css/lexer/tailwind_3_1_1 765232 ns/iter (± 793) 764265 ns/iter (± 278) 1.00
css/parser/bootstrap_5_1_3 20577245 ns/iter (± 84713) 20586787 ns/iter (± 24884) 1.00
css/parser/foundation_6_7_4 16541775 ns/iter (± 40042) 16577051 ns/iter (± 69764) 1.00
css/parser/tailwind_3_1_1 3185031 ns/iter (± 3527) 3199868 ns/iter (± 2839) 1.00
es/codegen/colors 738784 ns/iter (± 400782) 740624 ns/iter (± 401173) 1.00
es/codegen/large 3110146 ns/iter (± 1641323) 3120128 ns/iter (± 1635030) 1.00
es/codegen/with-parser/colors 48859 ns/iter (± 331) 48887 ns/iter (± 243) 1.00
es/codegen/with-parser/large 504321 ns/iter (± 691) 521112 ns/iter (± 3305) 0.97
es/minify/libraries/antd 1302678354 ns/iter (± 14998550) 1323790696 ns/iter (± 13689427) 0.98
es/minify/libraries/d3 277902834 ns/iter (± 1178392) 281493184 ns/iter (± 1478748) 0.99
es/minify/libraries/echarts 1047513178 ns/iter (± 7555550) 1056905603 ns/iter (± 7906080) 0.99
es/minify/libraries/jquery 83333834 ns/iter (± 412914) 83551073 ns/iter (± 222946) 1.00
es/minify/libraries/lodash 101865817 ns/iter (± 275935) 102003795 ns/iter (± 212712) 1.00
es/minify/libraries/moment 49219606 ns/iter (± 97923) 49159782 ns/iter (± 97254) 1.00
es/minify/libraries/react 17943495 ns/iter (± 49027) 17846904 ns/iter (± 49528) 1.01
es/minify/libraries/terser 211292198 ns/iter (± 1033950) 213567474 ns/iter (± 840212) 0.99
es/minify/libraries/three 367812815 ns/iter (± 4047044) 372482774 ns/iter (± 1924747) 0.99
es/minify/libraries/typescript 2574660922 ns/iter (± 13227312) 2613162969 ns/iter (± 10441432) 0.99
es/minify/libraries/victory 570946996 ns/iter (± 14268620) 551217447 ns/iter (± 4675303) 1.04
es/minify/libraries/vue 122616641 ns/iter (± 451207) 123457896 ns/iter (± 738900) 0.99
es/visitor/compare/clone 2067940 ns/iter (± 16496) 2079708 ns/iter (± 9511) 0.99
es/visitor/compare/visit_mut_span 2407046 ns/iter (± 6919) 2409416 ns/iter (± 3513) 1.00
es/visitor/compare/visit_mut_span_panic 2444920 ns/iter (± 12299) 2449959 ns/iter (± 2954) 1.00
es/visitor/compare/fold_span 3486198 ns/iter (± 5068) 3488994 ns/iter (± 6413) 1.00
es/visitor/compare/fold_span_panic 3614200 ns/iter (± 5515) 3616746 ns/iter (± 13140) 1.00
es/lexer/colors 13521 ns/iter (± 44) 13087 ns/iter (± 59) 1.03
es/lexer/angular 6253368 ns/iter (± 21015) 6253308 ns/iter (± 10990) 1.00
es/lexer/backbone 835776 ns/iter (± 3141) 818490 ns/iter (± 1710) 1.02
es/lexer/jquery 4650228 ns/iter (± 6084) 4619606 ns/iter (± 3578) 1.01
es/lexer/jquery mobile 7129219 ns/iter (± 13568) 7082083 ns/iter (± 4298) 1.01
es/lexer/mootools 3687183 ns/iter (± 7511) 3654247 ns/iter (± 4146) 1.01
es/lexer/underscore 693761 ns/iter (± 576) 693703 ns/iter (± 859) 1.00
es/lexer/three 21959742 ns/iter (± 31284) 21803955 ns/iter (± 34962) 1.01
es/lexer/yui 4141302 ns/iter (± 3176) 4054871 ns/iter (± 1919) 1.02
es/parser/colors 29295 ns/iter (± 76) 29370 ns/iter (± 93) 1.00
es/parser/angular 14734350 ns/iter (± 97307) 14459825 ns/iter (± 592043) 1.02
es/parser/backbone 2179528 ns/iter (± 7750) 2138656 ns/iter (± 11336) 1.02
es/parser/jquery 11891230 ns/iter (± 58421) 11691667 ns/iter (± 35685) 1.02
es/parser/jquery mobile 18009218 ns/iter (± 108989) 17854597 ns/iter (± 46470) 1.01
es/parser/mootools 9084464 ns/iter (± 30963) 8932900 ns/iter (± 15419) 1.02
es/parser/underscore 1884593 ns/iter (± 9354) 1866976 ns/iter (± 8857) 1.01
es/parser/three 50626049 ns/iter (± 313655) 49498644 ns/iter (± 205186) 1.02
es/parser/yui 9098435 ns/iter (± 26081) 8972468 ns/iter (± 29532) 1.01
es/preset-env/usage/builtin_type 146647 ns/iter (± 32394) 145339 ns/iter (± 31175) 1.01
es/preset-env/usage/property 20782 ns/iter (± 60) 20271 ns/iter (± 54) 1.03
es/resolver/typescript 95208458 ns/iter (± 1831160) 92968979 ns/iter (± 1396577) 1.02
es/fixer/typescript 66892246 ns/iter (± 1387934) 65904892 ns/iter (± 532711) 1.01
es/hygiene/typescript 143957777 ns/iter (± 576859) 141676734 ns/iter (± 1028313) 1.02
es/resolver_with_hygiene/typescript 307328859 ns/iter (± 2110042) 304889704 ns/iter (± 1768070) 1.01
es/visitor/base-perf/module_clone 62379 ns/iter (± 299) 62496 ns/iter (± 256) 1.00
es/visitor/base-perf/fold_empty 65515 ns/iter (± 350) 65583 ns/iter (± 360) 1.00
es/visitor/base-perf/fold_noop_impl_all 65634 ns/iter (± 242) 66216 ns/iter (± 201) 0.99
es/visitor/base-perf/fold_noop_impl_vec 66487 ns/iter (± 345) 66150 ns/iter (± 253) 1.01
es/visitor/base-perf/boxing_boxed_clone 57 ns/iter (± 0) 61 ns/iter (± 0) 0.93
es/visitor/base-perf/boxing_unboxed_clone 41 ns/iter (± 0) 41 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 113 ns/iter (± 0) 119 ns/iter (± 0) 0.95
es/visitor/base-perf/boxing_unboxed 79 ns/iter (± 0) 81 ns/iter (± 0) 0.98
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2678 ns/iter (± 12) 2680 ns/iter (± 16) 1.00
es/base/parallel/resolver/typescript 4716615597 ns/iter (± 244861078) 4640573954 ns/iter (± 287384549) 1.02
es/base/parallel/hygiene/typescript 1550703889 ns/iter (± 21564894) 1570066256 ns/iter (± 30585886) 0.99
misc/visitors/time-complexity/time 5 104 ns/iter (± 0) 104 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 267 ns/iter (± 0) 267 ns/iter (± 0) 1
misc/visitors/time-complexity/time 15 503 ns/iter (± 5) 504 ns/iter (± 39) 1.00
misc/visitors/time-complexity/time 20 879 ns/iter (± 55) 1060 ns/iter (± 2) 0.83
misc/visitors/time-complexity/time 40 3541 ns/iter (± 13) 3551 ns/iter (± 204) 1.00
misc/visitors/time-complexity/time 60 7338 ns/iter (± 20) 7538 ns/iter (± 36) 0.97
es/full-target/es2016 241941 ns/iter (± 696) 240264 ns/iter (± 761) 1.01
es/full-target/es2017 227845 ns/iter (± 594) 226490 ns/iter (± 479) 1.01
es/full-target/es2018 216982 ns/iter (± 601) 215160 ns/iter (± 612) 1.01
es2020_nullish_coalescing 73808 ns/iter (± 465) 73550 ns/iter (± 314) 1.00
es2020_optional_chaining 103209 ns/iter (± 410) 103634 ns/iter (± 748) 1.00
es2022_class_properties 122012 ns/iter (± 338) 121562 ns/iter (± 564) 1.00
es2018_object_rest_spread 77169 ns/iter (± 176) 77083 ns/iter (± 326) 1.00
es2019_optional_catch_binding 65559 ns/iter (± 201) 65485 ns/iter (± 137) 1.00
es2017_async_to_generator 66097 ns/iter (± 163) 66259 ns/iter (± 153) 1.00
es2016_exponentiation 71429 ns/iter (± 166) 71392 ns/iter (± 257) 1.00
es2015_arrow 74228 ns/iter (± 381) 73853 ns/iter (± 307) 1.01
es2015_block_scoped_fn 70354 ns/iter (± 208) 70233 ns/iter (± 341) 1.00
es2015_block_scoping 134022 ns/iter (± 387) 134162 ns/iter (± 661) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.