fix(es/parser): Allow parentheses in assignment target (#4105)

crates/swc/tests/fixture/issue-2834/input/.swcrc

@@ -0,0 +1,5 @@
+{
+    "jsc": {
+        "target": "es2022"
+    }
+}

crates/swc/tests/fixture/issue-2834/input/index.js

@@ -0,0 +1,9 @@
+[(a)] = arr;
+[((a.b))] = arr;
+[...(a.b)] = arr;
+({ a: (b) } = obj);
+({ a: (b.c) } = obj);
+({ ...((a["b"])) } = obj);
+for ([(a)] of arr) {}
+for ([{ a: ((b)) }] of arr) {}
+for ([{ ...((a.b)) }] of arr) {}

crates/swc/tests/fixture/issue-2834/output/index.js

@@ -0,0 +1,9 @@
+[a] = arr;
+[a.b] = arr;
+[...a.b] = arr;
+({ a: b  } = obj);
+({ a: b.c  } = obj);
+({ ...a["b"] } = obj);
+for ([a] of arr){}
+for ([{ a: b  }] of arr){}
+for ([{ ...a.b }] of arr){}

crates/swc_ecma_parser/src/parser/pat.rs

@@ -563,6 +563,7 @@ impl<'a, I: Tokens> Parser<I> {
                 | Expr::Ident(..)
                 | Expr::Fn(..)
                 | Expr::Class(..)
+                | Expr::Paren(..)
                 | Expr::Tpl(..) => {
                     if !expr.is_valid_simple_assignment_target(self.ctx().strict) {
                         self.emit_err(span, SyntaxError::NotSimpleAssign)
@@ -651,9 +652,8 @@ impl<'a, I: Tokens> Parser<I> {
                                     Ok(ObjectPatProp::Rest(RestPat {
                                         span,
                                         dot3_token,
-                                        // FIXME: is BindingPat correct?
                                         arg: Box::new(
-                                            self.reparse_expr_as_pat(PatType::BindingPat, expr)?,
+                                            self.reparse_expr_as_pat(pat_ty.element(), expr)?,
                                         ),
                                         type_ann: None,
                                     }))

crates/swc_ecma_parser/tests/pat.rs

@@ -0,0 +1,80 @@
+use std::{
+    fs::read_to_string,
+    path::{Path, PathBuf},
+};
+
+use pretty_assertions::assert_eq;
+use swc_common::{errors::Handler, sync::Lrc, SourceMap};
+use swc_ecma_ast::*;
+use swc_ecma_parser::{lexer::Lexer, PResult, Parser, StringInput};
+use swc_ecma_visit::{Fold, FoldWith};
+use testing::{run_test, StdErr};
+
+fn parse_module(cm: Lrc<SourceMap>, handler: &Handler, file_name: &Path) -> Result<Module, ()> {
+    with_parser(cm, handler, file_name, |p| p.parse_module())
+}
+
+fn with_parser<F, Ret>(
+    cm: Lrc<SourceMap>,
+    handler: &Handler,
+    file_name: &Path,
+    f: F,
+) -> Result<Ret, ()>
+where
+    F: FnOnce(&mut Parser<Lexer<StringInput<'_>>>) -> PResult<Ret>,
+{
+    let fm = cm
+        .load_file(file_name)
+        .unwrap_or_else(|e| panic!("failed to load {}: {}", file_name.display(), e));
+
+    let mut p = Parser::new(
+        ::swc_ecma_parser::Syntax::Es(::swc_ecma_parser::EsConfig {
+            jsx: true,
+            ..Default::default()
+        }),
+        (&*fm).into(),
+        None,
+    );
+
+    let res = f(&mut p).map_err(|e| e.into_diagnostic(handler).emit());
+
+    for e in p.take_errors() {
+        e.into_diagnostic(handler).emit();
+    }
+
+    res
+}
+
+#[cfg(feature = "verify")]
+#[testing::fixture("tests/pat/errors/**/*.js")]
+fn error(entry: PathBuf) {
+    let input = read_to_string(&entry).unwrap();
+
+    eprintln!(
+        "\n\n========== Running error reporting test \nSource:\n{}\n",
+        input
+    );
+
+    let err = run_test(false, |cm, handler| {
+        if false {
+            // Type annotation
+            return Ok(());
+        }
+
+        // Parse source
+        let _ = parse_module(cm, handler, &entry);
+        if !handler.has_errors() {
+            panic!("should emit error, but parsed without error")
+        }
+
+        Err(())
+    })
+    .expect_err("should fail, but parsed as");
+
+    if err
+        .compare_to_file(format!("{}.stderr", entry.display()))
+        .is_err()
+    {
+        panic!()
+    }
+}

crates/swc_ecma_parser/tests/pat/errors/issue-2834/input.js

@@ -0,0 +1,3 @@
+([(a)]) => {};
+({ a: (b) }) => {};
+for (const [(a)] of arr) {}

crates/swc_ecma_parser/tests/pat/errors/issue-2834/input.js.stderr

@@ -0,0 +1,18 @@
+
+  x Unexpected token `(`. Expected yield, an identifier, [ or {
+   ,-[$DIR/tests/pat/errors/issue-2834/input.js:3:1]
+ 3 | for (const [(a)] of arr) {}
+   :             ^
+   `----
+
+  x Not a pattern
+   ,-[$DIR/tests/pat/errors/issue-2834/input.js:1:1]
+ 1 | ([(a)]) => {};
+   :   ^^^
+   `----
+
+  x Not a pattern
+   ,-[$DIR/tests/pat/errors/issue-2834/input.js:2:1]
+ 2 | ({ a: (b) }) => {};
+   :       ^^^
+   `----

crates/swc_ecma_parser/tests/test262-error-references/fail/50a060984b757dc1.js.stderr

@@ -1,5 +1,5 @@
 
-  x Not a pattern
+  x Cannot assign to this
    ,-[$DIR/tests/test262-parser/fail/50a060984b757dc1.js:1:1]
  1 | ({a:(b = 0)} = 1)
    :     ^^^^^^^

crates/swc_ecma_parser/tests/test262-error-references/fail/8bf8438d0a686b4e.js.stderr

@@ -1,5 +1,5 @@
 
-  x Not a pattern
+  x Cannot assign to this
    ,-[$DIR/tests/test262-parser/fail/8bf8438d0a686b4e.js:1:1]
  1 | [a, ...(b = c)] = 0
    :        ^^^^^^^

crates/swc_ecma_parser/tests/test262-error-references/fail/90cd97db35a1a503.js.stderr

@@ -1,5 +1,5 @@
 
-  x Not a pattern
+  x Cannot assign to this
    ,-[$DIR/tests/test262-parser/fail/90cd97db35a1a503.js:1:1]
  1 | ({a: (b = 0)} = {})
    :      ^^^^^^^

crates/swc_ecma_parser/tests/test262-error-references/fail/db41a80ccf646002.js.stderr

@@ -1,5 +1,5 @@
 
-  x Not a pattern
+  x Cannot assign to this
    ,-[$DIR/tests/test262-parser/fail/db41a80ccf646002.js:1:1]
  1 | [(a = 0)] = 1
    :  ^^^^^^^

crates/swc_ecma_parser/tests/test262-error-references/fail/e4963d9605864d9a.js.stderr

@@ -5,7 +5,7 @@
    :                ^
    `----
 
-  x Not a pattern
+  x Cannot assign to this
    ,-[$DIR/tests/test262-parser/fail/e4963d9605864d9a.js:1:1]
  1 | ([(a = b)] = []
    :   ^^^^^^^

crates/swc_ecma_parser/tests/tsc/restPropertyWithBindingPattern.json

@@ -120,11 +120,20 @@
                   "ctxt": 0
                 },
                 "argument": {
-                  "type": "Invalid",
+                  "type": "ParenthesisExpression",
                   "span": {
                     "start": 21,
                     "end": 25,
                     "ctxt": 0
+                  },
+                  "expression": {
+                    "type": "ObjectExpression",
+                    "span": {
+                      "start": 22,
+                      "end": 24,
+                      "ctxt": 0
+                    },
+                    "properties": []
                   }
                 },
                 "typeAnnotation": null
@@ -259,11 +268,20 @@
                   "ctxt": 0
                 },
                 "argument": {
-                  "type": "Invalid",
+                  "type": "ParenthesisExpression",
                   "span": {
                     "start": 55,
                     "end": 59,
                     "ctxt": 0
+                  },
+                  "expression": {
+                    "type": "ArrayExpression",
+                    "span": {
+                      "start": 56,
+                      "end": 58,
+                      "ctxt": 0
+                    },
+                    "elements": []
                   }
                 },
                 "typeAnnotation": null