chore(ci): Fix publish build on Windows (#4970)

.github/workflows/publish-node.yml

@@ -5,7 +5,6 @@ env:
   APP_NAME: swc
   MACOSX_DEPLOYMENT_TARGET: "10.13"
   CARGO_INCREMENTAL: 0
-  CARGO_PROFILE_RELEASE_LTO: "fat"
   CI: "1"
 
 on:
@@ -39,6 +38,7 @@ jobs:
             target: x86_64-pc-windows-msvc
           - host: windows-latest
             build: |
+              export CARGO_PROFILE_RELEASE_LTO=false
               cargo build -p swc_cli --release --target i686-pc-windows-msvc
               cp target/i686-pc-windows-msvc/release/swc .
               yarn build --target i686-pc-windows-msvc --cargo-flags="--no-default-features" --features swc_v1
@@ -56,9 +56,11 @@ jobs:
               strip swc.linux-x64-gnu.node
           - host: ubuntu-latest
             target: x86_64-unknown-linux-musl
+            # musl build is slow, let's disable the LTO
             docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
             build: >-
               set -e &&
+              export CARGO_PROFILE_RELEASE_LTO=false &&
               RUSTFLAGS='-C target-feature=+sse2 -Z new-llvm-pass-manager=no' cargo build -p swc_cli --release --features plugin &&
               rm -rf target/release/.cargo-lock &&
               cp target/release/swc . && chmod +x ./swc &&

crates/ast_node/src/lib.rs

@@ -199,6 +199,7 @@ pub fn ast_node(
             };
 
             item.quote_with(smart_quote!(Vars { input, clone }, {
+                #[allow(clippy::derive_partial_eq_without_eq)]
                 #[derive(
                     ::swc_common::FromVariant,
                     ::swc_common::Spanned,
@@ -257,6 +258,7 @@ pub fn ast_node(
 
             let mut quote =
                 item.quote_with(smart_quote!(Vars { input, serde_tag, serde_rename }, {
+                    #[allow(clippy::derive_partial_eq_without_eq)]
                     #[derive(::swc_common::Spanned, Clone, Debug, PartialEq)]
                     #[derive(::serde::Serialize, ::serde::Deserialize)]
                     #[cfg_attr(

crates/preset_env_base/src/lib.rs

@@ -73,7 +73,7 @@ impl BrowserData<Option<Version>> {
             let browser = dist.name();
             let browser = remap(browser);
             let version = dist.version();
-            match &*browser {
+            match browser {
                 "and_qq" | "and_uc" | "baidu" | "bb" | "kaios" | "op_mini" => continue,
 
                 _ => {}

crates/swc/src/config/mod.rs

@@ -1527,7 +1527,7 @@ impl GlobalPassOption {
                             cm,
                             handler,
                             env::vars()
-                                .filter(|(k, _)| env_list.contains(&*k))
+                                .filter(|(k, _)| env_list.contains(k))
                                 .map(|(k, v)| (k.into(), v.into())),
                             true,
                         );

crates/swc_bundler/src/bundler/finalize.rs

@@ -89,12 +89,8 @@ where
                                     )
                                     .into();
                                 }
-                                return format!(
-                                    "{}-{}",
-                                    path.file_stem().unwrap().to_string_lossy(),
-                                    hash,
-                                )
-                                .into();
+                                format!("{}-{}", path.file_stem().unwrap().to_string_lossy(), hash,)
+                                    .into()
                             })
                             .expect("javascript file should have name");
                         new_name.pop();
@@ -403,7 +399,7 @@ where
                 .as_os_str()
                 .to_string_lossy();
             let base = RelativePath::new(&*base);
-            let v = base.relative(&*v);
+            let v = base.relative(v);
             let value = v.as_str();
             return ImportDecl {
                 src: Str {

crates/swc_common/src/comments.rs

@@ -518,7 +518,7 @@ impl SingleThreadedComments {
         F: FnOnce(&[Comment]) -> Ret,
     {
         if let Some(comments) = self.leading.borrow().get(&pos) {
-            op(&*comments)
+            op(comments)
         } else {
             op(&[])
         }
@@ -529,7 +529,7 @@ impl SingleThreadedComments {
         F: FnOnce(&[Comment]) -> Ret,
     {
         if let Some(comments) = self.trailing.borrow().get(&pos) {
-            op(&*comments)
+            op(comments)
         } else {
             op(&[])
         }

crates/swc_common/src/pos.rs

@@ -93,17 +93,17 @@ where
     S: ?Sized + Spanned,
 {
     fn span(&self) -> Span {
-        <S as Spanned>::span(&*self)
+        <S as Spanned>::span(self)
     }
 
     #[inline]
     fn span_lo(&self) -> BytePos {
-        <S as Spanned>::span_lo(&*self)
+        <S as Spanned>::span_lo(self)
     }
 
     #[inline]
     fn span_hi(&self) -> BytePos {
-        <S as Spanned>::span_hi(&*self)
+        <S as Spanned>::span_hi(self)
     }
 }
 
@@ -112,17 +112,17 @@ where
     S: ?Sized + Spanned,
 {
     fn span(&self) -> Span {
-        <S as Spanned>::span(&*self)
+        <S as Spanned>::span(self)
     }
 
     #[inline]
     fn span_lo(&self) -> BytePos {
-        <S as Spanned>::span_lo(&*self)
+        <S as Spanned>::span_lo(self)
     }
 
     #[inline]
     fn span_hi(&self) -> BytePos {
-        <S as Spanned>::span_hi(&*self)
+        <S as Spanned>::span_hi(self)
     }
 }
 
@@ -131,17 +131,17 @@ where
     S: ?Sized + Spanned,
 {
     fn span(&self) -> Span {
-        <S as Spanned>::span(&*self)
+        <S as Spanned>::span(self)
     }
 
     #[inline]
     fn span_lo(&self) -> BytePos {
-        <S as Spanned>::span_lo(&*self)
+        <S as Spanned>::span_lo(self)
     }
 
     #[inline]
     fn span_hi(&self) -> BytePos {
-        <S as Spanned>::span_hi(&*self)
+        <S as Spanned>::span_hi(self)
     }
 }
 

crates/swc_common/tests/ast_serde.rs

@@ -2,19 +2,19 @@ use serde_json::from_str;
 use swc_common::ast_serde;
 
 #[ast_serde]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum Ambiguous {
     #[tag("A")]
     A(A),
     #[tag("B")]
     B(B),
 }
 #[ast_serde("B")]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct A {}
 
 #[ast_serde("B")]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct B {}
 
 #[test]

crates/swc_common/tests/attr_interop.rs

@@ -13,7 +13,7 @@ pub struct Class {
 #[ast_node("Tuple")]
 pub struct Tuple(#[span] HasSpan, usize, usize);
 
-#[derive(Debug, Clone, PartialEq, Spanned, Serialize, Deserialize)]
+#[derive(Debug, Clone, PartialEq, Eq, Spanned, Serialize, Deserialize)]
 #[cfg_attr(
     feature = "rkyv",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)

crates/swc_css_codegen/src/emit.rs

@@ -46,7 +46,7 @@ where
     #[inline]
     fn emit(&mut self, node: &Option<T>) -> Result {
         match node {
-            Some(node) => self.emit(&*node),
+            Some(node) => self.emit(node),
             None => Ok(()),
         }
     }

crates/swc_css_lints/src/rules/font_family_no_duplicate_names.rs

@@ -50,7 +50,7 @@ impl FontFamilyNoDuplicateNames {
                 ComponentValue::Ident(Ident { value, span, .. }) => {
                     if let Some((mut identifier, last_span)) = last_identifier {
                         identifier.push(' ');
-                        identifier.push_str(&*value);
+                        identifier.push_str(value);
                         (fonts, Some((identifier, last_span.with_hi(span.hi()))))
                     } else {
                         (fonts, Some((value.to_string(), *span)))

crates/swc_css_parser/src/error.rs

@@ -7,7 +7,7 @@ use swc_common::{
 };
 
 /// Size is same as a size of a pointer.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub struct Error {
     inner: Box<(Span, ErrorKind)>,
 }
@@ -68,7 +68,7 @@ impl Error {
     }
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 #[non_exhaustive]
 pub enum ErrorKind {
     Eof,

crates/swc_css_parser/src/parser/at_rule.rs

@@ -631,9 +631,8 @@ where
                                 block_contents_grammar: BlockContentsGrammar::NoGrammar,
                                 ..self.ctx
                             };
-                            let block = self.with_ctx(ctx).parse_as::<SimpleBlock>()?;
 
-                            block
+                            self.with_ctx(ctx).parse_as::<SimpleBlock>()?
                         }
                     };
 

crates/swc_css_prefixer/src/prefixer.rs

@@ -232,8 +232,8 @@ impl VisitMut for LinearGradientFunctionReplacerOnLegacyVariant<'_> {
                             })),
                         ) => {
                             if let (Some(new_first_direction), Some(new_second_direction)) = (
-                                get_old_direction(&*first_value),
-                                get_old_direction(&*second_value),
+                                get_old_direction(first_value),
+                                get_old_direction(second_value),
                             ) {
                                 let new_value = vec![
                                     ComponentValue::Ident(Ident {
@@ -252,7 +252,7 @@ impl VisitMut for LinearGradientFunctionReplacerOnLegacyVariant<'_> {
                             }
                         }
                         (Some(ComponentValue::Ident(Ident { value, span, .. })), Some(_)) => {
-                            if let Some(new_direction) = get_old_direction(&*value) {
+                            if let Some(new_direction) = get_old_direction(value) {
                                 let new_value = vec![ComponentValue::Ident(Ident {
                                     span: *span,
                                     value: new_direction.into(),

crates/swc_ecma_codegen/src/lib.rs

@@ -95,7 +95,7 @@ where
 
         if let Some(ref shebang) = node.shebang {
             punct!("#!");
-            self.wr.write_str_lit(DUMMY_SP, &*shebang)?;
+            self.wr.write_str_lit(DUMMY_SP, shebang)?;
             self.wr.write_line()?;
         }
         for stmt in &node.body {
@@ -113,7 +113,7 @@ where
 
         if let Some(ref shebang) = node.shebang {
             punct!("#!");
-            self.wr.write_str_lit(DUMMY_SP, &*shebang)?;
+            self.wr.write_str_lit(DUMMY_SP, shebang)?;
             self.wr.write_line()?;
         }
         for stmt in &node.body {

crates/swc_ecma_lints/src/rules/no_alert.rs

@@ -89,7 +89,7 @@ impl NoAlert {
 
     fn check(&self, call_span: Span, obj: &Option<JsWord>, prop: &JsWord) {
         if let Some(obj) = obj {
-            let obj_name: &str = &*obj;
+            let obj_name: &str = obj;
 
             if self.pass_call_on_global_this && obj_name == GLOBAL_THIS_PROP {
                 return;
@@ -100,7 +100,7 @@ impl NoAlert {
             }
         }
 
-        let fn_name: &str = &*prop;
+        let fn_name: &str = prop;
 
         if FN_NAMES.contains(&fn_name) {
             self.emit_report(call_span, fn_name);

crates/swc_ecma_lints/src/rules/no_console.rs

@@ -75,7 +75,7 @@ impl Visit for NoConsole {
         if let Expr::Ident(ident) = member.obj.as_ref() {
             match &member.prop {
                 MemberProp::Ident(Ident { sym, .. }) => {
-                    self.check(member.span, ident, &*sym);
+                    self.check(member.span, ident, sym);
                 }
                 MemberProp::Computed(ComputedPropName { expr, .. }) => {
                     if let Expr::Lit(Lit::Str(Str { value, .. })) = expr.as_ref() {

crates/swc_ecma_lints/src/rules/no_loop_func.rs

@@ -56,7 +56,7 @@ impl NoLoopFunc {
         let mut names = self
             .current_fn_unsafe_vars
             .iter()
-            .map(|js_word| (&*js_word) as &str)
+            .map(|js_word| js_word as &str)
             .collect::<Vec<&str>>();
 
         let message = if names.len() == 1 {

crates/swc_ecma_lints/src/rules/no_throw_literal.rs

@@ -95,7 +95,7 @@ impl NoThrowLiteral {
         }
 
         if let Expr::Ident(Ident { sym, .. }) = arg {
-            if &*sym == "undefined" {
+            if sym == "undefined" {
                 self.emit_report(throw_stmt.span, NO_THROW_UNDEFINED);
             }
         }

crates/swc_ecma_lints/src/rules/prefer_regex_literals.rs

@@ -213,7 +213,7 @@ impl Visit for PreferRegexLiterals {
             }
             MemberProp::Computed(comp) => {
                 if let Expr::Lit(Lit::Str(Str { value, .. })) = comp.expr.as_ref() {
-                    self.check(&*value);
+                    self.check(value);
                 }
             }
             _ => {}

crates/swc_ecma_lints/src/rules/quotes.rs

@@ -87,14 +87,14 @@ impl Quotes {
 
         match (&self.prefer, &found_quote_type) {
             (QuotesType::Double, QuotesType::Single) => {
-                if self.avoid_escape && self.is_mirroring_escape(&*value) {
+                if self.avoid_escape && self.is_mirroring_escape(value) {
                     return;
                 }
 
                 self.emit_report(*span);
             }
             (QuotesType::Single, QuotesType::Double) => {
-                if self.avoid_escape && self.is_mirroring_escape(&*value) {
+                if self.avoid_escape && self.is_mirroring_escape(value) {
                     return;
                 }
 
@@ -105,7 +105,7 @@ impl Quotes {
                     return;
                 }
 
-                if self.avoid_escape && self.is_mirroring_escape(&*value) {
+                if self.avoid_escape && self.is_mirroring_escape(value) {
                     return;
                 }
 
@@ -153,7 +153,7 @@ impl Visit for Quotes {
 
     fn visit_expr_stmt(&mut self, expr_stmt: &ExprStmt) {
         if let Expr::Lit(Lit::Str(Str { value, .. })) = expr_stmt.expr.as_ref() {
-            let value: &str = &*value;
+            let value: &str = value;
 
             if DIRECTIVES.contains(&value) {
                 return;

crates/swc_ecma_lints/src/rules/use_is_nan.rs

@@ -106,7 +106,7 @@ impl UseIsNan {
                             }
                             MemberProp::Computed(ComputedPropName { expr, .. }) => {
                                 if let Expr::Lit(Lit::Str(Str { value, .. })) = expr.as_ref() {
-                                    if &*value == "NaN" {
+                                    if value == "NaN" {
                                         self.emit_report(expr_span.unwrap_or(*span), label_msg);
                                     }
                                 }

crates/swc_ecma_lints/src/rules/utils.rs

@@ -31,7 +31,7 @@ impl QuotesType {
 
 pub fn resolve_string_quote_type(lit_str: &Str) -> Option<QuotesType> {
     lit_str.raw.as_ref().and_then(|raw| {
-        let byte = (&*raw).as_bytes()[0];
+        let byte = raw.as_bytes()[0];
 
         match byte {
             b'\'' => Some(QuotesType::Single),