Skip to content

Commit

Permalink
buiild(bindings/wasm): Fix Wasm build (#7666)
Browse files Browse the repository at this point in the history
**Related issue:**

 - Closes #7663.
  • Loading branch information
kdy1 committed Jul 18, 2023
1 parent 7c12060 commit dc5135f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/publish-wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,17 @@ env:
CI: "1"

on:
create:
push:
branches:
- ci
- ci*
- main
tags:
- v*

jobs:
publish-node:
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
if: ${{ startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/ci') }}

name: Build - wasm for node.js
runs-on: ubuntu-latest
Expand Down Expand Up @@ -45,6 +49,7 @@ jobs:
sed -i -e 's/"name": "@swc\/binding_core_wasm"/"name": "@swc\/wasm"/g' pkg/package.json
- name: Publish
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
run: |
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
(cd bindings/binding_core_wasm/pkg && npm publish --access public)
Expand All @@ -53,7 +58,7 @@ jobs:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

publish-web:
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
if: ${{ startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/ci') }}

name: Build - wasm for web
runs-on: ubuntu-latest
Expand Down Expand Up @@ -86,6 +91,7 @@ jobs:
sed -i -e 's/"name": "@swc\/binding_core_wasm"/"name": "@swc\/wasm-web"/g' pkg/package.json
- name: Publish
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
run: |
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
(cd bindings/binding_core_wasm/pkg && npm publish --access public)
Expand Down
2 changes: 1 addition & 1 deletion bindings/binding_core_wasm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ plugin = []

[dependencies]
anyhow = "1.0.66"
getrandom = { version = "0.2.10" }
getrandom = { version = "0.2.10", features = ["js"] }
serde = { version = "1", features = ["derive"] }
serde-wasm-bindgen = "0.4.5"
swc_core = { version = "0.79.15", features = [
Expand Down

1 comment on commit dc5135f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dc5135f Previous: 6be1f70 Ratio
es/full/bugs-1 281977 ns/iter (± 6075) 289969 ns/iter (± 9838) 0.97
es/full/minify/libraries/antd 1302460793 ns/iter (± 11994149) 1304036338 ns/iter (± 15109339) 1.00
es/full/minify/libraries/d3 278084716 ns/iter (± 3613109) 276007898 ns/iter (± 2264141) 1.01
es/full/minify/libraries/echarts 1055356961 ns/iter (± 9848592) 1052211908 ns/iter (± 11131022) 1.00
es/full/minify/libraries/jquery 84775231 ns/iter (± 194041) 83767153 ns/iter (± 181557) 1.01
es/full/minify/libraries/lodash 98360936 ns/iter (± 309436) 98274818 ns/iter (± 352768) 1.00
es/full/minify/libraries/moment 49836590 ns/iter (± 595142) 49355773 ns/iter (± 180144) 1.01
es/full/minify/libraries/react 18035497 ns/iter (± 19549) 17872540 ns/iter (± 53555) 1.01
es/full/minify/libraries/terser 219369946 ns/iter (± 595098) 217334673 ns/iter (± 2070634) 1.01
es/full/minify/libraries/three 385419131 ns/iter (± 7751326) 383465690 ns/iter (± 2953723) 1.01
es/full/minify/libraries/typescript 2654517031 ns/iter (± 8992397) 2673688482 ns/iter (± 14047398) 0.99
es/full/minify/libraries/victory 561783431 ns/iter (± 5009658) 563905149 ns/iter (± 9983710) 1.00
es/full/minify/libraries/vue 120780400 ns/iter (± 381262) 119059524 ns/iter (± 1838031) 1.01
es/full/codegen/es3 34291 ns/iter (± 173) 35276 ns/iter (± 73) 0.97
es/full/codegen/es5 34214 ns/iter (± 76) 35507 ns/iter (± 87) 0.96
es/full/codegen/es2015 34145 ns/iter (± 79) 35440 ns/iter (± 49) 0.96
es/full/codegen/es2016 34221 ns/iter (± 55) 35499 ns/iter (± 96) 0.96
es/full/codegen/es2017 34254 ns/iter (± 53) 35471 ns/iter (± 108) 0.97
es/full/codegen/es2018 34236 ns/iter (± 165) 35520 ns/iter (± 162) 0.96
es/full/codegen/es2019 34188 ns/iter (± 58) 35466 ns/iter (± 119) 0.96
es/full/codegen/es2020 34243 ns/iter (± 70) 35438 ns/iter (± 112) 0.97
es/full/all/es3 173177968 ns/iter (± 1024873) 172420391 ns/iter (± 711866) 1.00
es/full/all/es5 165499022 ns/iter (± 544741) 164853198 ns/iter (± 732659) 1.00
es/full/all/es2015 123190913 ns/iter (± 628578) 123978029 ns/iter (± 632558) 0.99
es/full/all/es2016 122109104 ns/iter (± 835904) 123391653 ns/iter (± 468748) 0.99
es/full/all/es2017 122269176 ns/iter (± 845179) 122874601 ns/iter (± 1144855) 1.00
es/full/all/es2018 119262491 ns/iter (± 704508) 120620224 ns/iter (± 683775) 0.99
es/full/all/es2019 119142906 ns/iter (± 699161) 120391781 ns/iter (± 291343) 0.99
es/full/all/es2020 115087735 ns/iter (± 489936) 116211056 ns/iter (± 675776) 0.99
es/full/parser 532324 ns/iter (± 5537) 541855 ns/iter (± 5790) 0.98
es/full/base/fixer 17843 ns/iter (± 102) 18015 ns/iter (± 78) 0.99
es/full/base/resolver_and_hygiene 83419 ns/iter (± 341) 79816 ns/iter (± 197) 1.05
serialization of serde 313 ns/iter (± 0) 296 ns/iter (± 2) 1.06
css/minify/libraries/bootstrap 28804494 ns/iter (± 60180) 29244489 ns/iter (± 96806) 0.98
css/visitor/compare/clone 1705066 ns/iter (± 13033) 1721249 ns/iter (± 15907) 0.99
css/visitor/compare/visit_mut_span 1852360 ns/iter (± 10341) 1773733 ns/iter (± 16909) 1.04
css/visitor/compare/visit_mut_span_panic 1901649 ns/iter (± 10262) 1842106 ns/iter (± 19463) 1.03
css/visitor/compare/fold_span 2551860 ns/iter (± 8799) 2558860 ns/iter (± 15613) 1.00
css/visitor/compare/fold_span_panic 2738384 ns/iter (± 16756) 2740979 ns/iter (± 21554) 1.00
css/lexer/bootstrap_5_1_3 4442905 ns/iter (± 13502) 4435014 ns/iter (± 4696) 1.00
css/lexer/foundation_6_7_4 3741171 ns/iter (± 4303) 3778904 ns/iter (± 3829) 0.99
css/lexer/tailwind_3_1_1 712350 ns/iter (± 584) 717609 ns/iter (± 869) 0.99
css/parser/bootstrap_5_1_3 19463892 ns/iter (± 106192) 20210522 ns/iter (± 78698) 0.96
css/parser/foundation_6_7_4 15488167 ns/iter (± 58155) 16145955 ns/iter (± 59405) 0.96
css/parser/tailwind_3_1_1 2931215 ns/iter (± 3115) 3045956 ns/iter (± 4062) 0.96
es/codegen/colors 731943 ns/iter (± 400350) 732903 ns/iter (± 401609) 1.00
es/codegen/large 3130621 ns/iter (± 1665913) 3127056 ns/iter (± 1673809) 1.00
es/codegen/with-parser/colors 44940 ns/iter (± 525) 44367 ns/iter (± 556) 1.01
es/codegen/with-parser/large 490788 ns/iter (± 980) 481439 ns/iter (± 589) 1.02
es/minify/libraries/antd 1143400735 ns/iter (± 11674177) 1164414145 ns/iter (± 20707759) 0.98
es/minify/libraries/d3 239332797 ns/iter (± 624056) 241387672 ns/iter (± 830556) 0.99
es/minify/libraries/echarts 905693349 ns/iter (± 7012526) 939356005 ns/iter (± 21854255) 0.96
es/minify/libraries/jquery 73297861 ns/iter (± 86797) 73943968 ns/iter (± 392267) 0.99
es/minify/libraries/lodash 87761159 ns/iter (± 130020) 88179914 ns/iter (± 243949) 1.00
es/minify/libraries/moment 43189962 ns/iter (± 78891) 43351403 ns/iter (± 67003) 1.00
es/minify/libraries/react 15941658 ns/iter (± 38122) 15942140 ns/iter (± 39732) 1.00
es/minify/libraries/terser 187207423 ns/iter (± 335870) 188833816 ns/iter (± 1308249) 0.99
es/minify/libraries/three 322008389 ns/iter (± 2178351) 322540814 ns/iter (± 1545306) 1.00
es/minify/libraries/typescript 2281771213 ns/iter (± 13594038) 2322619958 ns/iter (± 19205112) 0.98
es/minify/libraries/victory 468817992 ns/iter (± 2661355) 477170121 ns/iter (± 5296910) 0.98
es/minify/libraries/vue 106102841 ns/iter (± 160062) 106603724 ns/iter (± 187681) 1.00
es/visitor/compare/clone 1978670 ns/iter (± 3361) 1963115 ns/iter (± 6619) 1.01
es/visitor/compare/visit_mut_span 2312064 ns/iter (± 3783) 2296233 ns/iter (± 7691) 1.01
es/visitor/compare/visit_mut_span_panic 2349628 ns/iter (± 4514) 2336948 ns/iter (± 5690) 1.01
es/visitor/compare/fold_span 3408651 ns/iter (± 5603) 3408692 ns/iter (± 9225) 1.00
es/visitor/compare/fold_span_panic 3547587 ns/iter (± 7777) 3531585 ns/iter (± 7501) 1.00
es/lexer/colors 12636 ns/iter (± 51) 12753 ns/iter (± 9) 0.99
es/lexer/angular 6015499 ns/iter (± 22608) 6130795 ns/iter (± 4651) 0.98
es/lexer/backbone 787252 ns/iter (± 1002) 802348 ns/iter (± 300) 0.98
es/lexer/jquery 4407667 ns/iter (± 2946) 4481176 ns/iter (± 7020) 0.98
es/lexer/jquery mobile 6805455 ns/iter (± 9032) 6880827 ns/iter (± 11154) 0.99
es/lexer/mootools 3526825 ns/iter (± 4438) 3579966 ns/iter (± 7580) 0.99
es/lexer/underscore 656173 ns/iter (± 696) 663843 ns/iter (± 188) 0.99
es/lexer/three 20975427 ns/iter (± 51179) 21156134 ns/iter (± 52888) 0.99
es/lexer/yui 3779767 ns/iter (± 1914) 3854811 ns/iter (± 5115) 0.98
es/parser/colors 26490 ns/iter (± 86) 26624 ns/iter (± 65) 0.99
es/parser/angular 13408797 ns/iter (± 65476) 13479489 ns/iter (± 176043) 0.99
es/parser/backbone 1992526 ns/iter (± 12096) 1986523 ns/iter (± 11181) 1.00
es/parser/jquery 10824544 ns/iter (± 53231) 10849861 ns/iter (± 52221) 1.00
es/parser/jquery mobile 16629803 ns/iter (± 54134) 16733380 ns/iter (± 73745) 0.99
es/parser/mootools 8339260 ns/iter (± 22924) 8343666 ns/iter (± 13748) 1.00
es/parser/underscore 1704953 ns/iter (± 11750) 1706197 ns/iter (± 9654) 1.00
es/parser/three 46165833 ns/iter (± 314244) 47335276 ns/iter (± 581729) 0.98
es/parser/yui 8236734 ns/iter (± 59990) 8238663 ns/iter (± 42346) 1.00
es/preset-env/usage/builtin_type 137269 ns/iter (± 32108) 136848 ns/iter (± 31955) 1.00
es/preset-env/usage/property 16742 ns/iter (± 57) 16810 ns/iter (± 103) 1.00
es/resolver/typescript 89098224 ns/iter (± 1045247) 91721099 ns/iter (± 1794596) 0.97
es/fixer/typescript 63969142 ns/iter (± 1341635) 65907863 ns/iter (± 700084) 0.97
es/hygiene/typescript 130747449 ns/iter (± 687809) 134848588 ns/iter (± 1068359) 0.97
es/resolver_with_hygiene/typescript 244939298 ns/iter (± 851876) 246598823 ns/iter (± 2748795) 0.99
es/visitor/base-perf/module_clone 59977 ns/iter (± 224) 60191 ns/iter (± 317) 1.00
es/visitor/base-perf/fold_empty 63675 ns/iter (± 637) 63741 ns/iter (± 222) 1.00
es/visitor/base-perf/fold_noop_impl_all 63602 ns/iter (± 688) 64016 ns/iter (± 307) 0.99
es/visitor/base-perf/fold_noop_impl_vec 64352 ns/iter (± 184) 64191 ns/iter (± 160) 1.00
es/visitor/base-perf/boxing_boxed_clone 59 ns/iter (± 0) 57 ns/iter (± 0) 1.04
es/visitor/base-perf/boxing_unboxed_clone 39 ns/iter (± 0) 39 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 107 ns/iter (± 0) 109 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_unboxed 75 ns/iter (± 0) 77 ns/iter (± 0) 0.97
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2509 ns/iter (± 9) 2512 ns/iter (± 14) 1.00
es/base/parallel/resolver/typescript 4412557942 ns/iter (± 252848349) 3823163795 ns/iter (± 302079470) 1.15
es/base/parallel/hygiene/typescript 1456572473 ns/iter (± 12495365) 1459577169 ns/iter (± 16035997) 1.00
misc/visitors/time-complexity/time 5 137 ns/iter (± 0) 137 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 363 ns/iter (± 5) 390 ns/iter (± 2) 0.93
misc/visitors/time-complexity/time 15 663 ns/iter (± 3) 661 ns/iter (± 3) 1.00
misc/visitors/time-complexity/time 20 1179 ns/iter (± 2) 1056 ns/iter (± 7) 1.12
misc/visitors/time-complexity/time 40 3501 ns/iter (± 18) 3497 ns/iter (± 45) 1.00
misc/visitors/time-complexity/time 60 8911 ns/iter (± 4) 7224 ns/iter (± 45) 1.23
es/full-target/es2016 240202 ns/iter (± 554) 237598 ns/iter (± 5622) 1.01
es/full-target/es2017 228277 ns/iter (± 612) 226391 ns/iter (± 559) 1.01
es/full-target/es2018 215509 ns/iter (± 808) 214236 ns/iter (± 441) 1.01
es2020_nullish_coalescing 71278 ns/iter (± 522) 71992 ns/iter (± 487) 0.99
es2020_optional_chaining 82544 ns/iter (± 280) 81982 ns/iter (± 336) 1.01
es2022_class_properties 120383 ns/iter (± 407) 118881 ns/iter (± 319) 1.01
es2018_object_rest_spread 75218 ns/iter (± 280) 74375 ns/iter (± 162) 1.01
es2019_optional_catch_binding 64259 ns/iter (± 196) 63922 ns/iter (± 172) 1.01
es2017_async_to_generator 64382 ns/iter (± 223) 63662 ns/iter (± 421) 1.01
es2016_exponentiation 69969 ns/iter (± 214) 69427 ns/iter (± 554) 1.01
es2015_arrow 72968 ns/iter (± 185) 71766 ns/iter (± 206) 1.02
es2015_block_scoped_fn 69536 ns/iter (± 353) 68531 ns/iter (± 182) 1.01
es2015_block_scoping 124358 ns/iter (± 444) 124311 ns/iter (± 609) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.