Skip to content

Commit

Permalink
test(es/compat): Add a test for a fixed issue (#6887)
Browse files Browse the repository at this point in the history 
**Related issue:**

 - Closes #6886.
  • Loading branch information
@kdy1
kdy1 committed Jan 31, 2023
1 parent 5160378 commit e79d466
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions crates/swc_ecma_transforms_compat/tests/opt-chain/issue-6886/exec.js
View file
@@ -0,0 +1,4 @@

const getToken = message => /token=(\w+)/.exec(message || getRequest()?.message)?.[1]

console.log('PASS')

1 comment on commit e79d466

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e79d466 Previous: 57781e9 Ratio
es/full/bugs-1 306667 ns/iter (± 12203) 303291 ns/iter (± 16570) 1.01
es/full/minify/libraries/antd 1860867982 ns/iter (± 32225504) 1733943928 ns/iter (± 51013518) 1.07
es/full/minify/libraries/d3 325920453 ns/iter (± 8457953) 299274544 ns/iter (± 9395034) 1.09
es/full/minify/libraries/echarts 1426195461 ns/iter (± 36013129) 1267742183 ns/iter (± 25015538) 1.12
es/full/minify/libraries/jquery 103338257 ns/iter (± 1524831) 89049011 ns/iter (± 1281799) 1.16
es/full/minify/libraries/lodash 118964508 ns/iter (± 5665027) 105541457 ns/iter (± 3695653) 1.13
es/full/minify/libraries/moment 54794323 ns/iter (± 805700) 52336813 ns/iter (± 582550) 1.05
es/full/minify/libraries/react 19580516 ns/iter (± 168287) 19165081 ns/iter (± 368805) 1.02
es/full/minify/libraries/terser 269585575 ns/iter (± 3719670) 248695540 ns/iter (± 4585471) 1.08
es/full/minify/libraries/three 486317354 ns/iter (± 20320355) 439843825 ns/iter (± 11775796) 1.11
es/full/minify/libraries/typescript 3356799868 ns/iter (± 36935108) 3259270338 ns/iter (± 37861058) 1.03
es/full/minify/libraries/victory 752981098 ns/iter (± 26990931) 666157226 ns/iter (± 21522815) 1.13
es/full/minify/libraries/vue 134834081 ns/iter (± 1299276) 127160033 ns/iter (± 2493113) 1.06
es/full/codegen/es3 25836 ns/iter (± 108) 26049 ns/iter (± 239) 0.99
es/full/codegen/es5 25728 ns/iter (± 116) 26554 ns/iter (± 190) 0.97
es/full/codegen/es2015 25691 ns/iter (± 185) 25997 ns/iter (± 268) 0.99
es/full/codegen/es2016 25804 ns/iter (± 311) 26163 ns/iter (± 371) 0.99
es/full/codegen/es2017 25704 ns/iter (± 270) 26014 ns/iter (± 162) 0.99
es/full/codegen/es2018 25576 ns/iter (± 405) 26004 ns/iter (± 448) 0.98
es/full/codegen/es2019 25379 ns/iter (± 255) 26148 ns/iter (± 285) 0.97
es/full/codegen/es2020 25349 ns/iter (± 310) 26090 ns/iter (± 410) 0.97
es/full/all/es3 171345048 ns/iter (± 2126041) 173908392 ns/iter (± 2468937) 0.99
es/full/all/es5 164825235 ns/iter (± 5135468) 166111476 ns/iter (± 2730177) 0.99
es/full/all/es2015 125878968 ns/iter (± 1102964) 126030765 ns/iter (± 3430630) 1.00
es/full/all/es2016 125388489 ns/iter (± 2426433) 125538470 ns/iter (± 1360183) 1.00
es/full/all/es2017 123731814 ns/iter (± 1698123) 123840480 ns/iter (± 2022094) 1.00
es/full/all/es2018 120148281 ns/iter (± 1367601) 120248262 ns/iter (± 1895969) 1.00
es/full/all/es2019 120740957 ns/iter (± 1224770) 120771382 ns/iter (± 2932808) 1.00
es/full/all/es2020 115594224 ns/iter (± 1182150) 114748012 ns/iter (± 1603589) 1.01
es/full/parser 528921 ns/iter (± 7346) 531639 ns/iter (± 15300) 0.99
es/full/base/fixer 21610 ns/iter (± 177) 21661 ns/iter (± 261) 1.00
es/full/base/resolver_and_hygiene 77820 ns/iter (± 786) 78126 ns/iter (± 594) 1.00
serialization of ast node 121 ns/iter (± 1) 119 ns/iter (± 1) 1.02
serialization of serde 125 ns/iter (± 1) 126 ns/iter (± 1) 0.99
css/minify/libraries/bootstrap 27071823 ns/iter (± 343475) 27341055 ns/iter (± 230291) 0.99
css/visitor/compare/clone 2022245 ns/iter (± 28939) 2045472 ns/iter (± 23737) 0.99
css/visitor/compare/visit_mut_span 2221319 ns/iter (± 29355) 2200420 ns/iter (± 21744) 1.01
css/visitor/compare/visit_mut_span_panic 2273966 ns/iter (± 13113) 2257657 ns/iter (± 17633) 1.01
css/visitor/compare/fold_span 2955000 ns/iter (± 34902) 2956057 ns/iter (± 47952) 1.00
css/visitor/compare/fold_span_panic 3118817 ns/iter (± 35087) 3068363 ns/iter (± 28246) 1.02
css/lexer/bootstrap_5_1_3 5180109 ns/iter (± 54937) 5030099 ns/iter (± 71392) 1.03
css/lexer/foundation_6_7_4 4268459 ns/iter (± 43669) 4186358 ns/iter (± 27319) 1.02
css/lexer/tailwind_3_1_1 818965 ns/iter (± 5018) 803422 ns/iter (± 9091) 1.02
css/parser/bootstrap_5_1_3 21762012 ns/iter (± 266753) 21250097 ns/iter (± 197238) 1.02
css/parser/foundation_6_7_4 17229436 ns/iter (± 175362) 16868886 ns/iter (± 247592) 1.02
css/parser/tailwind_3_1_1 3304238 ns/iter (± 16717) 3249342 ns/iter (± 38987) 1.02
es/codegen/colors 326476 ns/iter (± 184993) 337960 ns/iter (± 188867) 0.97
es/codegen/large 1195538 ns/iter (± 611091) 1032897 ns/iter (± 539307) 1.16
es/codegen/with-parser/colors 47686 ns/iter (± 489) 46602 ns/iter (± 738) 1.02
es/codegen/with-parser/large 522951 ns/iter (± 5367) 516957 ns/iter (± 3645) 1.01
es/minify/libraries/antd 1501657251 ns/iter (± 45455310) 1499523158 ns/iter (± 36939212) 1.00
es/minify/libraries/d3 260394679 ns/iter (± 9861835) 255661612 ns/iter (± 6942592) 1.02
es/minify/libraries/echarts 1150599582 ns/iter (± 22576474) 1079823474 ns/iter (± 18273013) 1.07
es/minify/libraries/jquery 77481578 ns/iter (± 949124) 76914628 ns/iter (± 978880) 1.01
es/minify/libraries/lodash 94831247 ns/iter (± 1207852) 93134692 ns/iter (± 1422696) 1.02
es/minify/libraries/moment 45490083 ns/iter (± 837056) 45749582 ns/iter (± 641396) 0.99
es/minify/libraries/react 16788013 ns/iter (± 167551) 16866706 ns/iter (± 140634) 1.00
es/minify/libraries/terser 207335038 ns/iter (± 5041313) 206921398 ns/iter (± 3699513) 1.00
es/minify/libraries/three 358671454 ns/iter (± 12532784) 353579488 ns/iter (± 8098980) 1.01
es/minify/libraries/typescript 2721300711 ns/iter (± 16149541) 2808502295 ns/iter (± 20985069) 0.97
es/minify/libraries/victory 540046055 ns/iter (± 17593424) 553716698 ns/iter (± 19332848) 0.98
es/minify/libraries/vue 112437539 ns/iter (± 1194015) 112481472 ns/iter (± 1723458) 1.00
es/visitor/compare/clone 2364855 ns/iter (± 32656) 2326580 ns/iter (± 25468) 1.02
es/visitor/compare/visit_mut_span 2716250 ns/iter (± 24848) 2696482 ns/iter (± 36087) 1.01
es/visitor/compare/visit_mut_span_panic 2817556 ns/iter (± 29069) 2754780 ns/iter (± 26368) 1.02
es/visitor/compare/fold_span 3824545 ns/iter (± 32713) 3837226 ns/iter (± 30011) 1.00
es/visitor/compare/fold_span_panic 3982153 ns/iter (± 27281) 3998347 ns/iter (± 44711) 1.00
es/lexer/colors 17194 ns/iter (± 246) 16940 ns/iter (± 177) 1.01
es/lexer/angular 8063266 ns/iter (± 95351) 8044756 ns/iter (± 43292) 1.00
es/lexer/backbone 1068007 ns/iter (± 5984) 1056537 ns/iter (± 10047) 1.01
es/lexer/jquery 5827640 ns/iter (± 60191) 5810177 ns/iter (± 79621) 1.00
es/lexer/jquery mobile 8975276 ns/iter (± 61708) 9040082 ns/iter (± 119443) 0.99
es/lexer/mootools 4563641 ns/iter (± 43221) 4581859 ns/iter (± 37756) 1.00
es/lexer/underscore 877561 ns/iter (± 6626) 885581 ns/iter (± 10845) 0.99
es/lexer/three 27287786 ns/iter (± 371840) 27083040 ns/iter (± 166917) 1.01
es/lexer/yui 4916161 ns/iter (± 39326) 4935632 ns/iter (± 28458) 1.00
es/parser/colors 30401 ns/iter (± 290) 30388 ns/iter (± 454) 1.00
es/parser/angular 15508602 ns/iter (± 241655) 15699832 ns/iter (± 371747) 0.99
es/parser/backbone 2275899 ns/iter (± 17762) 2265935 ns/iter (± 31022) 1.00
es/parser/jquery 12165311 ns/iter (± 134698) 12335422 ns/iter (± 106355) 0.99
es/parser/jquery mobile 18970191 ns/iter (± 301532) 19297796 ns/iter (± 325457) 0.98
es/parser/mootools 9210696 ns/iter (± 114033) 9276789 ns/iter (± 159109) 0.99
es/parser/underscore 1904769 ns/iter (± 29130) 1933896 ns/iter (± 19594) 0.98
es/parser/three 55661425 ns/iter (± 2291183) 55916414 ns/iter (± 825592) 1.00
es/parser/yui 9569496 ns/iter (± 65311) 9430863 ns/iter (± 111271) 1.01
es/preset-env/usage/builtin_type 139422 ns/iter (± 32263) 141159 ns/iter (± 32841) 0.99
es/preset-env/usage/property 20829 ns/iter (± 165) 20237 ns/iter (± 182) 1.03
es/resolver/typescript 123673795 ns/iter (± 3725123) 115982267 ns/iter (± 2808460) 1.07
es/fixer/typescript 96680456 ns/iter (± 2678499) 90001749 ns/iter (± 1508819) 1.07
es/hygiene/typescript 199631158 ns/iter (± 2144955) 190594974 ns/iter (± 2822436) 1.05
es/resolver_with_hygiene/typescript 338211633 ns/iter (± 3213081) 327180138 ns/iter (± 5087384) 1.03
es/visitor/base-perf/module_clone 75463 ns/iter (± 1364) 75501 ns/iter (± 2006) 1.00
es/visitor/base-perf/fold_empty 84878 ns/iter (± 1115) 84812 ns/iter (± 1405) 1.00
es/visitor/base-perf/fold_noop_impl_all 85255 ns/iter (± 1692) 84703 ns/iter (± 1317) 1.01
es/visitor/base-perf/fold_noop_impl_vec 84986 ns/iter (± 1639) 83694 ns/iter (± 1596) 1.02
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 58 ns/iter (± 0) 0.97
es/visitor/base-perf/boxing_unboxed_clone 58 ns/iter (± 0) 58 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 104 ns/iter (± 0) 104 ns/iter (± 1) 1
es/visitor/base-perf/boxing_unboxed 103 ns/iter (± 0) 100 ns/iter (± 0) 1.03
es/visitor/base-perf/visit_contains_this 3336 ns/iter (± 68) 3514 ns/iter (± 50) 0.95
es/base/parallel/resolver/typescript 6061953014 ns/iter (± 560657309) 6010038776 ns/iter (± 660487649) 1.01
es/base/parallel/hygiene/typescript 2449905416 ns/iter (± 31947874) 2464016960 ns/iter (± 36857365) 0.99
misc/visitors/time-complexity/time 5 101 ns/iter (± 0) 101 ns/iter (± 1) 1
misc/visitors/time-complexity/time 10 327 ns/iter (± 4) 312 ns/iter (± 3) 1.05
misc/visitors/time-complexity/time 15 651 ns/iter (± 3) 651 ns/iter (± 10) 1
misc/visitors/time-complexity/time 20 1254 ns/iter (± 52) 1271 ns/iter (± 12) 0.99
misc/visitors/time-complexity/time 40 6505 ns/iter (± 48) 6455 ns/iter (± 72) 1.01
misc/visitors/time-complexity/time 60 16713 ns/iter (± 101) 16889 ns/iter (± 282) 0.99
es/full-target/es2016 186529 ns/iter (± 1146) 185642 ns/iter (± 1383) 1.00
es/full-target/es2017 177994 ns/iter (± 928) 177164 ns/iter (± 3029) 1.00
es/full-target/es2018 167018 ns/iter (± 739) 171974 ns/iter (± 1111) 0.97
es2020_nullish_coalescing 65499 ns/iter (± 404) 66351 ns/iter (± 530) 0.99
es2020_optional_chaining 93446 ns/iter (± 677) 94715 ns/iter (± 6881) 0.99
es2022_class_properties 91541 ns/iter (± 688) 93792 ns/iter (± 455) 0.98
es2018_object_rest_spread 69745 ns/iter (± 429) 71157 ns/iter (± 658) 0.98
es2019_optional_catch_binding 59952 ns/iter (± 390) 60672 ns/iter (± 689) 0.99
es2017_async_to_generator 60944 ns/iter (± 297) 60885 ns/iter (± 574) 1.00
es2016_exponentiation 63989 ns/iter (± 630) 64354 ns/iter (± 783) 0.99
es2015_arrow 68872 ns/iter (± 333) 70110 ns/iter (± 752) 0.98
es2015_block_scoped_fn 64986 ns/iter (± 542) 66281 ns/iter (± 375) 0.98
es2015_block_scoping 155055 ns/iter (± 8433) 158260 ns/iter (± 9691) 0.98
es2015_classes 114582 ns/iter (± 1005) 114509 ns/iter (± 1941) 1.00
es2015_computed_props 59723 ns/iter (± 287) 60398 ns/iter (± 605) 0.99
es2015_destructuring 114415 ns/iter (± 1090) 115627 ns/iter (± 1201) 0.99
es2015_duplicate_keys 62727 ns/iter (± 267) 61988 ns/iter (± 549) 1.01
es2015_parameters 78300 ns/iter (± 562) 78123 ns/iter (± 1193) 1.00
es2015_fn_name 65246 ns/iter (± 483) 65269 ns/iter (± 640) 1.00
es2015_for_of 62555 ns/iter (± 361) 62817 ns/iter (± 650) 1.00
es2015_instanceof 61733 ns/iter (± 374) 62072 ns/iter (± 331) 0.99
es2015_shorthand_property 59655 ns/iter (± 358) 59194 ns/iter (± 415) 1.01
es2015_spread 59152 ns/iter (± 371) 59297 ns/iter (± 412) 1.00
es2015_sticky_regex 60816 ns/iter (± 470) 61026 ns/iter (± 747) 1.00
es2015_typeof_symbol 61008 ns/iter (± 396) 60975 ns/iter (± 788) 1.00
es/transform/baseline/base 50860 ns/iter (± 464) 51347 ns/iter (± 424) 0.99
es/transform/baseline/common_reserved_word 60403 ns/iter (± 436) 61162 ns/iter (± 460) 0.99
es/transform/baseline/common_typescript 144454 ns/iter (± 12750) 138943 ns/iter (± 2083) 1.04
es/target/es3 164537 ns/iter (± 1021) 163605 ns/iter (± 1634) 1.01
es/target/es2015 613231 ns/iter (± 5648) 603532 ns/iter (± 3522) 1.02
es/target/es2016 63647 ns/iter (± 713) 63213 ns/iter (± 518) 1.01
es/target/es2017 59889 ns/iter (± 371) 59330 ns/iter (± 656) 1.01
es/target/es2018 79860 ns/iter (± 768) 79165 ns/iter (± 881) 1.01
es/target/es2020 131257 ns/iter (± 1779) 128174 ns/iter (± 1210) 1.02
babelify-only 652178 ns/iter (± 6756) 678531 ns/iter (± 1821) 0.96
parse_and_babelify_angular 44272285 ns/iter (± 714709) 44750114 ns/iter (± 890218) 0.99
parse_and_babelify_backbone 5454210 ns/iter (± 98639) 5404620 ns/iter (± 109246) 1.01
parse_and_babelify_jquery 31668626 ns/iter (± 987354) 32046735 ns/iter (± 663327) 0.99
parse_and_babelify_jquery_mobile 55678540 ns/iter (± 1487167) 55707249 ns/iter (± 1409763) 1.00
parse_and_babelify_mootools 35338329 ns/iter (± 1008072) 33427694 ns/iter (± 1131600) 1.06
parse_and_babelify_underscore 4346341 ns/iter (± 66364) 4343721 ns/iter (± 74540) 1.00
parse_and_babelify_yui 32464837 ns/iter (± 497004) 34707159 ns/iter (± 1210764) 0.94
html/minify/document/css_spec 41221763 ns/iter (± 649555) 41631845 ns/iter (± 431253) 0.99
html/minify/document/github 17144039 ns/iter (± 263601) 17348910 ns/iter (± 280565) 0.99
html/minify/document/stackoverflow 15505329 ns/iter (± 137585) 15443055 ns/iter (± 174324) 1.00
html/minify/document_fragment/css_spec 39433582 ns/iter (± 1173662) 39863686 ns/iter (± 593616) 0.99
html/minify/document_fragment/github 16430186 ns/iter (± 169715) 16757806 ns/iter (± 145736) 0.98
html/minify/document_fragment/stackoverflow 15264868 ns/iter (± 219564) 14986392 ns/iter (± 134132) 1.02
html/document/visitor/compare/clone 342852 ns/iter (± 3734) 341196 ns/iter (± 3469) 1.00
html/document/visitor/compare/visit_mut_span 368789 ns/iter (± 2691) 362615 ns/iter (± 2055) 1.02
html/document/visitor/compare/visit_mut_span_panic 376347 ns/iter (± 3406) 365165 ns/iter (± 6110) 1.03
html/document/visitor/compare/fold_span 402010 ns/iter (± 3472) 401196 ns/iter (± 3281) 1.00
html/document/visitor/compare/fold_span_panic 462961 ns/iter (± 4300) 459511 ns/iter (± 4289) 1.01
html/document_fragment/visitor/compare/clone 338217 ns/iter (± 2738) 335276 ns/iter (± 3910) 1.01
html/document_fragment/visitor/compare/visit_mut_span 368579 ns/iter (± 2031) 366262 ns/iter (± 2752) 1.01
html/document_fragment/visitor/compare/visit_mut_span_panic 376360 ns/iter (± 1738) 376850 ns/iter (± 2187) 1.00
html/document_fragment/visitor/compare/fold_span 406960 ns/iter (± 3751) 402582 ns/iter (± 3694) 1.01
html/document_fragment/visitor/compare/fold_span_panic 452852 ns/iter (± 3692) 456298 ns/iter (± 1846) 0.99
html/lexer/css_2021_spec 15598888 ns/iter (± 27807) 15494874 ns/iter (± 130133) 1.01
html/lexer/github_com_17_05_2022 6015358 ns/iter (± 19842) 5911381 ns/iter (± 29564) 1.02
html/lexer/stackoverflow_com_17_05_2022 5658050 ns/iter (± 6921) 5604983 ns/iter (± 36848) 1.01
html/parser/parser_document/css_2021_spec 25263917 ns/iter (± 281226) 24466746 ns/iter (± 703609) 1.03
html/parser/parser_document/github_com_17_05_2022 9065434 ns/iter (± 50630) 8648162 ns/iter (± 100765) 1.05
html/parser/parser_document/stackoverflow_com_17_05_2022 8179112 ns/iter (± 33888) 7672282 ns/iter (± 143196) 1.07
html/parser/parser_document_fragment/css_2021_spec 25123907 ns/iter (± 185541) 25058777 ns/iter (± 329571) 1.00
html/parser/parser_document_fragment/github_com_17_05_2022 8749897 ns/iter (± 29211) 8606683 ns/iter (± 76678) 1.02
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7642944 ns/iter (± 48730) 7663803 ns/iter (± 81932) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.