Source maps missing end range #1796
Comments
kdy1
added a commit
to kdy1/swc
that referenced
this issue
Jun 18, 2021
kdy1
added a commit
that referenced
this issue
Jun 18, 2021
swc_common: - `SourceMap`: Don't panic for dummy spans. swc_ecma_codegen: - Use span for `throw`. (#1685) - Use span for `var` / `let` / `const`. - Use span for `new`. - Use span for `if`. - Add spans to braces of a block statement. (#1796) swc_ecma_transforms_compat: - `parameters`: Don't drop the span of block statements. (#1796) swc: - Allow specifying input source map in `.swcrc`. - Ensure that the inline source map works properly. (#1713)
|
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue Description / Background
Firstly - great job on
swc, today was the first time we had used it and it really is very very fast! 馃槉Today we discovered that
swcsource maps are missing end ranges for multi-line blocks, which causes problems for various developer tooling the relies on source maps, including istanbul.js and our product, Wallaby.js.While source maps are lossy by nature, most source maps include a mapping for the end range of certain types of ast nodes (e.g. ExpressionStatements). These appear to be missing for
swcsource maps which breaks JavaScript developer tooling that relies on these.After identifying the problem, we have used https://sokra.github.io/source-map-visualization/#custom to visualize the problem for you and have compared
swc,BabelandTypeScript(see below). You will see in theswcsource maps, there is no mapping afterthrow new Error('boom');while there is forTypeScriptandBabel.swc
TypeScript
Babel
We have also provide the sample repo that you can use to generate the transformed files and their source maps (refer to
package.jsonscripts).Is this by design or a bug? If it is by design, what is your guidance to determine source-code mapping for end-of-range for
swctransformed files (e.g. we have the original source file + line + column after at the end of the file)? From a development tooling perspective, it would be ideal if the source maps would behave similarly to either Babel or TypeScript if at all possible.The text was updated successfully, but these errors were encountered: