Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bytechecked deserialization for the plugin #5472

Closed
kwonoj opened this issue Aug 13, 2022 · 2 comments
Closed

Enable bytechecked deserialization for the plugin #5472

kwonoj opened this issue Aug 13, 2022 · 2 comments

Comments

@kwonoj
Copy link
Member

kwonoj commented Aug 13, 2022

Describe the feature

We are currently doing unchecked deserialization (https://github.com/swc-project/swc/blob/main/crates/swc_common/src/plugin/serialized.rs#L124) for the plugin deserializations.

This was deliberated decision at the moment, however it exposes some of cons recently - as it implies, it is unsafe operation and can take down host randomly without having additional details. We could try checked instead to ensure host - plugin can exchange data as expected, and know it'll fail prior to actual serialization.

Unfortunately this is blocked by #5406, since this requires to enable bytecheck for each structs. We may carefully approach enabling bytecheck first to get there.

Babel plugin or link to the feature description

No response

Additional context

No response

@kwonoj
Copy link
Member Author

kwonoj commented May 7, 2023

#7280

@kwonoj kwonoj closed this as completed May 7, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.57 May 9, 2023
@swc-bot
Copy link
Collaborator

swc-bot commented Jun 8, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants