Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swc minifier breaks react-joyride #6491

Closed
kdy1 opened this issue Nov 21, 2022 · 2 comments · Fixed by #6509
Closed

swc minifier breaks react-joyride #6491

kdy1 opened this issue Nov 21, 2022 · 2 comments · Fixed by #6509
Assignees
@kdy1
Milestone
v1.3.21

Comments

@kdy1
Copy link
Member

kdy1 commented Nov 21, 2022

vercel/next.js#30237 (comment)

Repro: https://github.com/JClackett/next-react-joyride

I'll work on this issue hopefully on this weekend
@kdy1 kdy1 added this to the Planned milestone Nov 21, 2022
@kdy1 kdy1 self-assigned this Nov 21, 2022
@kdy1
Copy link
Member Author

kdy1 commented Nov 25, 2022

Investigation:

This seems like an issue of inliner.

image

works, while

image

is broken

@kdy1 kdy1 mentioned this issue Nov 25, 2022
Merged
kdy1 added a commit that referenced this issue Nov 29, 2022
@kdy1
fix(es/minifier): Make sequential inliner respect resolution order (#…
27ae59e 
…6509)

**Related issue:**

 - Closes #6491.
@kdy1 kdy1 modified the milestones: Planned, v1.3.21 Nov 30, 2022
@swc-bot
Copy link
Collaborator

swc-bot commented Dec 30, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.21
Development

Successfully merging a pull request may close this issue.

fix(es/minifier): Make sequential inliner respect resolution order kdy1/swc
2 participants
@kdy1 @swc-bot