Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ES parsing errors pretty #6525

Closed
kdy1 opened this issue Nov 28, 2022 · 1 comment · Fixed by #6535
Closed

Make ES parsing errors pretty #6525

kdy1 opened this issue Nov 28, 2022 · 1 comment · Fixed by #6535
Assignees
@kdy1
Labels
enhancement
Milestone
v1.3.21

Comments

@kdy1
Copy link
Member

kdy1 commented Nov 28, 2022 •
edited

Describe the feature

I think miette does not support coloring source codes, but it allows adding more span with colors

image

Also, we should print more lines. (3 before, 3 after, just like babel)
@kdy1 kdy1 added this to the Planned milestone Nov 28, 2022
@kdy1 kdy1 self-assigned this Nov 28, 2022
@kdy1 kdy1 changed the title Make parsing errors pretty Make ES parsing errors pretty Nov 28, 2022
@kdy1 kdy1 mentioned this issue Nov 28, 2022
Merged
kdy1 added a commit that referenced this issue Nov 28, 2022
@kdy1
feat(common): Add contexts to the error messages (#6526)
b8fe04f 
**Description:**

This PR makes the error reporter print contexts.

**Related issue:**

 - #6525.
@kdy1 kdy1 mentioned this issue Nov 29, 2022
Merged
kdy1 added a commit that referenced this issue Nov 29, 2022
@kdy1
feat(es/parser): Make error message helpful (#6535)
cb15721 
**Related issue:**

 - Closes #6525.
@kdy1 kdy1 modified the milestones: Planned, v1.3.21 Nov 30, 2022
@swc-bot
Copy link
Collaborator

swc-bot commented Dec 30, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
enhancement
Milestone
v1.3.21
Development

Successfully merging a pull request may close this issue.

feat(es/parser): Make error message helpful kdy1/swc
2 participants
@kdy1 @swc-bot