Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for loop optimization: keep "this" #698

Closed
kapouer opened this issue Mar 3, 2020 · 1 comment · Fixed by #700
Closed

for loop optimization: keep "this" #698

kapouer opened this issue Mar 3, 2020 · 1 comment · Fixed by #700
Assignees
Labels
Milestone

Comments

@kapouer
Copy link

kapouer commented Mar 3, 2020

Input code
Same example as in #686.

Config
Same config as in #686.

Output code

var _loop = function(i) {
  elem = this.elements[i];
  ../..
};
for(var i = 0; i < this.elements.length; i++)_loop(i);

Expected behavior

var _loop = function(i) {
  elem = this.elements[i];
  ../..
};
for(var i = 0; i < this.elements.length; i++)_loop.call(this, i);

Version
The version of @swc/core: 1.1.31

@kapouer kapouer added the C-bug label Mar 3, 2020
@kdy1 kdy1 added this to the v1.1.32 milestone Mar 3, 2020
kdy1 added a commit to kdy1/swc that referenced this issue Mar 4, 2020
@kdy1 kdy1 self-assigned this Mar 4, 2020
@kdy1 kdy1 closed this as completed in #700 Mar 4, 2020
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 28, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants