Performance regression after v1.4.1-nightly-20240210.1

[davidmurdoch]

Describe the bug

Updating from v1.4.1-nightly-20240210.1 to any version thereafter results in a 10-20% increase in compilation time.

I think the update that caused the slow down is related to the latest wasmer update.

Input code

git clone https://github.com/MetaMask/metamask-extension.git
cd metamask-extension
git checkout webpack-perf-regression
nvm use # or use Node v20 if you don't use nvm for managing node version
corepack enable # makes it use correct yarn version
mv .metamaskrc.dist .metamaskrc
yarn
time yarn webpack --no-cache # take note of the time
yarn up @swc/core@1.4.1-nightly-20240210.1 # install faster version of @swc/core
time yarn webpack --no-cache # this should be about 10-20% faster

### Config

```json
n/a, this is a webpack-based project using a basic webpack loader.

Loader: https://github.com/MetaMask/metamask-extension/blob/webpack-perf-regression/development/webpack/utils/loaders/swcLoader.ts

Loader usage is here: https://github.com/MetaMask/metamask-extension/blob/e885236f1b42969106e8b88a0d7e66de3921e999/development/webpack/webpack.config.ts#L105

Playground link (or link to the minimal reproduction)

https://github.com/MetaMask/metamask-extension/tree/webpack-perf-regression

SWC Info output

(I'm away from my desk, but will fill this out later)

Expected behavior

Performance should remain roughly the same between versions.

Actual behavior

It got slower 🥲

Version

v1.4.5

Additional context

Original discussion: https://discord.com/channels/889779439272075314/889780921002246154/1215428591945383936

[kdy1]

Actually I expected some minor performance improvement while updating wasmer...

[davidmurdoch]

Actually I expected some minor performance improvement while updating wasmer...

Yeah, a bit surprising as their release notes even site since performance improvements. I noticed in the PR you create a new tokio runtime for each call to compute and transform_sync, I don't know Rust, but it seems that might cause a bit of additional overhead if it needs to be instantiated for every file (like I'm guessing it would when used with webpack).

[davidmurdoch]

Tested the latest release and the performance is back! It is not seem to be any faster or slower for my workflow. Thanks!

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.