Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swc-css wrongly transform transform:rotate(-90deg) to transform:(270deg) #9070

Closed
hardfist opened this issue Jun 18, 2024 · 1 comment · Fixed by #9072
Closed

swc-css wrongly transform transform:rotate(-90deg) to transform:(270deg) #9070

hardfist opened this issue Jun 18, 2024 · 1 comment · Fixed by #9072

Comments

@hardfist
Copy link
Contributor

hardfist commented Jun 18, 2024

Describe the bug

It seems swc-css-minifier will do normalize deg for rotate which seems wrong
https://github.com/swc-project/swc/blob/main/crates/swc_css_minifier/src/compressor/angle.rs#L56-L64
transformed deg seems not identical for css animation
I check the lighting-css、esbuild、cssnano behavior, they seems don't do transform deg for rotate

Input code

.text {
  transform: rotate(-90deg);
}

Config

latest main branch(ae6ab656fa0cbf2a5cde0523f8282a7eb61a7245)

Playground link (or link to the minimal reproduction)

none

SWC Info output

Operating System:
    Platform: darwin
    Arch: arm64
    Machine Type: arm64
    Version: Darwin Kernel Version 23.2.0: Wed Nov 15 21:54:05 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6031
    CPU: (14 cores)
        Models: Apple M3 Max

Binaries:
    Node: 18.19.0
    npm: 10.2.3
    Yarn: 4.0.2
    pnpm: N/A

Relevant Packages:
    @swc/core: N/A
    @swc/helpers: N/A
    @swc/types: N/A
    

SWC Config:
    output: N/A
    .swcrc path: N/A

Next.js info:
    output: N/A

Expected behavior

keep the original deg

Actual behavior

transformed into

.text {
  transform: rotate(270deg);
}

Version

latest main branch

Additional context

No response

Copy link

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository or a link to the SWC playground.

The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

  • If you did not provide a link or the link you provided is not valid, we will close the issue.
  • If you provide a link to a private repository, we will close the issue.
  • If you provide a link to a repository but not in the correct section, we will close the issue.

What should I do?

Depending on the reason the issue was closed, you can do the following:

  • If you did not provide a link, please open a new issue with a link to a reproduction.
  • If you provided a link to a private repository, please open a new issue with a link to a public repository.
  • If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

  • Remove any code that is not related to the issue. (pages, API routes, components, etc.)
  • Remove any dependencies that are not related to the issue.
  • Remove any third-party service that would require us to sign up for an account to reproduce the issue.
  • Remove any environment variables that are not related to the issue.
  • Remove private packages that we do not have access to.
  • If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every SWC issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@swc-project swc-project unlocked this conversation Jun 18, 2024
@kdy1 kdy1 reopened this Jun 18, 2024
@kdy1 kdy1 added this to the Planned milestone Jun 18, 2024
@kdy1 kdy1 closed this as completed in 8d37dae Jun 18, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.6.3 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants