Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/minifier): Don't tranform rotate deg #9072

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix(css/minifier): Don't tranform rotate deg #9072

merged 2 commits into from
Jun 18, 2024

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Jun 18, 2024 •
edited by kdy1
Loading

Description:
transform rotate deg will cause animation work differently, so don't do transform for rotate deg

Related issue:

@hardfist hardfist requested a review from a team as a code owner June 18, 2024 02:42
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 self-assigned this Jun 18, 2024
@kdy1 kdy1 added this to the Planned milestone Jun 18, 2024
@kdy1 kdy1 enabled auto-merge (squash) June 18, 2024 02:56
@kdy1 kdy1 changed the title fix(css/minifier): don't tranform rotate deg fix(css/minifier): Don't tranform rotate deg Jun 18, 2024
kdy1
kdy1 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_minifier
  • swc_core

swc-bot
swc-bot reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 8d37dae into swc-project:main Jun 18, 2024
148 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.6.3 Jun 19, 2024
@hardfist hardfist mentioned this pull request Jun 22, 2024
Merged
2 tasks
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.6.3
Development

Successfully merging this pull request may close these issues.

swc-css wrongly transform transform:rotate(-90deg) to transform:(270deg)
4 participants
@hardfist @CLAassistant @kdy1 @swc-bot